Re: [systemd-devel] [PATCH] rpcbind: add support for systemd socket activation

2014-11-26 Thread Steve Dickson
On 11/25/2014 12:05 PM, Steve Dickson wrote: > From: Tom Gundersen > > Making rpcbind sockect activated will greatly simplify > its integration in systemd systems. In essence, other services > may now assume that rpcbind is always available, even during very > early boot. This means that we no

[systemd-devel] [PATCH] rpcbind: add support for systemd socket activation

2014-11-25 Thread Steve Dickson
From: Tom Gundersen Making rpcbind sockect activated will greatly simplify its integration in systemd systems. In essence, other services may now assume that rpcbind is always available, even during very early boot. This means that we no longer need to worry about any ordering dependencies. Orig

Re: [systemd-devel] [PATCH] rpcbind: add support for systemd socket activation

2014-11-25 Thread Steve Dickson
Hello, On 11/22/2014 09:24 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Fri, Nov 21, 2014 at 11:43:47AM -0500, Steve Dickson wrote: >> From: Tom Gundersen >> >> Making rpcbind sockect activated will greatly simplify >> its integration in systemd systems. In essence, other services >> may now assum

Re: [systemd-devel] [PATCH] rpcbind: add support for systemd socket activation

2014-11-22 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Nov 21, 2014 at 11:43:47AM -0500, Steve Dickson wrote: > From: Tom Gundersen > > Making rpcbind sockect activated will greatly simplify > its integration in systemd systems. In essence, other services > may now assume that rpcbind is always available, even during very > early boot. This m

[systemd-devel] [PATCH] rpcbind: add support for systemd socket activation

2014-11-21 Thread Steve Dickson
From: Tom Gundersen Making rpcbind sockect activated will greatly simplify its integration in systemd systems. In essence, other services may now assume that rpcbind is always available, even during very early boot. This means that we no longer need to worry about any ordering dependencies. This

Re: [systemd-devel] [PATCH] rpcbind: add support for systemd socket activation

2012-02-03 Thread Chuck Lever
Hi- On Feb 1, 2012, at 11:37 AM, Tom Gundersen wrote: > Hi Chuck, > > Thanks for the feedback. > > On Wed, Feb 1, 2012 at 4:32 PM, Chuck Lever wrote: >> Typically this is done by breaking the proposed change into smaller atomic >> patches. Is that not possible in this case? > > Not entirely

Re: [systemd-devel] [PATCH] rpcbind: add support for systemd socket activation

2012-02-01 Thread Lennart Poettering
On Wed, 01.02.12 17:03, Chuck Lever (chuck.le...@oracle.com) wrote: > >>> Why is sockaddr_storage included in this union? > >> > >> This is from Lennart's original patch. Lennart, care to comment? > > > > Well, simply because sockaddr_storage is the actual struct one should > > normally use for

Re: [systemd-devel] [PATCH] rpcbind: add support for systemd socket activation

2012-02-01 Thread Chuck Lever
On Feb 1, 2012, at 4:45 PM, Lennart Poettering wrote: > On Wed, 01.02.12 17:37, Tom Gundersen (t...@jklm.no) wrote: > + /* Try to find if one of the systemd sockets we were given match + * our netconfig structure. */ + + for (fd = SD_LISTEN_FDS_START; fd < SD_LIS

Re: [systemd-devel] [PATCH] rpcbind: add support for systemd socket activation

2012-02-01 Thread Lennart Poettering
On Wed, 01.02.12 17:37, Tom Gundersen (t...@jklm.no) wrote: > >> +     /* Try to find if one of the systemd sockets we were given match > >> +      * our netconfig structure. */ > >> + > >> +     for (fd = SD_LISTEN_FDS_START; fd < SD_LISTEN_FDS_START + n; fd++) { > >> +             struct __rpc_s

Re: [systemd-devel] [PATCH] rpcbind: add support for systemd socket activation

2012-02-01 Thread Chuck Lever
Hi- On Feb 1, 2012, at 6:47 AM, Tom Gundersen wrote: > Making rpcbind sockect activated will greatly simplify > its integration in systemd systems. In essence, other services > may now assume that rpcbind is always available, even during very > early boot. This means that we no longer need to wor

Re: [systemd-devel] [PATCH] rpcbind: add support for systemd socket activation

2012-02-01 Thread Tom Gundersen
On Wed, Feb 1, 2012 at 7:16 PM, Chuck Lever wrote: > Submit the patch you have below, then white space fixes become subsequent > clean up patches.  Not only is review easier now, but if we come back to > these changes in a year to fix bugs, it's easier for us to re-learn what it > does. I'll r

Re: [systemd-devel] [PATCH] rpcbind: add support for systemd socket activation

2012-02-01 Thread Chuck Lever
On Feb 1, 2012, at 11:37 AM, Tom Gundersen wrote: > Hi Chuck, > > Thanks for the feedback. > > On Wed, Feb 1, 2012 at 4:32 PM, Chuck Lever wrote: >> Typically this is done by breaking the proposed change into smaller atomic >> patches. Is that not possible in this case? > > Not entirely sur

Re: [systemd-devel] [PATCH] rpcbind: add support for systemd socket activation

2012-02-01 Thread Tom Gundersen
Hi Chuck, Thanks for the feedback. On Wed, Feb 1, 2012 at 4:32 PM, Chuck Lever wrote: > Typically this is done by breaking the proposed change into smaller atomic > patches.  Is that not possible in this case? Not entirely sure what you have in mind, I don't immediately see how to split this u

Re: [systemd-devel] [PATCH] rpcbind: add support for systemd socket activation

2012-02-01 Thread Chuck Lever
Adding libtirpc developers mailing list... On Feb 1, 2012, at 6:47 AM, Tom Gundersen wrote: > Making rpcbind sockect activated will greatly simplify > its integration in systemd systems. In essence, other services > may now assume that rpcbind is always available, even during very > early boot. T

Re: [systemd-devel] [PATCH] rpcbind: add support for systemd socket activation

2012-02-01 Thread Tom Gundersen
Hi Zbyszek, 2012/2/1 Zbigniew Jędrzejewski-Szmek : > exactly what version of rpcbind is this supposed to be applied against? Current git head. > (Even better, could you post a link to a git repo?) Sure, the patch can be found on my wip branch here: .

Re: [systemd-devel] [PATCH] rpcbind: add support for systemd socket activation

2012-02-01 Thread Zbigniew Jędrzejewski-Szmek
Hi, exactly what version of rpcbind is this supposed to be applied against? (Even better, could you post a link to a git repo?) Confused, Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/lis

[systemd-devel] [PATCH] rpcbind: add support for systemd socket activation

2012-02-01 Thread Tom Gundersen
Making rpcbind sockect activated will greatly simplify its integration in systemd systems. In essence, other services may now assume that rpcbind is always available, even during very early boot. This means that we no longer need to worry about any ordering dependencies. This is based on a patch o

Re: [systemd-devel] [PATCH] rpcbind: add support for systemd socket activation

2011-12-22 Thread Cristian Rodríguez
On 22/12/11 22:05, Tom Gundersen wrote: Making rpcbind sockect activated will greatly simplify its integration in systemd systems. In essence, other services may now assume that rpcbind is always available, even during very early boot. This means that we no longer need to worry about any ordering

[systemd-devel] [PATCH] rpcbind: add support for systemd socket activation

2011-12-22 Thread Tom Gundersen
Making rpcbind sockect activated will greatly simplify its integration in systemd systems. In essence, other services may now assume that rpcbind is always available, even during very early boot. This means that we no longer need to worry about any ordering dependencies. This is based on a patch o