Re: [systemd-devel] [PATCH] sd-bus: use isempty() consistently

2015-07-20 Thread Namhyung Kim
Hi, On Mon, Jul 20, 2015 at 06:14:22AM -0400, Daniel Mack wrote: > On 07/19/2015 11:01 AM, Namhyung Kim wrote: > > Signed-off-by: Namhyung Kim > > Looks good, thanks! However, it does not apply against current master. > Care to rebase? Also, we generally prefer GitHub pull requests these > days.

Re: [systemd-devel] [PATCH] sd-bus: use isempty() consistently

2015-07-20 Thread Daniel Mack
On 07/20/2015 02:06 PM, Mantas Mikulėnas wrote: > On Mon, Jul 20, 2015 at 1:14 PM, Daniel Mack > wrote: > > On 07/19/2015 11:01 AM, Namhyung Kim wrote: > > Signed-off-by: Namhyung Kim > > > Looks good, thanks! However, it does

Re: [systemd-devel] [PATCH] sd-bus: use isempty() consistently

2015-07-20 Thread Mantas Mikulėnas
On Mon, Jul 20, 2015 at 1:14 PM, Daniel Mack wrote: > On 07/19/2015 11:01 AM, Namhyung Kim wrote: > > Signed-off-by: Namhyung Kim > > Looks good, thanks! However, it does not apply against current master. > Care to rebase? Also, we generally prefer GitHub pull requests these > days. And you can

Re: [systemd-devel] [PATCH] sd-bus: use isempty() consistently

2015-07-20 Thread Daniel Mack
On 07/19/2015 11:01 AM, Namhyung Kim wrote: > Signed-off-by: Namhyung Kim Looks good, thanks! However, it does not apply against current master. Care to rebase? Also, we generally prefer GitHub pull requests these days. And you can leave off the Signed-off-by line, we don't use that in the system

[systemd-devel] [PATCH] sd-bus: use isempty() consistently

2015-07-19 Thread Namhyung Kim
Signed-off-by: Namhyung Kim --- src/libsystemd/sd-bus/bus-control.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libsystemd/sd-bus/bus-control.c b/src/libsystemd/sd-bus/bus-control.c index a38c5c5..80f4760 100644 --- a/src/libsystemd/sd-bus/bus-control.c +++ b/