Re: [systemd-devel] [PATCH] sd-dhcp6-client: support custom DUIDs

2014-10-02 Thread Tom Gundersen
Looks good, so applied. However, I added a couple more follow-up commits changing the API slightly and adding some sanity-checking for the provided values. Can you check if it still looks ok for you? Thanks! Tom On Fri, Sep 26, 2014 at 10:12 PM, Dan Williams d...@redhat.com wrote: The caller

[systemd-devel] [PATCH] sd-dhcp6-client: support custom DUIDs

2014-09-26 Thread Dan Williams
The caller may have an existing DUID that it wants to use, and may want to use some other DUID generation scheme than systemd's default DUID-EN. --- src/libsystemd-network/sd-dhcp6-client.c | 43 +++- src/systemd/sd-dhcp6-client.h| 2 ++ 2 files changed,

Re: [systemd-devel] [PATCH] sd-dhcp6-client: support custom DUIDs

2014-08-12 Thread Dan Williams
On Tue, 2014-08-12 at 01:12 +0200, Tom Gundersen wrote: On Wed, Aug 6, 2014 at 6:17 PM, Dan Williams d...@redhat.com wrote: The caller may have an existing DUID that it wants to use, and may want to use some other DUID generation scheme than systemd's default DUID-EN. I have no

Re: [systemd-devel] [PATCH] sd-dhcp6-client: support custom DUIDs

2014-08-11 Thread Tom Gundersen
On Wed, Aug 6, 2014 at 6:17 PM, Dan Williams d...@redhat.com wrote: The caller may have an existing DUID that it wants to use, and may want to use some other DUID generation scheme than systemd's default DUID-EN. I have no objections a priori to this patch. But what is the use case? Is there

[systemd-devel] [PATCH] sd-dhcp6-client: support custom DUIDs

2014-08-06 Thread Dan Williams
The caller may have an existing DUID that it wants to use, and may want to use some other DUID generation scheme than systemd's default DUID-EN. --- src/libsystemd-network/sd-dhcp6-client.c | 52 +++--- src/libsystemd-network/test-dhcp6-client.c | 4 +--