Re: [systemd-devel] [PATCH] sd-resolv: declare functions from .h public

2014-01-17 Thread Lennart Poettering
On Tue, 14.01.14 19:29, Tom Gundersen (t...@jklm.no) wrote: > > Hi Daniel, > > I guess we should only do this once we decide to export the API. I > guess we won't be doing that for a few releases (we'll use it > internally first to make sure it is the way we want it). > > Or are there any benef

Re: [systemd-devel] [PATCH] sd-resolv: declare functions from .h public

2014-01-14 Thread Daniel Buch
Hi, I'm perfectly fine if we skip this patch, and to my understanding there is no benefits and only corresponds to external linkage. 2014/1/14 Tom Gundersen > Hi Daniel, > > I guess we should only do this once we decide to export the API. I > guess we won't be doing that for a few releases (we

Re: [systemd-devel] [PATCH] sd-resolv: declare functions from .h public

2014-01-14 Thread Tom Gundersen
Hi Daniel, I guess we should only do this once we decide to export the API. I guess we won't be doing that for a few releases (we'll use it internally first to make sure it is the way we want it). Or are there any benefits to these annotations even when the symbols are not exported? -t On Tue,

[systemd-devel] [PATCH] sd-resolv: declare functions from .h public

2014-01-14 Thread Daniel Buch
--- src/libsystemd/sd-resolv.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/libsystemd/sd-resolv.c b/src/libsystemd/sd-resolv.c index b8288ba..cd79a6c 100644 --- a/src/libsystemd/sd-resolv.c +++ b/src/libsystemd/sd-resolv.c @@ -41