Re: [systemd-devel] [PATCH] sd-rtnl: use correct function convention

2014-02-20 Thread Tom Gundersen
Hi Jason, On Thu, Feb 20, 2014 at 2:57 AM, Jason A. Donenfeld wrote: > -r = sd_rtnl_call(rtnl, message, 0, NULL); > +r = sd_rtnl_call(rtnl, NULL, message, 0); So this is not 'really' a constructor, so the new convention doesn't apply. The most important thing to me is that we kee

[systemd-devel] [PATCH] sd-rtnl: use correct function convention

2014-02-19 Thread Jason A. Donenfeld
Ret values come second. --- src/libsystemd/sd-rtnl/rtnl-util.c | 4 ++-- src/libsystemd/sd-rtnl/sd-rtnl.c | 4 ++-- src/libsystemd/sd-rtnl/test-rtnl.c | 8 src/nspawn/nspawn.c| 6 +++--- src/systemd/sd-rtnl.h | 4 ++-- 5 files changed, 13 insertions(+), 13 d