Re: [systemd-devel] [PATCH] shared/install: avoid prematurely rejecting "missing" units

2014-10-31 Thread Dave Reisner
On Fri, Oct 31, 2014 at 04:04:53AM +0100, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Oct 30, 2014 at 08:28:14PM -0400, Dave Reisner wrote: > > f7101b7368df copied some logic to prevent enabling masked units, but > > also added a check which causes attempts to enable templated units to > > fail. S

Re: [systemd-devel] [PATCH] shared/install: avoid prematurely rejecting "missing" units

2014-10-30 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 30, 2014 at 08:28:14PM -0400, Dave Reisner wrote: > f7101b7368df copied some logic to prevent enabling masked units, but > also added a check which causes attempts to enable templated units to > fail. Since we know the logic beyond this check will properly handle > units which truly do

[systemd-devel] [PATCH] shared/install: avoid prematurely rejecting "missing" units

2014-10-30 Thread Dave Reisner
f7101b7368df copied some logic to prevent enabling masked units, but also added a check which causes attempts to enable templated units to fail. Since we know the logic beyond this check will properly handle units which truly do not exist, we can rely on the unit file state comparison to suffice fo