Hi
On Mon, Oct 20, 2014 at 10:06 PM, Boris Egorov wrote:
> Oh, you are right. This should probably be left as is.
>
It should be reported to cppcheck
http://sourceforge.net/p/cppcheck/wiki/Home/
Preferably with a small test case. Ignoring false positives makes it
harder to figure out when th
On 10/21/2014 02:29 AM, Lennart Poettering wrote:
---
src/shared/macro.h | 2 +-
src/shared/ring.c | 7 ---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/shared/macro.h b/src/shared/macro.h
index 9ee332c..372475b 100644
--- a/src/shared/macro.h
+++ b/src/shared/mac
On Tue, 14.10.14 21:50, Boris Egorov (ego...@linux.com) wrote:
> Minor patch. Fixes defects found by cppcheck: do not check if unsigned
> value is const, reduce scope of a few variables.
>
> Signed-off-by: Boris Egorov
Hmm, semi-enthusiastic about this patch, see below.
> ---
> src/shared/mac
Minor patch. Fixes defects found by cppcheck: do not check if unsigned
value is const, reduce scope of a few variables.
Signed-off-by: Boris Egorov
---
src/shared/macro.h | 2 +-
src/shared/ring.c | 7 ---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/shared/macro.h b/s
