Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-10-24 Thread Karel Zak
On Fri, Oct 03, 2014 at 07:16:55AM +0200, Jan Synacek wrote: > Karel Zak writes: > >> Karel, any chance you can add a "-o" option to swapon? > > > > No problem, added to TODO. I'll implement it next week. Implemented, it's in util-linux git tree, will be in v2.26. > Would you please let me know

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-10-21 Thread Jan Synacek
Lennart Poettering writes: > On Mon, 20.10.14 11:08, Karel Zak (k...@redhat.com) wrote: > >> On Fri, Oct 03, 2014 at 07:16:55AM +0200, Jan Synacek wrote: >> > Karel Zak writes: >> > >> Karel, any chance you can add a "-o" option to swapon? >> > > >> > > No problem, added to TODO. I'll implement

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-10-20 Thread Lennart Poettering
On Mon, 20.10.14 11:08, Karel Zak (k...@redhat.com) wrote: > On Fri, Oct 03, 2014 at 07:16:55AM +0200, Jan Synacek wrote: > > Karel Zak writes: > > >> Karel, any chance you can add a "-o" option to swapon? > > > > > > No problem, added to TODO. I'll implement it next week. > > Implemented, it's

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-10-02 Thread Jan Synacek
Karel Zak writes: > On Thu, Oct 02, 2014 at 03:32:54PM +0200, Lennart Poettering wrote: >> On Thu, 25.09.14 09:54, Jan Synacek (jsyna...@redhat.com) wrote: >> >> > Zbigniew Jędrzejewski-Szmek writes: >> > > On Wed, Sep 24, 2014 at 02:29:05PM +0200, Jan Synacek wrote: >> > >> Process possible "di

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-10-02 Thread Karel Zak
On Thu, Oct 02, 2014 at 03:32:54PM +0200, Lennart Poettering wrote: > On Thu, 25.09.14 09:54, Jan Synacek (jsyna...@redhat.com) wrote: > > > Zbigniew Jędrzejewski-Szmek writes: > > > On Wed, Sep 24, 2014 at 02:29:05PM +0200, Jan Synacek wrote: > > >> Process possible "discard" values from /etc/fs

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-10-02 Thread Lennart Poettering
On Thu, 25.09.14 09:54, Jan Synacek (jsyna...@redhat.com) wrote: > Zbigniew Jędrzejewski-Szmek writes: > > On Wed, Sep 24, 2014 at 02:29:05PM +0200, Jan Synacek wrote: > >> Process possible "discard" values from /etc/fstab. > > Hm, wouldn't it be enough to simply pass through the options like wit

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-10-01 Thread Karel Zak
On Mon, Sep 29, 2014 at 06:52:12PM +0200, Zbigniew Jędrzejewski-Szmek wrote: > On Mon, Sep 29, 2014 at 08:35:04PM +0400, Andrei Borzenkov wrote: > > В Mon, 29 Sep 2014 17:16:25 +0200 > > Zbigniew Jędrzejewski-Szmek пишет: > > > > > > > > The problem with reading but back discards settings remain

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-29 Thread Jan Synacek
Zbigniew Jędrzejewski-Szmek writes: > I pushed your patch with some significant changes, and some follow-up > cleanups. Please check that things work for you. > > The problem with reading but back discards settings remains. > > Zbyszek It works for me, thanks! -- Jan Synacek Software Engineer,

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-29 Thread Jan Synacek
Zbigniew Jędrzejewski-Szmek writes: > On Mon, Sep 29, 2014 at 01:23:30PM +0200, Jan Synacek wrote: >> Ping, could anybody comment, please? > C'mon, it's been four days, two of that being the weekend. Sorry for that, it felt like way over a week already... -- Jan Synacek Software Engineer, Red H

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-29 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Sep 29, 2014 at 08:35:04PM +0400, Andrei Borzenkov wrote: > В Mon, 29 Sep 2014 17:16:25 +0200 > Zbigniew Jędrzejewski-Szmek пишет: > > > > > The problem with reading but back discards settings remains. > > > > Seems like the most natural solution is to extend /proc/swaps. The only > pl

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-29 Thread Andrei Borzenkov
В Mon, 29 Sep 2014 17:16:25 +0200 Zbigniew Jędrzejewski-Szmek пишет: > > The problem with reading but back discards settings remains. > Seems like the most natural solution is to extend /proc/swaps. The only place where these flags are printed right now is in dmesg during swapon. _

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-29 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Sep 29, 2014 at 02:41:28PM +0200, Zbigniew Jędrzejewski-Szmek wrote: > On Mon, Sep 29, 2014 at 01:23:30PM +0200, Jan Synacek wrote: > > Jan Synacek writes: > > > Zbigniew Jędrzejewski-Szmek writes: > > >> On Wed, Sep 24, 2014 at 02:29:05PM +0200, Jan Synacek wrote: > > >>> Process possibl

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-29 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Sep 29, 2014 at 01:23:30PM +0200, Jan Synacek wrote: > Jan Synacek writes: > > Zbigniew Jędrzejewski-Szmek writes: > >> On Wed, Sep 24, 2014 at 02:29:05PM +0200, Jan Synacek wrote: > >>> Process possible "discard" values from /etc/fstab. > >> Hm, wouldn't it be enough to simply pass throu

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-29 Thread Jan Synacek
Jan Synacek writes: > Zbigniew Jędrzejewski-Szmek writes: >> On Wed, Sep 24, 2014 at 02:29:05PM +0200, Jan Synacek wrote: >>> Process possible "discard" values from /etc/fstab. >> Hm, wouldn't it be enough to simply pass through the options like with >> mounts, using the Options= option? This mig

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-25 Thread Jan Synacek
Zbigniew Jędrzejewski-Szmek writes: > On Wed, Sep 24, 2014 at 02:29:05PM +0200, Jan Synacek wrote: >> Process possible "discard" values from /etc/fstab. > Hm, wouldn't it be enough to simply pass through the options like with > mounts, using the Options= option? This might be less work and be more

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-09-24 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Sep 24, 2014 at 02:29:05PM +0200, Jan Synacek wrote: > Process possible "discard" values from /etc/fstab. Hm, wouldn't it be enough to simply pass through the options like with mounts, using the Options= option? This might be less work and be more flexible. Zbyszek > --- > man/systemd.sw

[systemd-devel] [PATCH] swap: introduce Discard property

2014-09-24 Thread Jan Synacek
Process possible "discard" values from /etc/fstab. --- man/systemd.swap.xml | 14 + src/core/execute.c| 25 src/core/execute.h| 1 + src/core/load-fragment-gperf.gperf.m4 | 1 + src/core/swap.c