Re: [systemd-devel] [PATCH] sysctl: don't replace dots with slashes in prefix

2014-09-18 Thread Jan Synacek
David Herrmann writes: > Hi > > On Mon, Sep 15, 2014 at 2:00 PM, Jan Synacek wrote: >> David Herrmann writes: >>> Your original patch is right, too. But I'm not sure which one to >>> prefer. Given that we export systemd-sysctl as rpm macro, I guess we >>> have to go with your patch. Otherwise, w

Re: [systemd-devel] [PATCH] sysctl: don't replace dots with slashes in prefix

2014-09-17 Thread David Herrmann
Hi On Mon, Sep 15, 2014 at 2:00 PM, Jan Synacek wrote: > David Herrmann writes: >> Your original patch is right, too. But I'm not sure which one to >> prefer. Given that we export systemd-sysctl as rpm macro, I guess we >> have to go with your patch. Otherwise, we'd break ABI. >> >> Thanks and s

Re: [systemd-devel] [PATCH] sysctl: don't replace dots with slashes in prefix

2014-09-15 Thread Jan Synacek
David Herrmann writes: > Hi > > On Mon, Sep 15, 2014 at 1:22 PM, Jan Synacek wrote: >> David Herrmann writes: >>> A path isn't necessarily a file-system path. With sysctl, we have to >>> ways to specify entries: >>> >>> 1) You can specify them via legacy sysctl(2) names. These names use >>> do

Re: [systemd-devel] [PATCH] sysctl: don't replace dots with slashes in prefix

2014-09-15 Thread David Herrmann
Hi On Mon, Sep 15, 2014 at 1:22 PM, Jan Synacek wrote: > David Herrmann writes: >> A path isn't necessarily a file-system path. With sysctl, we have to >> ways to specify entries: >> >> 1) You can specify them via legacy sysctl(2) names. These names use >> dots as separators >> >> 2) You can

Re: [systemd-devel] [PATCH] sysctl: don't replace dots with slashes in prefix

2014-09-15 Thread Jan Synacek
David Herrmann writes: > Hi > > On Mon, Sep 15, 2014 at 11:26 AM, Jan Synacek wrote: >> David Herrmann writes: >>> Hi >>> >>> On Mon, Sep 15, 2014 at 10:00 AM, Jan Synacek wrote: David Herrmann writes: > Nevertheless, the documentation should clearly state which input is > expecte

Re: [systemd-devel] [PATCH] sysctl: don't replace dots with slashes in prefix

2014-09-15 Thread David Herrmann
Hi On Mon, Sep 15, 2014 at 11:26 AM, Jan Synacek wrote: > David Herrmann writes: >> Hi >> >> On Mon, Sep 15, 2014 at 10:00 AM, Jan Synacek wrote: >>> David Herrmann writes: Nevertheless, the documentation should clearly state which input is expected and the current code is definitely

Re: [systemd-devel] [PATCH] sysctl: don't replace dots with slashes in prefix

2014-09-15 Thread Jan Synacek
David Herrmann writes: > Hi > > On Mon, Sep 15, 2014 at 10:00 AM, Jan Synacek wrote: >> David Herrmann writes: >>> Nevertheless, the documentation should clearly state which input is >>> expected and the current code is definitely wrong as it only performs >>> one way conversions. >> >> Could yo

Re: [systemd-devel] [PATCH] sysctl: don't replace dots with slashes in prefix

2014-09-15 Thread David Herrmann
Hi On Mon, Sep 15, 2014 at 10:00 AM, Jan Synacek wrote: > David Herrmann writes: >> Nevertheless, the documentation should clearly state which input is >> expected and the current code is definitely wrong as it only performs >> one way conversions. > > Could you please point me to the right docu

Re: [systemd-devel] [PATCH] sysctl: don't replace dots with slashes in prefix

2014-09-15 Thread Jan Synacek
David Herrmann writes: > Hi > > On Fri, Sep 12, 2014 at 11:21 AM, Jan Synacek wrote: >> The prefix is always tested against normalized property names. >> --- >> src/sysctl/sysctl.c | 6 -- >> 1 file changed, 6 deletions(-) >> >> diff --git a/src/sysctl/sysctl.c b/src/sysctl/sysctl.c >> index

Re: [systemd-devel] [PATCH] sysctl: don't replace dots with slashes in prefix

2014-09-13 Thread David Herrmann
Hi On Fri, Sep 12, 2014 at 11:21 AM, Jan Synacek wrote: > The prefix is always tested against normalized property names. > --- > src/sysctl/sysctl.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/src/sysctl/sysctl.c b/src/sysctl/sysctl.c > index 8ce9870..0cb0875 100644 > --- a/src

[systemd-devel] [PATCH] sysctl: don't replace dots with slashes in prefix

2014-09-12 Thread Jan Synacek
The prefix is always tested against normalized property names. --- src/sysctl/sysctl.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/sysctl/sysctl.c b/src/sysctl/sysctl.c index 8ce9870..0cb0875 100644 --- a/src/sysctl/sysctl.c +++ b/src/sysctl/sysctl.c @@ -256,12 +256,6 @@ static in