Re: [systemd-devel] [PATCH] systemd-notify: Always pass a valid pid to sd_pid_notify

2015-09-21 Thread Lennart Poettering
On Sat, 19.09.15 23:46, Benjamin Robin (d...@benjarobin.fr) wrote: > If the option --pid was used, take the pid from this option, unless take > the parend pid. Using 0 as pid (ucred of systemd-notify) will result 99% of > the > time in a failure with this error: "Cannot find unit for notify messa

Re: [systemd-devel] [PATCH] systemd-notify: Always pass a valid pid to sd_pid_notify

2015-09-19 Thread systemd github import bot
Patchset imported to github. To create a pull request, one of the main developers has to initiate one via: -- Generated by https://github.com/haraldh/mail2git __

[systemd-devel] [PATCH] systemd-notify: Always pass a valid pid to sd_pid_notify

2015-09-19 Thread Benjamin Robin
If the option --pid was used, take the pid from this option, unless take the parend pid. Using 0 as pid (ucred of systemd-notify) will result 99% of the time in a failure with this error: "Cannot find unit for notify message of PID" Shouldn't we use always the ppid, since the MAINPID is something

Re: [systemd-devel] [PATCH] systemd-notify: Always pass a valid pid to sd_pid_notify

2015-09-19 Thread systemd github import bot
Patchset imported to github. To create a pull request, one of the main developers has to initiate one via: -- Generated by https://github.com/haraldh/mail2git ___

[systemd-devel] [PATCH] systemd-notify: Always pass a valid pid to sd_pid_notify

2015-09-19 Thread Benjamin Robin
If the option --pid was used, take the pid from this option, unless take the parend pid. Using 0 as pid (ucred of systemd-notify) will result 99% of the time in a failure with this error: "Cannot find unit for notify message of PID" Shouldn't we use always the ppid, since the MAINPID is something