[systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-22 Thread Cristian Rodríguez
--- src/sysv-generator/sysv-generator.c | 8 1 file changed, 8 insertions(+) diff --git a/src/sysv-generator/sysv-generator.c b/src/sysv-generator/sysv-generator.c index b8b77aa..d6e4dfa 100644 --- a/src/sysv-generator/sysv-generator.c +++ b/src/sysv-generator/sysv-generator.c @@ -775,6

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-22 Thread Michael Biebl
2015-01-23 3:52 GMT+01:00 Cristian Rodríguez : > --- > src/sysv-generator/sysv-generator.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/sysv-generator/sysv-generator.c > b/src/sysv-generator/sysv-generator.c > index b8b77aa..d6e4dfa 100644 > --- a/src/sysv-generator/sysv-g

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Colin Guthrie
Michael Biebl wrote on 23/01/15 03:24: > and ship a > /lib/systemd/system/rc.local.service -> rc-local.service > symlink in the systemd package. Hmm, doesn't that break the /usr/lib/systemd/system-generators/systemd-rc-local-generator logic? Or do you not ship that in Debian? The whole point of t

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Michael Biebl
2015-01-23 10:17 GMT+01:00 Colin Guthrie : > Michael Biebl wrote on 23/01/15 03:24: >> and ship a >> /lib/systemd/system/rc.local.service -> rc-local.service >> symlink in the systemd package. > > Hmm, doesn't that break the > /usr/lib/systemd/system-generators/systemd-rc-local-generator logic? Or

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Lennart Poettering
On Thu, 22.01.15 23:52, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: > --- > src/sysv-generator/sysv-generator.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/sysv-generator/sysv-generator.c > b/src/sysv-generator/sysv-generator.c > index b8b77aa..d6e4dfa 100644 >

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Lennart Poettering
On Fri, 23.01.15 04:24, Michael Biebl (mbi...@gmail.com) wrote: > 2015-01-23 3:52 GMT+01:00 Cristian Rodríguez : > > --- > > src/sysv-generator/sysv-generator.c | 8 > > 1 file changed, 8 insertions(+) > > > > diff --git a/src/sysv-generator/sysv-generator.c > > b/src/sysv-generator/sys

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Martin Pitt
Michael Biebl [2015-01-23 13:27 +0100]: > - It avoids that a rc.local.service file is generated by the sysv-generator Not with upstream systemd, the sysv generator doesn't check if there's already a unit of that name (as it produces them in generator.late/). The Debian package has a patch for this

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Michael Biebl
2015-01-23 14:32 GMT+01:00 Lennart Poettering : > On Fri, 23.01.15 04:24, Michael Biebl (mbi...@gmail.com) wrote: > >> If distros still ship such a rc.local sysv init script, shouldn't they >> rather symlink that to >> the native rc-local.service? Sounds like the better alternative to me. >> Or alt

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Michael Biebl
2015-01-23 15:15 GMT+01:00 Martin Pitt : > Michael Biebl [2015-01-23 13:27 +0100]: >> - It avoids that a rc.local.service file is generated by the sysv-generator > > Not with upstream systemd, the sysv generator doesn't check if there's > already a unit of that name (as it produces them in generato

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Cristian Rodríguez
El 23/01/15 a las 10:31, Lennart Poettering escribió: The rc-local generator only exists to add compat support for those systems where it never was a sysvinit script anyway... They are not init scripts though. but plain shell scripts with no dependency information. they are installed in /etc

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Lennart Poettering
On Fri, 23.01.15 15:57, Michael Biebl (mbi...@gmail.com) wrote: > 2015-01-23 14:32 GMT+01:00 Lennart Poettering : > > On Fri, 23.01.15 04:24, Michael Biebl (mbi...@gmail.com) wrote: > > > >> If distros still ship such a rc.local sysv init script, shouldn't they > >> rather symlink that to > >> the

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Lennart Poettering
On Fri, 23.01.15 12:27, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: > El 23/01/15 a las 10:31, Lennart Poettering escribió: > > >The rc-local generator only exists to add compat support for those > >systems where it never was a sysvinit script anyway... > > > > They are not init scripts

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Simon McVittie
On 23/01/15 17:52, Lennart Poettering wrote: > On Fri, 23.01.15 12:27, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: >> El 23/01/15 a las 10:31, Lennart Poettering escribió: >>> The rc-local generator only exists to add compat support for those >>> systems where it never was a sysvinit scrip

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Cristian Rodríguez
El 23/01/15 a las 14:52, Lennart Poettering escribió: On Fri, 23.01.15 12:27, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: El 23/01/15 a las 10:31, Lennart Poettering escribió: The rc-local generator only exists to add compat support for those systems where it never was a sysvinit scr

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Michael Biebl
2015-01-23 18:51 GMT+01:00 Lennart Poettering : > I'd even remove rc-local.service from Debian. If this is a normal > sysvinit script, treat it as such, and let sysv-generator do its deed > on it. The /etc/init.d/rc.local init script does nothing else then run /etc/rc.local, in case this file is e

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Lennart Poettering
On Fri, 23.01.15 18:44, Simon McVittie (simon.mcvit...@collabora.co.uk) wrote: > On 23/01/15 17:52, Lennart Poettering wrote: > > On Fri, 23.01.15 12:27, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: > >> El 23/01/15 a las 10:31, Lennart Poettering escribió: > >>> The rc-local generator onl

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Lennart Poettering
On Fri, 23.01.15 15:51, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: > El 23/01/15 a las 14:52, Lennart Poettering escribió: > >On Fri, 23.01.15 12:27, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: > > > >>El 23/01/15 a las 10:31, Lennart Poettering escribió: > >> > >>>The rc-local