Re: [systemd-devel] [PATCH] sysv-generator: Handle .sh suffixes when translating Provides:

2015-01-28 Thread Lennart Poettering
On Wed, 28.01.15 14:25, Martin Pitt (martin.p...@ubuntu.com) wrote: Hello Lennart, Lennart Poettering [2015-01-28 14:19 +0100]: I really don't follow. Why do we need the add_alias() equality check now? I mean, if sysv_translate_facility() now detects if we translate facilities listed in

Re: [systemd-devel] [PATCH] sysv-generator: Handle .sh suffixes when translating Provides:

2015-01-28 Thread Martin Pitt
Hello Lennart, Lennart Poettering [2015-01-28 14:19 +0100]: I really don't follow. Why do we need the add_alias() equality check now? I mean, if sysv_translate_facility() now detects if we translate facilities listed in Provides: as pointing to the script itself, and handles .sh properly, why

Re: [systemd-devel] [PATCH] sysv-generator: Handle .sh suffixes when translating Provides:

2015-01-28 Thread Lennart Poettering
On Wed, 28.01.15 09:05, Martin Pitt (martin.p...@ubuntu.com) wrote: Hey Lennart, Lennart Poettering [2015-01-27 23:09 +0100]: Hmm, we already had code that checks this in place, didn#t we? We only previously had this .sh stripping in sysv_translate_name(), but that translates and init

Re: [systemd-devel] [PATCH] sysv-generator: Handle .sh suffixes when translating Provides:

2015-01-28 Thread Martin Pitt
Hey Lennart, Lennart Poettering [2015-01-27 23:09 +0100]: Hmm, we already had code that checks this in place, didn#t we? We only previously had this .sh stripping in sysv_translate_name(), but that translates and init script name like foo.sh to foo.service. But that's not what we need in

Re: [systemd-devel] [PATCH] sysv-generator: Handle .sh suffixes when translating Provides:

2015-01-27 Thread Lennart Poettering
On Tue, 20.01.15 17:44, Martin Pitt (martin.p...@ubuntu.com) wrote: Hey all, the recent fix for sysv-generator's Provides: handling [1] caused, or rather uncovered, another bug which now creates symlinks to itself foo.service - foo.service for any /etc/init.d/foo.sh. The generator would

Re: [systemd-devel] [PATCH] sysv-generator: Handle .sh suffixes when translating Provides:

2015-01-21 Thread Michael Biebl
2015-01-20 17:44 GMT+01:00 Martin Pitt martin.p...@ubuntu.com: Hey all, the recent fix for sysv-generator's Provides: handling [1] caused, or rather uncovered, another bug which now creates symlinks to itself foo.service - foo.service for any /etc/init.d/foo.sh. The generator would output

[systemd-devel] [PATCH] sysv-generator: Handle .sh suffixes when translating Provides:

2015-01-20 Thread Martin Pitt
Hey all, the recent fix for sysv-generator's Provides: handling [1] caused, or rather uncovered, another bug which now creates symlinks to itself foo.service - foo.service for any /etc/init.d/foo.sh. The generator would output an error message like Failed to create unit file