Re: [systemd-devel] [PATCH] watchdog: Don't require WDIOC_SETOPTIONS/WDIOS_ENABLECARD

2015-06-15 Thread Jean Delvare
Hi Lennart, Thanks for your quick reply. Le Monday 15 June 2015 à 18:16 +0200, Lennart Poettering a écrit : > On Mon, 15.06.15 18:14, Jean Delvare (jdelv...@suse.de) wrote: > > > Not all watchdog drivers implement WDIOC_SETOPTIONS. Drivers which do > > not implement it have their device always e

Re: [systemd-devel] [PATCH] watchdog: Don't require WDIOC_SETOPTIONS/WDIOS_ENABLECARD

2015-06-15 Thread Lennart Poettering
On Mon, 15.06.15 18:14, Jean Delvare (jdelv...@suse.de) wrote: > Not all watchdog drivers implement WDIOC_SETOPTIONS. Drivers which do > not implement it have their device always enabled. So it's fine to > report an error if WDIOS_DISABLECARD is passed and the ioctl is not > implemented, however f

[systemd-devel] [PATCH] watchdog: Don't require WDIOC_SETOPTIONS/WDIOS_ENABLECARD

2015-06-15 Thread Jean Delvare
Not all watchdog drivers implement WDIOC_SETOPTIONS. Drivers which do not implement it have their device always enabled. So it's fine to report an error if WDIOS_DISABLECARD is passed and the ioctl is not implemented, however failing when WDIOS_ENABLECARD is passed and the ioctl is not implemented