Re: [systemd-devel] [PATCH 1/2] smack-setup: extract rule writing into a separate function

2013-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Mar 15, 2013 at 06:15:12PM +, Chen, Nathaniel wrote: > > -Original Message- > > From: Zbigniew Jędrzejewski-Szmek [mailto:zbys...@in.waw.pl] > > Sent: Wednesday, March 13, 2013 8:40 PM > > To: Chen, Nathaniel > > Cc: systemd-devel@lists.freedesktop.org; Zbigniew Jędrzejewski-Szm

Re: [systemd-devel] [PATCH 1/2] smack-setup: extract rule writing into a separate function

2013-03-15 Thread Chen, Nathaniel
> -Original Message- > From: Zbigniew Jędrzejewski-Szmek [mailto:zbys...@in.waw.pl] > Sent: Wednesday, March 13, 2013 8:40 PM > To: Chen, Nathaniel > Cc: systemd-devel@lists.freedesktop.org; Zbigniew Jędrzejewski-Szmek > Subject: [PATCH 1/2] smack-setup: extract rule writing into a separate

[systemd-devel] [PATCH 1/2] smack-setup: extract rule writing into a separate function

2013-03-13 Thread Zbigniew Jędrzejewski-Szmek
Check all errors. Return the first error if looping. --- Hi Nathaniel, your patches duplicate the same code paths (within one function!). Also, if cipsco is not available, a warning would be printed, which we don't want. Can you check if the following two replacement patches work for you? Please m