Re: [systemd-devel] [PATCH 1/5] fsckd: Don't use strjoina on gettext() call

2015-03-16 Thread Tom Gundersen
Looks good. Pushed. Thanks. Tom On Wed, Mar 11, 2015 at 2:25 PM, Didier Roche didro...@ubuntu.com wrote: Le 11/03/2015 09:34, Didier Roche a écrit : Le 11/03/2015 09:29, Martin Pitt a écrit : Hello all, Didier Roche [2015-03-10 17:56 +0100]: --- a/src/fsckd/fsckd.c +++

Re: [systemd-devel] [PATCH 1/5] fsckd: Don't use strjoina on gettext() call

2015-03-12 Thread Lennart Poettering
On Tue, 10.03.15 11:32, Didier Roche (didro...@ubuntu.com) wrote: static int manager_send_plymouth_message(Manager *m, const char *message) { -const char *plymouth_cancel_message = NULL; +_cleanup_free_ const char *plymouth_cancel_message = NULL; int r;

Re: [systemd-devel] [PATCH 1/5] fsckd: Don't use strjoina on gettext() call

2015-03-11 Thread Didier Roche
Le 11/03/2015 09:29, Martin Pitt a écrit : Hello all, Didier Roche [2015-03-10 17:56 +0100]: --- a/src/fsckd/fsckd.c +++ b/src/fsckd/fsckd.c @@ -272,7 +272,7 @@ static int plymouth_send_message(int plymouth_fd, const char *message, bool upda } static int

Re: [systemd-devel] [PATCH 1/5] fsckd: Don't use strjoina on gettext() call

2015-03-11 Thread Martin Pitt
Hello all, Didier Roche [2015-03-10 17:56 +0100]: --- a/src/fsckd/fsckd.c +++ b/src/fsckd/fsckd.c @@ -272,7 +272,7 @@ static int plymouth_send_message(int plymouth_fd, const char *message, bool upda } static int manager_send_plymouth_message(Manager *m, const char *message) { -

[systemd-devel] [PATCH 1/5] fsckd: Don't use strjoina on gettext() call

2015-03-10 Thread Didier Roche
Le 09/03/2015 19:11, Lennart Poettering a écrit : So I fixed a number of issues, but there are some bits I am not really keen to fix, mostly because it's hard for me to test as I don't use a file system that still requires fsck... - /dev/console needs to be opened only on demand but not

Re: [systemd-devel] [PATCH 1/5] fsckd: Don't use strjoina on gettext() call

2015-03-10 Thread Didier Roche
Le 10/03/2015 11:36, Lennart Poettering a écrit : On Tue, 10.03.15 11:32, Didier Roche (didro...@ubuntu.com) wrote: static int manager_send_plymouth_message(Manager *m, const char *message) { -const char *plymouth_cancel_message = NULL; +_cleanup_free_ const char