Re: [systemd-devel] [PATCH 2/2] kernel-install: add compat with 'installkernel'

2013-10-01 Thread Tom Gundersen
On Tue, Oct 1, 2013 at 5:45 PM, Harald Hoyer wrote: > On 09/26/2013 12:38 AM, Tom Gundersen wrote: >> If 'kernel-install' is called as 'installkernel' it will be compatible with >> the >> syntax used by the kernel's build system. >> >> This means it can be called by doing 'make install' in a kern

Re: [systemd-devel] [PATCH 2/2] kernel-install: add compat with 'installkernel'

2013-10-01 Thread Harald Hoyer
On 09/26/2013 12:38 AM, Tom Gundersen wrote: > If 'kernel-install' is called as 'installkernel' it will be compatible with > the > syntax used by the kernel's build system. > > This means it can be called by doing 'make install' in a kernel build > directory, if the correct symlink has been insta

Re: [systemd-devel] [PATCH 2/2] kernel-install: add compat with 'installkernel'

2013-09-29 Thread Jan Engelhardt
On Sunday 2013-09-29 15:10, Dave Reisner wrote: >On Sep 29, 2013 6:40 AM, "Jan Engelhardt" wrote: >> On Thursday 2013-09-26 00:38, Tom Gundersen wrote: >> >> >+if [[ `basename $0` == 'installkernel' ]]; then >> >> Lack of quoting - bad bad bad. >> Why not just write ${0##*/} ? > >Quoting doesn't m

Re: [systemd-devel] [PATCH 2/2] kernel-install: add compat with 'installkernel'

2013-09-29 Thread Dave Reisner
On Sep 29, 2013 6:40 AM, "Jan Engelhardt" wrote: > > On Thursday 2013-09-26 00:38, Tom Gundersen wrote: > > >+if [[ `basename $0` == 'installkernel' ]]; then > > Lack of quoting - bad bad bad. > Why not just write ${0##*/} ? Quoting doesn't matter on the lhs here. Agree with the idiom in place of

Re: [systemd-devel] [PATCH 2/2] kernel-install: add compat with 'installkernel'

2013-09-29 Thread Jan Engelhardt
On Thursday 2013-09-26 00:38, Tom Gundersen wrote: >+if [[ `basename $0` == 'installkernel' ]]; then Lack of quoting - bad bad bad. Why not just write ${0##*/} ? ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop

[systemd-devel] [PATCH 2/2] kernel-install: add compat with 'installkernel'

2013-09-25 Thread Tom Gundersen
If 'kernel-install' is called as 'installkernel' it will be compatible with the syntax used by the kernel's build system. This means it can be called by doing 'make install' in a kernel build directory, if the correct symlink has been installed (which we don't do by default yet). --- src/kernel-i