On Sun, 26.04.15 21:04, Thomas H.P. Andersen (pho...@gmail.com) wrote:
> On Sun, Apr 26, 2015 at 8:31 PM, Thomas H.P. Andersen
> wrote:
> > On Sun, Apr 26, 2015 at 8:23 PM, Shawn Landden
> > wrote:
> >> Actually you missed that free_sysvstub_hashmap does not tolerate NULL
> >> pointers.
> > I
static void free_sysvstub_hashmapp(Hashmap **h) {
while ((stub = hashmap_steal_first(*h)))
_cleanup_ sends a pointer to the pointer. and then this dereferences
that, which is kinda confusing, but yeah the code is correct, it would
be clearer with DEFINE_TRIVIAL_CLEANUP_FUNC()
On Sun, Ap
On Sun, Apr 26, 2015 at 8:31 PM, Thomas H.P. Andersen wrote:
> On Sun, Apr 26, 2015 at 8:23 PM, Shawn Landden wrote:
>> Actually you missed that free_sysvstub_hashmap does not tolerate NULL
>> pointers.
> Indeed. I will commit that.
Wait. free_sysvstub_hashmapp does tolerate NULL pointers.
has
On Sun, Apr 26, 2015 at 8:23 PM, Shawn Landden wrote:
> Actually you missed that free_sysvstub_hashmap does not tolerate NULL
> pointers.
Indeed. I will commit that.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedes
Actually you missed that free_sysvstub_hashmap does not tolerate NULL pointers.
On Sun, Apr 26, 2015 at 11:21 AM, Shawn Landden wrote:
> On Sun, Apr 26, 2015 at 11:15 AM, Thomas H.P. Andersen
> wrote:
>> Hi Shawn,
>>
>> I fixed this a few hours ago. I also updated the status in coverity.
>> Is
On Sun, Apr 26, 2015 at 11:15 AM, Thomas H.P. Andersen wrote:
> Hi Shawn,
>
> I fixed this a few hours ago. I also updated the status in coverity.
> Is there something else I can do to avoid duplicated work?
I wasn't checking coverity, just reading the emails, so the duplicated
work in on my end.
Hi Shawn,
I fixed this a few hours ago. I also updated the status in coverity.
Is there something else I can do to avoid duplicated work?
On Sun, Apr 26, 2015 at 7:58 PM, Shawn Landden wrote:
> (coverity)
> ---
> src/sysv-generator/sysv-generator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 de
(coverity)
---
src/sysv-generator/sysv-generator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/sysv-generator/sysv-generator.c
b/src/sysv-generator/sysv-generator.c
index 5ecd750..714ce8f 100644
--- a/src/sysv-generator/sysv-generator.c
+++ b/src/sysv-generator/sysv-ge
