Re: [systemd-devel] [PATCH 4/4] Always use recvmsg with MSG_CMSG_CLOEXEC

2015-02-12 Thread Lennart Poettering
On Tue, 10.02.15 21:26, Lennart Poettering (lenn...@poettering.net) wrote: On Tue, 10.02.15 12:06, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: Well, all but two of these recvmsg() invocations apply to network sockets, which cannot receive fds, hence specifying the flag is kinda

[systemd-devel] [PATCH 4/4] Always use recvmsg with MSG_CMSG_CLOEXEC

2015-02-10 Thread Cristian Rodríguez
--- src/libsystemd-network/sd-dhcp-client.c | 2 +- src/libsystemd-network/sd-dhcp-server.c | 2 +- src/libsystemd/sd-rtnl/rtnl-message.c | 4 ++-- src/libudev/libudev-monitor.c | 2 +- src/machine/machine-dbus.c | 2 +- src/resolve/resolved-manager.c | 2 +-

Re: [systemd-devel] [PATCH 4/4] Always use recvmsg with MSG_CMSG_CLOEXEC

2015-02-10 Thread Lennart Poettering
On Tue, 10.02.15 12:06, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: Well, all but two of these recvmsg() invocations apply to network sockets, which cannot receive fds, hence specifying the flag is kinda pointless... For the other two cases we should probably close all fds we receive...