Re: [systemd-devel] [PATCH v3 01/26] dhcp: Add DHCP protocol structures and initial defines

2013-12-12 Thread Marcel Holtmann
Hi Patrik, >> I agree with Zbigniew: this should probably be in >> src/libsystemd-dhcp/, so that this is similar to libsystemd-bus/, >> libsystemd-id128/ and so on... > > Sent a patch for that, and in the process of creating an account on > freedesktop.org. As that will most probably take some ti

Re: [systemd-devel] [PATCH v3 01/26] dhcp: Add DHCP protocol structures and initial defines

2013-12-12 Thread Patrik Flykt
On Tue, 2013-12-10 at 18:48 +0100, Lennart Poettering wrote: > I agree with Zbigniew: this should probably be in > src/libsystemd-dhcp/, so that this is similar to libsystemd-bus/, > libsystemd-id128/ and so on... Sent a patch for that, and in the process of creating an account on freedesktop.org.

Re: [systemd-devel] [PATCH v3 01/26] dhcp: Add DHCP protocol structures and initial defines

2013-12-10 Thread Lennart Poettering
On Tue, 10.12.13 18:12, Marcel Holtmann (mar...@holtmann.org) wrote: > Hi Lennart, > > +uint32_t ciaddr; > +uint32_t yiaddr; > +uint32_t siaddr; > +uint32_t giaddr; > >>> > >>> Hmmm, why uin32_t? Shouldn't this be32_t? THis is network byte orde

Re: [systemd-devel] [PATCH v3 01/26] dhcp: Add DHCP protocol structures and initial defines

2013-12-10 Thread Marcel Holtmann
Hi Lennart, +uint32_t ciaddr; +uint32_t yiaddr; +uint32_t siaddr; +uint32_t giaddr; >>> >>> Hmmm, why uin32_t? Shouldn't this be32_t? THis is network byte order, >>> right? which is just synoymous to big endian... >>> >>> Or even, if you now us

Re: [systemd-devel] [PATCH v3 01/26] dhcp: Add DHCP protocol structures and initial defines

2013-12-10 Thread Lennart Poettering
On Tue, 10.12.13 14:15, Patrik Flykt (patrik.fl...@linux.intel.com) wrote: > > On Tue, 2013-12-10 at 02:46 +0100, Lennart Poettering wrote: > > > +uint32_t ciaddr; > > > +uint32_t yiaddr; > > > +uint32_t siaddr; > > > +uint32_t giaddr; > > > > Hmmm, why uin32_t? S

Re: [systemd-devel] [PATCH v3 01/26] dhcp: Add DHCP protocol structures and initial defines

2013-12-10 Thread Tom Gundersen
On 10 Dec 2013 17:45, "Patrik Flykt" wrote: > > On Tue, 2013-12-10 at 02:46 +0100, Lennart Poettering wrote: > > > +uint32_t ciaddr; > > > +uint32_t yiaddr; > > > +uint32_t siaddr; > > > +uint32_t giaddr; > > > > Hmmm, why uin32_t? Shouldn't this be32_t? THis is net

Re: [systemd-devel] [PATCH v3 01/26] dhcp: Add DHCP protocol structures and initial defines

2013-12-10 Thread Patrik Flykt
On Tue, 2013-12-10 at 02:46 +0100, Lennart Poettering wrote: > > +uint32_t ciaddr; > > +uint32_t yiaddr; > > +uint32_t siaddr; > > +uint32_t giaddr; > > Hmmm, why uin32_t? Shouldn't this be32_t? THis is network byte order, > right? which is just synoymous to big end

Re: [systemd-devel] [PATCH v3 01/26] dhcp: Add DHCP protocol structures and initial defines

2013-12-09 Thread Lennart Poettering
On Mon, 09.12.13 23:43, Patrik Flykt (patrik.fl...@linux.intel.com) wrote: > +struct DHCPMessage { > +uint8_t op; > +uint8_t htype; > +uint8_t hlen; > +uint8_t hops; > +be32_t xid; > +be16_t secs; > +be16_t flags; > +uint32_t ciaddr;

[systemd-devel] [PATCH v3 01/26] dhcp: Add DHCP protocol structures and initial defines

2013-12-09 Thread Patrik Flykt
Create a new directory to host DHCP components. --- src/dhcp/protocol.h | 104 +++ 1 file changed, 104 insertions(+) create mode 100644 src/dhcp/protocol.h diff --git a/src/dhcp/protocol.h b/src/dhcp/protocol.h new file mode 100644 index 000..