Re: [systemd-devel] [systemd-commits] src/shared TODO

2015-05-16 Thread Zbigniew Jędrzejewski-Szmek
On Fri, May 15, 2015 at 05:08:12PM +0200, Lennart Poettering wrote: > B1;3802;0cOn Sun, 10.05.15 10:18, Zbigniew Jędrzejewski-Szmek > (zbys...@kemper.freedesktop.org) wrote: > > > + > > +fflush(f); > > +if (ferror(f)) > > +return log_error_errno(errno, "Failed to w

Re: [systemd-devel] [systemd-commits] src/shared TODO

2015-05-15 Thread Lennart Poettering
B1;3802;0cOn Sun, 10.05.15 10:18, Zbigniew Jędrzejewski-Szmek (zbys...@kemper.freedesktop.org) wrote: > + > +fflush(f); > +if (ferror(f)) > +return log_error_errno(errno, "Failed to write unit file %s: > %m", unit); Small note: please use fflush_and_check() for c

Re: [systemd-devel] [systemd-commits] src/shared

2014-11-06 Thread Lennart Poettering
On Thu, 06.11.14 15:30, Lennart Poettering (lenn...@poettering.net) wrote: > On Thu, 06.11.14 06:28, Harald Hoyer (har...@kemper.freedesktop.org) wrote: > > > > > Not all switch roots are like base_filesystem_create() wants them > > to look like. They might even boot, if they are RO

Re: [systemd-devel] [systemd-commits] src/shared

2014-11-06 Thread Lennart Poettering
On Thu, 06.11.14 06:28, Harald Hoyer (har...@kemper.freedesktop.org) wrote: > > Not all switch roots are like base_filesystem_create() wants them > to look like. They might even boot, if they are RO and don't have the FS > layout. Just ignore the error and switch_root nevertheless

Re: [systemd-devel] [systemd-commits] src/shared

2014-10-20 Thread Daurnimator
On 20 October 2014 15:11, Lennart Poettering wrote: > On Wed, 15.10.14 01:58, Michal Sekletar (msekl...@kemper.freedesktop.org) > wrote: > > -mycon = context_str(bcon); > > +mycon = strdup(context_str(bcon)); > > This looks wrong! > > I meanm what is mycon? a string or a security_

Re: [systemd-devel] [systemd-commits] src/shared

2014-10-20 Thread Lennart Poettering
On Wed, 15.10.14 01:58, Michal Sekletar (msekl...@kemper.freedesktop.org) wrote: > src/shared/label.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > New commits: > commit 5e78424f4a27c07be50e246308035c877f204038 > Author: Michal Sekletar > Date: Mon Oct 13 15:25:09 2014 +020

Re: [systemd-devel] [systemd-commits] src/shared

2014-08-25 Thread Lennart Poettering
On Mon, 25.08.14 07:06, Lukas Nykryn (lnyk...@kemper.freedesktop.org) wrote: > src/shared/install.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > New commits: > commit 41a451cc2901a5deb985aea4cc8de204a22e5612 > Author: Lukas Nykryn > Date: Mon Aug 25 15:29:50 2014 +0200 > >

Re: [systemd-devel] [systemd-commits] src/shared

2014-02-14 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Feb 15, 2014 at 05:06:13AM +0100, Zbigniew Jędrzejewski-Szmek wrote: > On Fri, Feb 14, 2014 at 07:31:33PM -0800, Kay Sievers wrote: > > src/shared/util.c |2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > New commits: > > commit ecea04731c30e351c9eb3176d89af4a329ba784a >

Re: [systemd-devel] [systemd-commits] src/shared

2014-02-14 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 14, 2014 at 07:31:33PM -0800, Kay Sievers wrote: > src/shared/util.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > New commits: > commit ecea04731c30e351c9eb3176d89af4a329ba784a > Author: Kay Sievers > Date: Sat Feb 15 04:30:27 2014 +0100 > > util: fix mismatc

Re: [systemd-devel] [systemd-commits] src/shared

2013-03-01 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Mar 01, 2013 at 05:17:35AM -0800, Lennart Poettering wrote: > path-lookup: downgrade again the messages where we log for units > > This partially reverts 7ad94c716d6403233d04c4d37cb14df958c9b65d. > > After that commit commands such as "systemctl enable" and friends >