Re: [systemd-devel] PATCH: fix sparse warnings

2012-03-26 Thread Kok, Auke-jan H
On Mon, Mar 26, 2012 at 10:43 AM, Lennart Poettering wrote: > On Thu, 22.03.12 10:32, Kok, Auke-jan H (auke-jan.h@intel.com) wrote: > >> >> On Wed, Mar 21, 2012 at 5:21 PM, Lennart Poettering >> wrote: >> >> Here is a patch integrating your header (modified as wanted by Lennart) >> >> and the

Re: [systemd-devel] PATCH: fix sparse warnings

2012-03-26 Thread Lennart Poettering
On Thu, 22.03.12 10:32, Kok, Auke-jan H (auke-jan.h@intel.com) wrote: > > On Wed, Mar 21, 2012 at 5:21 PM, Lennart Poettering > wrote: > >> Here is a patch integrating your header (modified as wanted by Lennart) > >> and the changes in various locations of journal to use le64_t. > >> > >> It

Re: [systemd-devel] PATCH: fix sparse warnings

2012-03-23 Thread Frederic Crozat
Le jeudi 22 mars 2012 à 10:32 -0700, Kok, Auke-jan H a écrit : > On Wed, Mar 21, 2012 at 5:21 PM, Lennart Poettering > wrote: > >> Here is a patch integrating your header (modified as wanted by Lennart) > >> and the changes in various locations of journal to use le64_t. > >> > >> It also fixes som

Re: [systemd-devel] PATCH: fix sparse warnings

2012-03-22 Thread Kok, Auke-jan H
On Wed, Mar 21, 2012 at 5:21 PM, Lennart Poettering wrote: >> Here is a patch integrating your header (modified as wanted by Lennart) >> and the changes in various locations of journal to use le64_t. >> >> It also fixes some potential endianness errors, please review it >> carefully. > > Looks goo

Re: [systemd-devel] PATCH: fix sparse warnings

2012-03-21 Thread Lennart Poettering
On Fri, 16.03.12 14:32, Frederic Crozat (fcro...@suse.com) wrote: > Le mercredi 14 mars 2012 à 11:36 -0700, Josh Triplett a écrit : > > On Wed, Mar 14, 2012 at 06:58:32PM +0100, Lennart Poettering wrote: > > > On Wed, 07.03.12 06:34, Josh Triplett (j...@joshtriplett.org) wrote: > > > > I've attach

Re: [systemd-devel] PATCH: fix sparse warnings

2012-03-19 Thread Frederic Crozat
Le vendredi 16 mars 2012 à 14:32 +0100, Frederic Crozat a écrit : > Le mercredi 14 mars 2012 à 11:36 -0700, Josh Triplett a écrit : > > On Wed, Mar 14, 2012 at 06:58:32PM +0100, Lennart Poettering wrote: > > > On Wed, 07.03.12 06:34, Josh Triplett (j...@joshtriplett.org) wrote: > > > > I've attache

Re: [systemd-devel] PATCH: fix sparse warnings

2012-03-16 Thread Frederic Crozat
Le mercredi 14 mars 2012 à 11:36 -0700, Josh Triplett a écrit : > On Wed, Mar 14, 2012 at 06:58:32PM +0100, Lennart Poettering wrote: > > On Wed, 07.03.12 06:34, Josh Triplett (j...@joshtriplett.org) wrote: > > > I've attached a header file which should provide all the endianness > > > checking you

Re: [systemd-devel] PATCH: fix sparse warnings

2012-03-14 Thread Josh Triplett
On Wed, Mar 14, 2012 at 06:58:32PM +0100, Lennart Poettering wrote: > On Wed, 07.03.12 06:34, Josh Triplett (j...@joshtriplett.org) wrote: > > I've attached a header file which should provide all the endianness > > checking you need. Just include it in place of endian.h everywhere you > > currentl

Re: [systemd-devel] PATCH: fix sparse warnings

2012-03-14 Thread Lennart Poettering
On Wed, 07.03.12 06:34, Josh Triplett (j...@joshtriplett.org) wrote: > I've attached a header file which should provide all the endianness > checking you need. Just include it in place of endian.h everywhere you > currently include endian.h. I stuck an all-permissive MIT license on > it, for max

Re: [systemd-devel] PATCH: fix sparse warnings

2012-03-07 Thread Frederic Crozat
Le mercredi 07 mars 2012 à 06:34 -0800, Josh Triplett a écrit : > On Mon, Mar 05, 2012 at 03:21:12PM +0100, Frederic Crozat wrote: > > Le lundi 05 mars 2012 ? 15:10 +0100, Lennart Poettering a ?crit : > > > I have little experience with sparse, but iirc it knows decorators for > > > variables for l

Re: [systemd-devel] PATCH: fix sparse warnings

2012-03-07 Thread Josh Triplett
On Mon, Mar 05, 2012 at 03:21:12PM +0100, Frederic Crozat wrote: > Le lundi 05 mars 2012 ? 15:10 +0100, Lennart Poettering a ?crit : > > I have little experience with sparse, but iirc it knows decorators for > > variables for le/be, right? Is this something we might want to use in > > the journal t

Re: [systemd-devel] PATCH: fix sparse warnings

2012-03-05 Thread Frederic Crozat
Le lundi 05 mars 2012 à 15:10 +0100, Lennart Poettering a écrit : > On Wed, 29.02.12 18:33, Frederic Crozat (fcro...@suse.com) wrote: > > > Le mercredi 29 février 2012 à 17:04 +, Frederic Crozat a écrit : > > > Hi, > > > > > > while trying to use sparse to detect potential endianness errors

Re: [systemd-devel] PATCH: fix sparse warnings

2012-03-05 Thread Lennart Poettering
On Wed, 29.02.12 18:33, Frederic Crozat (fcro...@suse.com) wrote: > Le mercredi 29 février 2012 à 17:04 +, Frederic Crozat a écrit : > > Hi, > > > > while trying to use sparse to detect potential endianness errors in > > journald code (apparently, we can't use it for that), I found some othe

Re: [systemd-devel] PATCH: fix sparse warnings

2012-02-29 Thread Frederic Crozat
Le mercredi 29 février 2012 à 17:04 +, Frederic Crozat a écrit : > Hi, > > while trying to use sparse to detect potential endianness errors in > journald code (apparently, we can't use it for that), I found some other > warnings with sparse. > > Attached patch fixes those (mostly missing sta

[systemd-devel] PATCH: fix sparse warnings

2012-02-29 Thread Frederic Crozat
Hi, while trying to use sparse to detect potential endianness errors in journald code (apparently, we can't use it for that), I found some other warnings with sparse. Attached patch fixes those (mostly missing static call, 0 vs NULL and macros redefinition). -- Frederic Crozat SUSE __