[systemd-devel] The enum udev_monitor_netlink_group contains bit masks

2013-03-12 Thread Andrey Wagin
Hello, According to netlink(7) nl_groups is a bit mask with every bit representing a netlink group number. I found that constants from udev_monitor_netlink_group are set directly to nl_groups. It's dangerous. Currently this enum contains only three constant and all is ok, but the next constant wi

Re: [systemd-devel] The enum udev_monitor_netlink_group contains bit masks

2013-03-12 Thread Kay Sievers
On Tue, Mar 12, 2013 at 9:35 PM, Andrey Wagin wrote: > According to netlink(7) nl_groups is a bit mask with every bit representing > a netlink group number. Netlink uses "numbers" not "a mask" since many years, we have just a 32bit number, not 32 groups today. The man page should really be update

Re: [systemd-devel] The enum udev_monitor_netlink_group contains bit masks

2013-03-12 Thread Andrey Wagin
2013/3/13 Kay Sievers > On Tue, Mar 12, 2013 at 9:35 PM, Andrey Wagin wrote: > > According to netlink(7) nl_groups is a bit mask with every bit > representing > > a netlink group number. > > Netlink uses "numbers" not "a mask" since many years, we have just a > 32bit number, not 32 groups today.

Re: [systemd-devel] The enum udev_monitor_netlink_group contains bit masks

2013-03-13 Thread Kay Sievers
On Wed, Mar 13, 2013 at 6:09 AM, Andrey Wagin wrote: > 2013/3/13 Kay Sievers >> >> On Tue, Mar 12, 2013 at 9:35 PM, Andrey Wagin wrote: >> > According to netlink(7) nl_groups is a bit mask with every bit >> > representing >> > a netlink group number. >> >> Netlink uses "numbers" not "a mask" sin