Re: [systemd-devel] compile with clang broken

2014-08-22 Thread David Herrmann
Hi On Sat, Aug 16, 2014 at 1:29 PM, Daniele Nicolodi wrote: > On 16/08/2014 12:35, David Herrmann wrote: >> On Fri, Aug 15, 2014 at 5:22 PM, Daniele Nicolodi wrote: >>> this may be completely stupid, but if the only use case you have for >>> CONST_MAX() is for computing the size of a data struct

Re: [systemd-devel] compile with clang broken

2014-08-19 Thread Dan McGee
On Sat, Aug 16, 2014 at 5:35 AM, David Herrmann wrote: > Hi > > On Fri, Aug 15, 2014 at 5:22 PM, Daniele Nicolodi > wrote: > > On 15/08/2014 16:30, David Herrmann wrote: > >> Ok, took me a while, but I now figured out how to cause compilation to > >> fail even in expressions that initialize type

Re: [systemd-devel] compile with clang broken

2014-08-18 Thread Lennart Poettering
On Sat, 16.08.14 13:29, Daniele Nicolodi (dani...@grinta.net) wrote: > > On 16/08/2014 12:35, David Herrmann wrote: > > On Fri, Aug 15, 2014 at 5:22 PM, Daniele Nicolodi > > wrote: > >> this may be completely stupid, but if the only use case you have for > >> CONST_MAX() is for computing the si

Re: [systemd-devel] compile with clang broken

2014-08-16 Thread Daniele Nicolodi
On 16/08/2014 12:35, David Herrmann wrote: > On Fri, Aug 15, 2014 at 5:22 PM, Daniele Nicolodi wrote: >> this may be completely stupid, but if the only use case you have for >> CONST_MAX() is for computing the size of a data structure, I find >> something like >> >> #define MAXSIZE(A, B) sizeof(un

Re: [systemd-devel] compile with clang broken

2014-08-16 Thread David Herrmann
Hi On Fri, Aug 15, 2014 at 5:22 PM, Daniele Nicolodi wrote: > On 15/08/2014 16:30, David Herrmann wrote: >> Ok, took me a while, but I now figured out how to cause compilation to >> fail even in expressions that initialize types (_Static_assert is not >> allowed there): >> #define assert_const(

Re: [systemd-devel] compile with clang broken

2014-08-15 Thread Lennart Poettering
On Fri, 15.08.14 17:22, Daniele Nicolodi (dani...@grinta.net) wrote: > > On 15/08/2014 16:30, David Herrmann wrote: > > Ok, took me a while, but I now figured out how to cause compilation to > > fail even in expressions that initialize types (_Static_assert is not > > allowed there): > > #defin

Re: [systemd-devel] compile with clang broken

2014-08-15 Thread Daniele Nicolodi
On 15/08/2014 16:30, David Herrmann wrote: > Ok, took me a while, but I now figured out how to cause compilation to > fail even in expressions that initialize types (_Static_assert is not > allowed there): > #define assert_const(expr) > ((void)(__builtin_types_compatible_p(int[(expr) ? 1 : -1], i

Re: [systemd-devel] compile with clang broken

2014-08-15 Thread David Herrmann
Hi On Fri, Jul 18, 2014 at 4:02 PM, Thomas H.P. Andersen wrote: > 1716f6dcf54d4c181c2e2558e3d5414f54c8d9ca (resolved: add LLMNR support > for looking up names) broke the build on clang. > > src/resolve/resolved-manager.c:553:43: error: non-const static data > member must be initialized out of lin

Re: [systemd-devel] compile with clang broken

2014-08-15 Thread David Herrmann
Hi On Fri, Aug 15, 2014 at 1:53 PM, Lennart Poettering wrote: > On Fri, 15.08.14 13:42, David Herrmann (dh.herrm...@gmail.com) wrote: > >> >> Hi >> >> On Fri, Aug 15, 2014 at 1:22 PM, Lennart Poettering >> wrote: >> > On Fri, 15.08.14 13:00, David Herrmann (dh.herrm...@gmail.com) wrote: >> > >>

Re: [systemd-devel] compile with clang broken

2014-08-15 Thread David Herrmann
Hi On Fri, Aug 15, 2014 at 1:53 PM, Lennart Poettering wrote: > On Fri, 15.08.14 13:42, David Herrmann (dh.herrm...@gmail.com) wrote: > >> >> Hi >> >> On Fri, Aug 15, 2014 at 1:22 PM, Lennart Poettering >> wrote: >> > On Fri, 15.08.14 13:00, David Herrmann (dh.herrm...@gmail.com) wrote: >> > >>

Re: [systemd-devel] compile with clang broken

2014-08-15 Thread Lennart Poettering
On Fri, 15.08.14 13:42, David Herrmann (dh.herrm...@gmail.com) wrote: > > Hi > > On Fri, Aug 15, 2014 at 1:22 PM, Lennart Poettering > wrote: > > On Fri, 15.08.14 13:00, David Herrmann (dh.herrm...@gmail.com) wrote: > > > >> > src/resolve/resolved-dns-stream.c:67:43: error: non-const static dat

Re: [systemd-devel] compile with clang broken

2014-08-15 Thread David Herrmann
Hi On Fri, Aug 15, 2014 at 1:22 PM, Lennart Poettering wrote: > On Fri, 15.08.14 13:00, David Herrmann (dh.herrm...@gmail.com) wrote: > >> > src/resolve/resolved-dns-stream.c:67:43: error: non-const static data >> > member must be initialized out of line >> > uint8_t buffer[CMSG_S

Re: [systemd-devel] compile with clang broken

2014-08-15 Thread Lennart Poettering
On Fri, 15.08.14 13:00, David Herrmann (dh.herrm...@gmail.com) wrote: > > src/resolve/resolved-dns-stream.c:67:43: error: non-const static data > > member must be initialized out of line > > uint8_t buffer[CMSG_SPACE(MAX(sizeof(struct > > in_pktinfo), sizeof(struct in6_pktinfo))) >

Re: [systemd-devel] compile with clang broken

2014-08-15 Thread David Herrmann
Hi On Fri, Aug 15, 2014 at 12:40 PM, Thomas H.P. Andersen wrote: > On Fri, Aug 15, 2014 at 12:35 PM, David Herrmann > wrote: >> Hi >> >> On Fri, Aug 15, 2014 at 12:29 PM, Thomas H.P. Andersen >> wrote: >>> On Fri, Aug 15, 2014 at 11:49 AM, David Herrmann >>> wrote: Thanks for trying! >

Re: [systemd-devel] compile with clang broken

2014-08-15 Thread Lennart Poettering
On Fri, 15.08.14 12:40, Thomas H.P. Andersen (pho...@gmail.com) wrote: > > On Fri, Aug 15, 2014 at 12:35 PM, David Herrmann > wrote: > > Hi > > > > On Fri, Aug 15, 2014 at 12:29 PM, Thomas H.P. Andersen > > wrote: > >> On Fri, Aug 15, 2014 at 11:49 AM, David Herrmann > >> wrote: > >>> Thank

Re: [systemd-devel] compile with clang broken

2014-08-15 Thread Thomas H.P. Andersen
On Fri, Aug 15, 2014 at 12:35 PM, David Herrmann wrote: > Hi > > On Fri, Aug 15, 2014 at 12:29 PM, Thomas H.P. Andersen > wrote: >> On Fri, Aug 15, 2014 at 11:49 AM, David Herrmann >> wrote: >>> Thanks for trying! >>> >>> Result is as I expected. Evaluation takes place _after_ validating >>> c

Re: [systemd-devel] compile with clang broken

2014-08-15 Thread David Herrmann
Hi On Fri, Aug 15, 2014 at 12:29 PM, Thomas H.P. Andersen wrote: > On Fri, Aug 15, 2014 at 11:49 AM, David Herrmann > wrote: >> Thanks for trying! >> >> Result is as I expected. Evaluation takes place _after_ validating >> compile-time constants, and thus __builtin_constant_p in combination >>

Re: [systemd-devel] compile with clang broken

2014-08-15 Thread Lennart Poettering
On Fri, 15.08.14 11:49, David Herrmann (dh.herrm...@gmail.com) wrote: > If that still doesn't work, I guess we're left with your proposed > solution below, or we add MAX_CONST() which just does (A > B)?A:B. We could also just define MAX() differently if we detect we run on LLVM. There must be som

Re: [systemd-devel] compile with clang broken

2014-08-15 Thread Djalal Harouni
On Fri, Aug 15, 2014 at 10:55:57AM +0200, David Herrmann wrote: > Hi > > On Thu, Aug 14, 2014 at 8:07 PM, Lennart Poettering > wrote: > > On Fri, 18.07.14 16:02, Thomas H.P. Andersen (pho...@gmail.com) wrote: > > > >> 1716f6dcf54d4c181c2e2558e3d5414f54c8d9ca (resolved: add LLMNR support > >> for

Re: [systemd-devel] compile with clang broken

2014-08-15 Thread David Herrmann
Hi On Fri, Aug 15, 2014 at 11:38 AM, Lennart Poettering wrote: > On Fri, 15.08.14 10:55, David Herrmann (dh.herrm...@gmail.com) wrote: > >> Hm, I don't know whether that works. See the description here: >> https://gcc.gnu.org/onlinedocs/gcc-4.3.3/gcc/Other-Builtins.html >> >> What you propose

Re: [systemd-devel] compile with clang broken

2014-08-15 Thread David Herrmann
Hi On Fri, Aug 15, 2014 at 11:35 AM, Thomas H.P. Andersen wrote: > On Fri, Aug 15, 2014 at 10:55 AM, David Herrmann > wrote: >> Hi >> >> On Thu, Aug 14, 2014 at 8:07 PM, Lennart Poettering >> wrote: >>> On Fri, 18.07.14 16:02, Thomas H.P. Andersen (pho...@gmail.com) wrote: >>> 1716f6dcf54

Re: [systemd-devel] compile with clang broken

2014-08-15 Thread Lennart Poettering
On Fri, 15.08.14 10:55, David Herrmann (dh.herrm...@gmail.com) wrote: > Hm, I don't know whether that works. See the description here: > https://gcc.gnu.org/onlinedocs/gcc-4.3.3/gcc/Other-Builtins.html > > What you propose is something like my attached patch, I guess? Along > the lines of: >

Re: [systemd-devel] compile with clang broken

2014-08-15 Thread Thomas H.P. Andersen
On Fri, Aug 15, 2014 at 10:55 AM, David Herrmann wrote: > Hi > > On Thu, Aug 14, 2014 at 8:07 PM, Lennart Poettering > wrote: >> On Fri, 18.07.14 16:02, Thomas H.P. Andersen (pho...@gmail.com) wrote: >> >>> 1716f6dcf54d4c181c2e2558e3d5414f54c8d9ca (resolved: add LLMNR support >>> for looking up n

Re: [systemd-devel] compile with clang broken

2014-08-15 Thread David Herrmann
Hi On Thu, Aug 14, 2014 at 8:07 PM, Lennart Poettering wrote: > On Fri, 18.07.14 16:02, Thomas H.P. Andersen (pho...@gmail.com) wrote: > >> 1716f6dcf54d4c181c2e2558e3d5414f54c8d9ca (resolved: add LLMNR support >> for looking up names) broke the build on clang. >> >> src/resolve/resolved-manager.c

Re: [systemd-devel] compile with clang broken

2014-08-14 Thread Lennart Poettering
On Fri, 18.07.14 16:02, Thomas H.P. Andersen (pho...@gmail.com) wrote: > 1716f6dcf54d4c181c2e2558e3d5414f54c8d9ca (resolved: add LLMNR support > for looking up names) broke the build on clang. > > src/resolve/resolved-manager.c:553:43: error: non-const static data > member must be initialized out

[systemd-devel] compile with clang broken

2014-07-18 Thread Thomas H.P. Andersen
1716f6dcf54d4c181c2e2558e3d5414f54c8d9ca (resolved: add LLMNR support for looking up names) broke the build on clang. src/resolve/resolved-manager.c:553:43: error: non-const static data member must be initialized out of line uint8_t buffer[CMSG_SPACE(MAX(sizeof(struct in_pktinfo), sizeof(struct in