[systemd-devel] possible bug guessing mainpid when service type=forking..

2011-06-20 Thread Marius Tolzmann
Hello.. Today we hit a bug where incorrect guessing of the MAINPID in a Type=forking service always killed the service somehow.. The service in question was ypbind from the ypbind-mt package from kernel.org/utils/NIS.. It forks two times to detach and provides the mainpid in /var/run/ypbind.pid

Re: [systemd-devel] possible bug guessing mainpid when service type=forking..

2011-06-20 Thread Lennart Poettering
On Mon, 20.06.11 19:34, Marius Tolzmann (tolzm...@molgen.mpg.de) wrote: > > We fixed this issue by patching ypbind-mt to run in foreground an let > systemd do the forking - as intended 8) > > But it still seems to be some kind of bug in setting the correct MAINPID > in Type=forking service files

Re: [systemd-devel] possible bug guessing mainpid when service type=forking..

2011-06-21 Thread Marius Tolzmann
hi.. On 06/20/11 21:36, Lennart Poettering wrote: > > This very much sounds as if the service does not wait in the top-level > process that the daemon process is properly forked and finished writing > the PID file. systemd tries to read the PID file immediately after the > top-level process exit

Re: [systemd-devel] possible bug guessing mainpid when service type=forking..

2011-06-21 Thread Lennart Poettering
On Tue, 21.06.11 18:50, Marius Tolzmann (tolzm...@molgen.mpg.de) wrote: > > but it should be doing: > > > >fork() > fork() --> write_pid_file() > >wait_for_notify()exit() notify_grandparent() > >exit() run_main_loop() > >