Re: [systemd-devel] systemd-213 fails to compile without kmod, no way to fix it using ./configure options

On Tue, Jun 3, 2014 at 12:57 AM, Samuli Suominen wrote: > > On 03/06/14 01:48, Tom Gundersen wrote: >> On Sun, Jun 1, 2014 at 2:58 PM, Michael Biebl wrote: >>> I quickly looked at the patch and it seems ok. >>> While glancing over Makefile.am I noticed that e.g. libsystemd_network >>> links again

Re: [systemd-devel] systemd-213 fails to compile without kmod, no way to fix it using ./configure options

On 03/06/14 01:48, Tom Gundersen wrote: > On Sun, Jun 1, 2014 at 2:58 PM, Michael Biebl wrote: >> I quickly looked at the patch and it seems ok. >> While glancing over Makefile.am I noticed that e.g. libsystemd_network >> links against $(KMOD_LIBS). >> That looks wrong to me (faulty commit is >>

Re: [systemd-devel] systemd-213 fails to compile without kmod, no way to fix it using ./configure options

On Sun, Jun 1, 2014 at 2:58 PM, Michael Biebl wrote: > I quickly looked at the patch and it seems ok. > While glancing over Makefile.am I noticed that e.g. libsystemd_network > links against $(KMOD_LIBS). > That looks wrong to me (faulty commit is > 679be2a74241a70028438217bace423a1a45faa6), only

Re: [systemd-devel] systemd-213 fails to compile without kmod, no way to fix it using ./configure options

Tom, I quickly looked at the patch and it seems ok. While glancing over Makefile.am I noticed that e.g. libsystemd_network links against $(KMOD_LIBS). That looks wrong to me (faulty commit is 679be2a74241a70028438217bace423a1a45faa6), only libsystemd-networkd-core really requires kmod 2014-06-0

Re: [systemd-devel] systemd-213 fails to compile without kmod, no way to fix it using ./configure options

On Sun, Jun 1, 2014 at 8:15 AM, Lennart Poettering wrote: > On Sun, 01.06.14 08:04, Tom Gundersen (t...@jklm.no) wrote: > >> On 1 Jun 2014 06:31, "Lennart Poettering" wrote: >> > >> > On Sat, 31.05.14 19:43, Samuli Suominen (ssuomi...@gentoo.org) wrote: >> > >> > > >> > > >> > > On 31/05/14 17:10

Re: [systemd-devel] systemd-213 fails to compile without kmod, no way to fix it using ./configure options

On Sun, Jun 1, 2014 at 8:15 AM, Samuli Suominen wrote: > > On 01/06/14 10:04, Tom Gundersen wrote: >> >> >> On 1 Jun 2014 06:31, "Lennart Poettering" > > wrote: >> > >> > On Sat, 31.05.14 19:43, Samuli Suominen (ssuomi...@gentoo.org >> )

Re: [systemd-devel] systemd-213 fails to compile without kmod, no way to fix it using ./configure options

On 01/06/14 10:04, Tom Gundersen wrote: > > > On 1 Jun 2014 06:31, "Lennart Poettering" > wrote: > > > > On Sat, 31.05.14 19:43, Samuli Suominen (ssuomi...@gentoo.org > ) wrote: > > > > > > > > > > > On 31/05/14 17:10, Samuli Suominen wr

Re: [systemd-devel] systemd-213 fails to compile without kmod, no way to fix it using ./configure options

On Sun, 01.06.14 08:04, Tom Gundersen (t...@jklm.no) wrote: > On 1 Jun 2014 06:31, "Lennart Poettering" wrote: > > > > On Sat, 31.05.14 19:43, Samuli Suominen (ssuomi...@gentoo.org) wrote: > > > > > > > > > > > On 31/05/14 17:10, Samuli Suominen wrote: > > > > On 31/05/14 14:14, Samuli Suominen w

Re: [systemd-devel] systemd-213 fails to compile without kmod, no way to fix it using ./configure options

On 1 Jun 2014 06:31, "Lennart Poettering" wrote: > > On Sat, 31.05.14 19:43, Samuli Suominen (ssuomi...@gentoo.org) wrote: > > > > > > > On 31/05/14 17:10, Samuli Suominen wrote: > > > On 31/05/14 14:14, Samuli Suominen wrote: > > >> 1. "libsystemd_network_la_SOURCES =" in Makefile.am includes > >

Re: [systemd-devel] systemd-213 fails to compile without kmod, no way to fix it using ./configure options

On Sat, 31.05.14 19:43, Samuli Suominen (ssuomi...@gentoo.org) wrote: > > > On 31/05/14 17:10, Samuli Suominen wrote: > > On 31/05/14 14:14, Samuli Suominen wrote: > >> 1. "libsystemd_network_la_SOURCES =" in Makefile.am includes > >> "src/libsystemd-network/network-internal.h" > >> and there is

Re: [systemd-devel] systemd-213 fails to compile without kmod, no way to fix it using ./configure options

On Sun, 01.06.14 06:23, Kay Sievers (k...@vrfy.org) wrote: > On Sat, May 31, 2014 at 7:45 PM, Cristian Rodríguez > wrote: > > El 31/05/14 13:00, Samuli Suominen escribió: > >> A proper git formatted patch for inclusion. > > > > IN my opinion, we should just make KMOD a mandatory dependency, drop

Re: [systemd-devel] systemd-213 fails to compile without kmod, no way to fix it using ./configure options

On Sat, May 31, 2014 at 7:45 PM, Cristian Rodríguez wrote: > El 31/05/14 13:00, Samuli Suominen escribió: >> A proper git formatted patch for inclusion. > > IN my opinion, we should just make KMOD a mandatory dependency, drop all > ifdefs, error out if not found. Sound fine to me, it really is a

Re: [systemd-devel] systemd-213 fails to compile without kmod, no way to fix it using ./configure options

On 31/05/14 20:45, Cristian Rodríguez wrote: > El 31/05/14 13:00, Samuli Suominen escribió: >> A proper git formatted patch for inclusion. > IN my opinion, we should just make KMOD a mandatory dependency, drop all > ifdefs, error out if not found. > > > I don't see why, people use CONFIG_MODULES=

Re: [systemd-devel] systemd-213 fails to compile without kmod, no way to fix it using ./configure options

El 31/05/14 13:00, Samuli Suominen escribió: > A proper git formatted patch for inclusion. IN my opinion, we should just make KMOD a mandatory dependency, drop all ifdefs, error out if not found. -- Cristian "I don't know the key to success, but the key to failure is trying to please everybody

Re: [systemd-devel] systemd-213 fails to compile without kmod, no way to fix it using ./configure options

A proper git formatted patch for inclusion. >From 9be13cce871d1d7275acee8bcb106cd2f9e909b7 Mon Sep 17 00:00:00 2001 From: Mike Gilbert Date: Sat, 31 May 2014 19:58:47 +0300 Subject: [PATCH] Fix building with --disable-kmod --disable-networkd when kmod is not installed. --- src/libsystemd-netwo

Re: [systemd-devel] systemd-213 fails to compile without kmod, no way to fix it using ./configure options

On 31/05/14 17:10, Samuli Suominen wrote: > On 31/05/14 14:14, Samuli Suominen wrote: >> 1. "libsystemd_network_la_SOURCES =" in Makefile.am includes >> "src/libsystemd-network/network-internal.h" >> and there is no anykind of #ifdef -logic behind it >> >> 2. "src/libsystemd-network/network-intern

Re: [systemd-devel] systemd-213 fails to compile without kmod, no way to fix it using ./configure options

On 31/05/14 14:14, Samuli Suominen wrote: > 1. "libsystemd_network_la_SOURCES =" in Makefile.am includes > "src/libsystemd-network/network-internal.h" > and there is no anykind of #ifdef -logic behind it > > 2. "src/libsystemd-network/network-internal.h" has #include > and there is no anykind of

[systemd-devel] systemd-213 fails to compile without kmod, no way to fix it using ./configure options

1. "libsystemd_network_la_SOURCES =" in Makefile.am includes "src/libsystemd-network/network-internal.h" and there is no anykind of #ifdef -logic behind it 2. "src/libsystemd-network/network-internal.h" has #include and there is no anykind of #ifdef -logic behind it so kmod is hardcoded dependen