Re: [systemd-devel] [PATCH] Fix a few compiler warnings

2014-05-23 Thread Tom Gundersen
On Fri, May 23, 2014 at 11:25 PM, Djalal Harouni wrote: > On Wed, May 21, 2014 at 10:46:21AM +0200, Lennart Poettering wrote: >> On Wed, 21.05.14 10:29, Thomas H.P. Andersen (pho...@gmail.com) wrote: >> >> > >> > On Tue, May 20, 2014 at 5:43 PM, Lennart Poettering >> > wrote: >> > > On Mon, 19.05

Re: [systemd-devel] [PATCH] Fix a few compiler warnings

2014-05-23 Thread Djalal Harouni
On Wed, May 21, 2014 at 10:46:21AM +0200, Lennart Poettering wrote: > On Wed, 21.05.14 10:29, Thomas H.P. Andersen (pho...@gmail.com) wrote: > > > > > On Tue, May 20, 2014 at 5:43 PM, Lennart Poettering > > wrote: > > > On Mon, 19.05.14 19:52, Tom Gundersen (t...@jklm.no) wrote: > > > > > >> >

Re: [systemd-devel] [PATCH] Fix a few compiler warnings

2014-05-21 Thread Thomas H.P. Andersen
On Wed, May 21, 2014 at 10:46 AM, Lennart Poettering wrote: > On Wed, 21.05.14 10:29, Thomas H.P. Andersen (pho...@gmail.com) wrote: > >> >> On Tue, May 20, 2014 at 5:43 PM, Lennart Poettering >> wrote: >> > On Mon, 19.05.14 19:52, Tom Gundersen (t...@jklm.no) wrote: >> > >> >> > _public_ int sd

Re: [systemd-devel] [PATCH] Fix a few compiler warnings

2014-05-21 Thread Lennart Poettering
On Wed, 21.05.14 10:29, Thomas H.P. Andersen (pho...@gmail.com) wrote: > > On Tue, May 20, 2014 at 5:43 PM, Lennart Poettering > wrote: > > On Mon, 19.05.14 19:52, Tom Gundersen (t...@jklm.no) wrote: > > > >> > _public_ int sd_peer_get_session(int fd, char **session) { > >> > -struct uc

Re: [systemd-devel] [PATCH] Fix a few compiler warnings

2014-05-21 Thread Thomas H.P. Andersen
On Tue, May 20, 2014 at 5:43 PM, Lennart Poettering wrote: > On Mon, 19.05.14 19:52, Tom Gundersen (t...@jklm.no) wrote: > >> > _public_ int sd_peer_get_session(int fd, char **session) { >> > -struct ucred ucred; >> > +struct ucred ucred = {}; >> >> I can't reproduce this warning,

Re: [systemd-devel] [PATCH] Fix a few compiler warnings

2014-05-20 Thread Lennart Poettering
On Mon, 19.05.14 19:52, Tom Gundersen (t...@jklm.no) wrote: > > _public_ int sd_peer_get_session(int fd, char **session) { > > -struct ucred ucred; > > +struct ucred ucred = {}; > > I can't reproduce this warning, but more importantly, why is this > necessary in this function and

Re: [systemd-devel] [PATCH] Fix a few compiler warnings

2014-05-19 Thread Djalal Harouni
On Mon, May 19, 2014 at 07:52:20PM +0200, Tom Gundersen wrote: > On Sun, May 18, 2014 at 10:30 PM, Cristian Rodríguez > wrote: > > --- > > src/journal/test-journal-stream.c | 2 +- > > src/libsystemd/sd-login/sd-login.c | 2 +- > > src/shared/util.c | 4 ++-- > > 3 files changed

Re: [systemd-devel] [PATCH] Fix a few compiler warnings

2014-05-19 Thread Thomas H.P. Andersen
On Mon, May 19, 2014 at 9:01 PM, Cristian Rodríguez wrote: > El 19/05/14 13:52, Tom Gundersen escribió: > >> I can't reproduce this warning, but more importantly, why is this >> necessary in this function and not the subsequent noes (which all >> seem to be more or less equivalent)? > > What compi

Re: [systemd-devel] [PATCH] Fix a few compiler warnings

2014-05-19 Thread Cristian Rodríguez
El 19/05/14 13:52, Tom Gundersen escribió: > I can't reproduce this warning, but more importantly, why is this > necessary in this function and not the subsequent noes (which all > seem to be more or less equivalent)? What compiler did you tried ? happens with GCC 4.9.0 r209782. -- Cristian

Re: [systemd-devel] [PATCH] Fix a few compiler warnings

2014-05-19 Thread Tom Gundersen
On Sun, May 18, 2014 at 10:30 PM, Cristian Rodríguez wrote: > --- > src/journal/test-journal-stream.c | 2 +- > src/libsystemd/sd-login/sd-login.c | 2 +- > src/shared/util.c | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/journal/test-journal-s