Re: [systemd-devel] rc-local.service ordering

2011-03-10 Thread Andrey Borzenkov
On Wed, Mar 2, 2011 at 12:35 AM, Lennart Poettering wrote: > On Wed, 02.03.11 00:07, Andrey Borzenkov (arvidj...@gmail.com) wrote: > >> Have you actually read what I wrote? >> >> "Now, I do not care much about rc-sysinit itself. But I do care that >> services that we want to be started late are *r

[systemd-devel] [PATCH] pam: do not leak file descriptor if flock fails

2011-03-10 Thread Andrey Borzenkov
If flock fails, fd is not returned to caller so it cannot clean up. --- src/pam-module.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/pam-module.c b/src/pam-module.c index 7f91584..e1a1a50 100644 --- a/src/pam-module.c +++ b/src/pam-module.c @@ -198,8 +198,1

Re: [systemd-devel] systemd-logger and external syslog daemon

2011-03-10 Thread Andrey Borzenkov
On Wed, Feb 23, 2011 at 10:48 AM, Mike Kazantsev wrote: > How the kmsg-syslogd->rsyslog migration (for systemd output) is supposed > to work? > As I just went through all of it ... you absolutely need rsyslog that supports passing sockets from systemd. Otherwise it is race condition - rsyslog w

[systemd-devel] [PATCH] man: trivial typo in systemd(1)

2011-03-10 Thread Andrey Borzenkov
--- man/systemd.xml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/man/systemd.xml b/man/systemd.xml index 2c42a02..6b1a4c9 100644 --- a/man/systemd.xml +++ b/man/systemd.xml @@ -269,7 +269,7 @@ syslog, sy

Re: [systemd-devel] systemd-logger and external syslog daemon

2011-03-10 Thread Mike Kazantsev
On Thu, 10 Mar 2011 19:14:29 +0300 Andrey Borzenkov wrote: > On Wed, Feb 23, 2011 at 10:48 AM, Mike Kazantsev wrote: > > > How the kmsg-syslogd->rsyslog migration (for systemd output) is supposed > > to work? > > > > As I just went through all of it ... > > you absolutely need rsyslog that su

Re: [systemd-devel] [PATCH] pam: do not leak file descriptor if flock fails

2011-03-10 Thread Lennart Poettering
On Thu, 10.03.11 17:39, Andrey Borzenkov (arvidj...@gmail.com) wrote: > If flock fails, fd is not returned to caller so it cannot clean up. Applied. Thanks! Lennart -- Lennart Poettering - Red Hat, Inc. ___ systemd-devel mailing list systemd-devel@li

Re: [systemd-devel] [PATCH] man: trivial typo in systemd(1)

2011-03-10 Thread Lennart Poettering
On Thu, 10.03.11 20:31, Andrey Borzenkov (arvidj...@gmail.com) wrote: Applied. Thanks! > --- > man/systemd.xml |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/man/systemd.xml b/man/systemd.xml > index 2c42a02..6b1a4c9 100644 > --- a/man/systemd.xml > +++ b/man/sys

Re: [systemd-devel] systemd-logger and external syslog daemon

2011-03-10 Thread Lennart Poettering
On Wed, 23.02.11 12:48, Mike Kazantsev (mk.frag...@gmail.com) wrote: > Good day, > > > I've recently deployed systemd on a machine that uses some syslog > monitoring software and the software went nuts because messages from > systemd logger were inconsistent with other logging - they all look >

Re: [systemd-devel] systemd-logger and external syslog daemon

2011-03-10 Thread Lennart Poettering
On Thu, 10.03.11 23:08, Mike Kazantsev (mk.frag...@gmail.com) wrote: > On Thu, 10 Mar 2011 19:14:29 +0300 > Andrey Borzenkov wrote: > > > On Wed, Feb 23, 2011 at 10:48 AM, Mike Kazantsev > > wrote: > > > > > How the kmsg-syslogd->rsyslog migration (for systemd output) is supposed > > > to wor

Re: [systemd-devel] [PATCH] Add Frugalware prefdm service

2011-03-10 Thread Lennart Poettering
On Wed, 09.03.11 01:04, Miklos Vajna (vmik...@frugalware.org) wrote: > Hi, > > The mandrive patches made this local patch fail to apply - which > reminded me to submit the attached patch. :) Hmm, prefdm is not supposed to be standardized name. It's something fedora and mandriva specific, and hen

Re: [systemd-devel] [PATCH] Add Frugalware prefdm service

2011-03-10 Thread Miklos Vajna
On Thu, Mar 10, 2011 at 10:29:47PM +0100, Lennart Poettering wrote: > Hmm, prefdm is not supposed to be standardized name. It's something > fedora and mandriva specific, and hence stored in the distro-specific > dirs. Exactly, that's why I added the service file in the corresponding subdir, so o

Re: [systemd-devel] [PATCH] Add Frugalware prefdm service

2011-03-10 Thread Lennart Poettering
On Thu, 10.03.11 23:04, Miklos Vajna (vmik...@frugalware.org) wrote: > +[Service] > +EnvironmentFile=/etc/sysconfig/desktop > +ExecStart=$desktop I don't think this works. You cannot use a variable for the binary path, due to some implications with SELinux. If you want to do it nonetheless use so

Re: [systemd-devel] [PATCH] Add Frugalware prefdm service

2011-03-10 Thread Miklos Vajna
On Fri, Mar 11, 2011 at 12:56:58AM +0100, Lennart Poettering wrote: > On Thu, 10.03.11 23:04, Miklos Vajna (vmik...@frugalware.org) wrote: > > > +[Service] > > +EnvironmentFile=/etc/sysconfig/desktop > > +ExecStart=$desktop > > I don't think this works. Don't worry, I tested it before submitti

Re: [systemd-devel] systemd-logger and external syslog daemon

2011-03-10 Thread Mike Kazantsev
On Thu, 10 Mar 2011 22:01:39 +0100 Lennart Poettering wrote: > On Wed, 23.02.11 12:48, Mike Kazantsev (mk.frag...@gmail.com) wrote: > > > Good day, > > > > > > I've recently deployed systemd on a machine that uses some syslog > > monitoring software and the software went nuts because messages

Re: [systemd-devel] [PACKAGERS] rsyslog and systemd

2011-03-10 Thread Mike Kazantsev
On Mon, 7 Mar 2011 23:49:45 +0100 Lennart Poettering wrote: > Heya, > > in the past weeks a couple of folks have been asking about the rsyslog > and systemd glue in systemd, and I never responded since this was still > work in progress. Things should be all resolved now, so here's a > heads-up i

Re: [systemd-devel] [PACKAGERS] rsyslog and systemd

2011-03-10 Thread Andrey Borzenkov
On Fri, Mar 11, 2011 at 7:15 AM, Mike Kazantsev wrote: > On Mon, 7 Mar 2011 23:49:45 +0100 > Lennart Poettering wrote: > >> Heya, >> >> in the past weeks a couple of folks have been asking about the rsyslog >> and systemd glue in systemd, and I never responded since this was still >> work in prog

Re: [systemd-devel] systemd-logger and external syslog daemon

2011-03-10 Thread Michael Biebl
2011/2/26 Andrey Borzenkov : > On Wed, Feb 23, 2011 at 10:48 AM, Mike Kazantsev wrote: >> >> I've recently deployed systemd on a machine that uses some syslog >> monitoring software and the software went nuts because messages from >> systemd logger were inconsistent with other logging - they all l

Re: [systemd-devel] systemd-logger and external syslog daemon

2011-03-10 Thread Michael Biebl
2011/3/11 Rainer Gerhards : >> -Original Message- >> From: Michael Biebl [mailto:mbi...@gmail.com] >> Sent: Friday, March 11, 2011 8:04 AM >> Mar 11 07:56:27 pluto kernel: [ 5921.140864] michael[25078]: baz >> >> As you can see, when rsyslog starts up and flushes the kmsg queue, the >> log

Re: [systemd-devel] systemd-logger and external syslog daemon

2011-03-10 Thread Andrey Borzenkov
On Fri, Mar 11, 2011 at 10:03 AM, Michael Biebl wrote: > For me the log messages actually look slightly different, as I also > get the kernel timestamp and I also noticed a different problem: > > Mar 11 07:56:27 pluto kernel: imklog 5.7.8, log source = /proc/kmsg started. > Mar 11 07:56:27 pluto r

Re: [systemd-devel] systemd-logger and external syslog daemon

2011-03-10 Thread Michael Biebl
2011/3/11 Rainer Gerhards : > > So isn't that already a solution? > The problem with PRINTK_TIME afaics is that it needs to be turned on explicitly whereas I'd expect SO_TIMESTAMP will be available always (if the kernel is recent enough)? In any case you'd need to interpret that data on the rsysl