[systemd-devel] [PATCH] __thread --> thread_local for C11 compat

2013-12-15 Thread Shawn Landden
also make thread_local available w/o including --- src/libsystemd-bus/sd-bus.c | 4 ++-- src/libsystemd-bus/sd-event.c | 2 +- src/libsystemd-id128/sd-id128.c | 8 src/login/logind-inhibit.c | 2 +- src/shared/capability.c | 4 ++-- src/shared/cgroup-util.c| 2

[systemd-devel] [PATCH] __thread --> thread_local for C11 compat

2013-12-15 Thread Shawn Landden
also make thread_local available w/o including --- src/libsystemd-bus/sd-bus.c | 4 ++-- src/libsystemd-bus/sd-event.c | 2 +- src/libsystemd-id128/sd-id128.c | 8 src/login/logind-inhibit.c | 2 +- src/shared/capability.c | 4 ++-- src/shared/cgroup-util.c

Re: [systemd-devel] [PATCH] __thread --> thread_local for C11 compat

2013-12-15 Thread Shawn Landden
On Sun, Dec 15, 2013 at 1:56 PM, Lennart Poettering wrote: > On Sun, 15.12.13 13:19, Shawn Landden (sh...@churchofgit.com) wrote: > >> also make thread_local available w/o including > > Hmm, that looks a bit too early, no? Does gcc even support this? glibc gcc-4.9 supports

Re: [systemd-devel] [PATCH] __thread --> thread_local for C11 compat

2013-12-15 Thread Shawn Landden
On Sun, Dec 15, 2013 at 3:16 PM, Lennart Poettering wrote: > On Sun, 15.12.13 14:56, Shawn Landden (sh...@churchofgit.com) wrote: > >> On Sun, Dec 15, 2013 at 1:56 PM, Lennart Poettering >> wrote: >> > On Sun, 15.12.13 13:19, Shawn Landden (sh...@churchofgit.com)

[systemd-devel] [PATCH] __thread --> thread_local for C11 compat

2013-12-15 Thread Shawn Landden
Also make thread_local available w/o including . (as the latter hasn't been implemented, but this part is trivial) --- src/libsystemd-bus/sd-bus.c | 4 ++-- src/libsystemd-bus/sd-event.c | 2 +- src/libsystemd-id128/sd-id128.c | 8 src/login/logind-inhibit.c | 2 +- src/sha

[systemd-devel] [PATCH 1/2] util: no need for in_initrd() cache to be thread-local

2013-12-15 Thread Shawn Landden
the process only has one working directory, and a race is harmless --- src/shared/util.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/shared/util.c b/src/shared/util.c index b5ffaa1..7c73074 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@ -2737,9 +2737,

[systemd-devel] [PATCH] _noreturn_ --> noreturn for C11 compat

2013-12-16 Thread Shawn Landden
also define noreturn w/o --- src/core/main.c | 2 +- src/journal/test-journal-interleaving.c | 2 +- src/shared/log.c| 4 ++-- src/shared/log.h| 4 ++-- src/shared/macro.h | 10 +- src/shared/

[systemd-devel] [PATCH] journal: fix assert against (theoretical) undefined behavior

2013-12-16 Thread Shawn Landden
While all the libc implementations I know return NULL when memchr's size parameter is 0: C11 7.24.1p2: Where an argument declared as "size_t n" specifies the length of the array for a function, n can have the value zero on a call to that function. Unless explicitly stated otherwise in the descript

Re: [systemd-devel] [PATCH] journal: fix assert against (theoretical) undefined behavior

2013-12-16 Thread Shawn Landden
On Mon, Dec 16, 2013 at 10:36 AM, Lennart Poettering wrote: > On Mon, 16.12.13 09:20, Shawn Landden (sh...@churchofgit.com) wrote: > >> While all the libc implementations I know return NULL when memchr's size >> parameter is 0: >> >> C11 7.24.1p2: Wher

Re: [systemd-devel] [PATCH] journal: fix assert against (theoretical) undefined behavior

2013-12-16 Thread Shawn Landden
On Mon, Dec 16, 2013 at 11:06 AM, Thomas H.P. Andersen wrote: > On Mon, Dec 16, 2013 at 7:50 PM, Shawn Landden wrote: >> On Mon, Dec 16, 2013 at 10:36 AM, Lennart Poettering >> wrote: >>> On Mon, 16.12.13 09:20, Shawn Landden (sh...@churchofgit.com) wrote: >

Re: [systemd-devel] [PATCH] journal: fix assert against (theoretical) undefined behavior

2013-12-16 Thread Shawn Landden
On Mon, Dec 16, 2013 at 12:19 PM, Thomas H.P. Andersen wrote: > On Mon, Dec 16, 2013 at 8:15 PM, Shawn Landden wrote: >> On Mon, Dec 16, 2013 at 11:06 AM, Thomas H.P. Andersen >> wrote: >>> On Mon, Dec 16, 2013 at 7:50 PM, Shawn Landden >>> wrote: >

[systemd-devel] [PATCH] journal: fix against (theoretical) undefined behavior

2013-12-16 Thread Shawn Landden
While all the libc implementations I know return NULL when memchr's size parameter is 0, without accessing any memory, passing NULL to memchr is still invalid: C11 7.24.1p2: Where an argument declared as "size_t n" specifies the length of the array for a function, n can have the value zero on a ca

Re: [systemd-devel] [PATCH] __thread --> thread_local for C11 compat

2013-12-17 Thread Shawn Landden
On Tue, Dec 17, 2013 at 12:46 PM, Lennart Poettering wrote: > On Sun, 15.12.13 16:19, Shawn Landden (sh...@churchofgit.com) wrote: > >> to actually use this we would have to add this patch: >> >> diff --git a/configure.ac b/configure.ac >> index f85e86e..5ead12

Re: [systemd-devel] [PATCH] core: support Distribute=n to distribute to n workers

2013-12-19 Thread Shawn Landden
ping? On Fri, Dec 13, 2013 at 8:23 PM, Shawn Landden wrote: > If Distribute=n, turns SO_REUSEPORT on, and spawns > n workers to handling incoming requests. > > SO_REUSEPORT sockets on the same port must all be created > by the same uid, therefore using the option allows > other

Re: [systemd-devel] [PATCH 00/11] *** SUBJECT HERE ***

2013-12-20 Thread Shawn Landden
On Fri, Dec 20, 2013 at 11:50 AM, Colin Walters wrote: > On Thu, 2013-12-19 at 14:20 +0100, Florian Weimer wrote: > >> readdir_r is rather broken on Linux because there are some directories >> it cannot read. > > Citation? Are you talking about > http://womble.decadent.org.uk/readdir_r-advisory.h

Re: [systemd-devel] systemd-nspawn and kernel command line

2013-12-20 Thread Shawn Landden
On Mon, Dec 9, 2013 at 9:23 AM, Colin Guthrie wrote: > 'Twas brillig, and Lennart Poettering at 08/12/13 23:48 did gyre and gimble: >> On Sat, 07.12.13 18:33, Colin Guthrie (gm...@colin.guthr.ie) wrote: >> >>> Hi, >>> >>> When playing with systemd-nspawn, is there a way to override the kernel >>>

Re: [systemd-devel] systemd-nspawn and kernel command line

2013-12-20 Thread Shawn Landden
On Fri, Dec 20, 2013 at 2:09 PM, Shawn Landden wrote: > On Mon, Dec 9, 2013 at 9:23 AM, Colin Guthrie wrote: >> 'Twas brillig, and Lennart Poettering at 08/12/13 23:48 did gyre and gimble: >>> On Sat, 07.12.13 18:33, Colin Guthrie (gm...@colin.guthr.ie) wrote: >>>

[systemd-devel] [PATCH] DEFAULT_PATH_SPLIT_USR macro

2013-12-20 Thread Shawn Landden
--- src/nspawn/nspawn.c| 2 +- src/shared/path-util.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/nspawn/nspawn.c b/src/nspawn/nspawn.c index a85579b..241b4b5 100644 --- a/src/nspawn/nspawn.c +++ b/src/nspawn/nspawn.c @@ -1243,7 +1243,7 @@ int main(int argc, ch

[systemd-devel] [PATCH] make: test-ellipsize is a manual test

2014-02-02 Thread Shawn Landden
--- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 8bef21b..dd4e2dc 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1124,6 +1124,7 @@ manual_tests += \ test-cgroup \ test-install \ test-watchdog \ + test-

[systemd-devel] [PATCH] manager: use CMSG macros

2014-02-02 Thread Shawn Landden
--- src/core/manager.c | 29 + 1 file changed, 21 insertions(+), 8 deletions(-) diff --git a/src/core/manager.c b/src/core/manager.c index 634b141..74fb52d 100644 --- a/src/core/manager.c +++ b/src/core/manager.c @@ -1275,9 +1275,10 @@ static int manager_dispatch_notif

Re: [systemd-devel] [PATCH] Use normal English elide in place of ellipsize

2014-02-04 Thread Shawn Landden
On Tue, Feb 4, 2014 at 8:15 AM, Colin Guthrie wrote: > 'Twas brillig, and Andrey Borzenkov at 04/02/14 15:36 did gyre and gimble: >> В Tue, 4 Feb 2014 15:31:58 + >> Barry Scott пишет: >> >>> Change the messages output and also all internal >>> function names and variables to match. >> >> As

Re: [systemd-devel] [PATCH 2/2] syscallfilter: port to libseccomp

2014-02-04 Thread Shawn Landden
of course > probably document it... > > Lennart > > -- > Lennart Poettering, Red Hat > ___ > systemd-devel mailing list > systemd-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/systemd-devel -- Shawn Landden +1 360 389 3001 (SMS preferred) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH 1/2] timedated: gather timezone from /etc/localtime sym target

2012-08-21 Thread Shawn Landden
/etc/localtime -> /usr/share/zoneinfo/... or /etc/localtime -> ../usr/share/zoneinfo/... (note, ../usr is not the same if /etc is a symlink, as this isn't using canonicalize_file_name()) keep other method for now, consider dropping later. Supporting relative links here are problematic as timez

[systemd-devel] [PATCH 2/2] man: remove timezone(5) and add localtime(5)

2012-08-21 Thread Shawn Landden
Developer +Lennart +Poettering +lenn...@poettering.net + + +Developer +

[systemd-devel] [PATCH v9002 1/2] timedated: gather timezone from /etc/localtime sym target

2012-08-21 Thread Shawn Landden
/etc/localtime -> /usr/share/zoneinfo/... or /etc/localtime -> ../usr/share/zoneinfo/... (note, ../usr is not the same if /etc is a symlink, as this isn't using canonicalize_file_name()) keep other method for now, consider dropping later. Supporting relative links here are problematic as timez

[systemd-devel] [PATCH v9002 2/2] man: remove timezone(5) and add localtime(5)

2012-08-21 Thread Shawn Landden
Developer +Lennart +Poettering +lenn...@poettering.net + + +Developer +

[systemd-devel] [PATCH] inhibit: ellipsize WHAT

2012-11-10 Thread Shawn Landden
--- src/login/inhibit.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/login/inhibit.c b/src/login/inhibit.c index 4735df7..b6962c9 100644 --- a/src/login/inhibit.c +++ b/src/login/inhibit.c @@ -110,7 +110,7 @@ static int print_inhibitors(DBusConnection *bus, DBus

[systemd-devel] [PATCH] timedated: do not incorrectly close non-opened dbus connection

2012-12-02 Thread Shawn Landden
Fix the fallowing error when no system dbus available: Failed to get system D-Bus connection: Failed to connect to socket /var/run/dbus/system_bus_socket: No such file or directory process 14920: arguments to dbus_connection_close() were incorrect, assertion "connection != NULL" failed in file .

[systemd-devel] [PATCH] shared: rename hasprefix() to startswith(), which is functionally identical and removed

2013-07-12 Thread Shawn Landden
as most (if not all) of the prefix strings are static, these will get forward constant propagation optimized into single memcmp() calls, which should be much better than the non-SIMD hand-rolled version. --- src/journal/journal-send.c | 2 +- src/journal/journald-native.c | 12 ++--

[systemd-devel] [PATCH v2] shared: rename hasprefix() to startswith(), which is functionally identical and removed

2013-07-12 Thread Shawn Landden
as most (if not all) of the prefix strings are static, these will get forward constant propagation optimized into single memcmp() calls, which should be much better than the non-SIMD hand-rolled version. --- TODO | 2 -- src/journal/journal-send.c | 2 +- src/journa

[systemd-devel] [PATCH] journalctl: have a useful --setup-keys error message when using non-persistant logging

2013-07-12 Thread Shawn Landden
Generating seed... Generating key pair... Generating sealing key... Failed to open /var/log/journal/33f46101703a10c5fc6fa4f451840101/fss.tmp.k2wDDU: No such file or directory --- src/journal/journalctl.c | 17 + 1 file changed, 17 insertions(+) diff --git a/src/journal/journalc

[systemd-devel] [PATCH 1/2] journalctl: add --force option to recreate FSS

2013-07-14 Thread Shawn Landden
reuse -f? --- src/journal/journalctl.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/src/journal/journalctl.c b/src/journal/journalctl.c index 32665b7..5f44fce 100644 --- a/src/journal/journalctl.c +++ b/src/journal/journalctl.c @@ -79,6 +79,7 @@ sta

[systemd-devel] [PATCH 2/2] journalctl: add permission check on /var/log/journal

2013-07-14 Thread Shawn Landden
--- src/journal/journalctl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/journal/journalctl.c b/src/journal/journalctl.c index 5f44fce..77a5fb1 100644 --- a/src/journal/journalctl.c +++ b/src/journal/journalctl.c @@ -748,6 +748,12 @@ static int setup_keys(void) {

[systemd-devel] [PATCH] journal: add logging of effective capabilities _CAP_EFFECTIVE

2013-07-14 Thread Shawn Landden
I think this is the most important of the capabilities bitmasks to log. --- TODO | 2 -- src/journal/journald-server.c | 7 +++ src/shared/util.c | 30 ++ src/shared/util.h | 1 + 4 files changed, 38 insertions(+),

[systemd-devel] [v2] journalctl: add --force option to recreate FSS

2013-07-14 Thread Shawn Landden
--- man/journalctl.xml | 8 src/journal/journalctl.c | 24 +--- 2 files changed, 29 insertions(+), 3 deletions(-) diff --git a/man/journalctl.xml b/man/journalctl.xml index 8dbfb3f..8c4ccd5 100644 --- a/man/journalctl.xml +++ b/man/journalctl.xml @@ -601,6 +601

[systemd-devel] [PATCH] journal: add logging of effective capabilities _CAP_EFFECTIVE

2013-07-14 Thread Shawn Landden
I think this is the most important of the capabilities bitmasks to log. --- TODO | 2 -- man/systemd.journal-fields.xml | 9 + src/journal/journald-server.c | 7 +++ src/shared/util.c | 31 +++ src/shared/util.h

[systemd-devel] [PATCH v3] journal: add logging of effective capabilities _CAP_EFFECTIVE

2013-07-15 Thread Shawn Landden
I think this is the most important of the capabilities bitmasks to log. --- TODO | 2 -- man/systemd.journal-fields.xml | 9 + src/journal/journald-server.c | 7 +++ src/shared/util.c | 28 src/shared/util.h

[systemd-devel] [PATCH v4] journal: add logging of effective capabilities _CAP_EFFECTIVE

2013-07-15 Thread Shawn Landden
I think this is the most important of the capabilities bitmasks to log. --- TODO | 2 -- man/systemd.journal-fields.xml | 9 + src/journal/journald-server.c | 7 +++ src/shared/util.c | 34 ++ src/shared/util.h

[systemd-devel] [PATCH] configure: add -Wno-cast-align to CFLAGS

2013-07-15 Thread Shawn Landden
these warnings on !x86 arches for good code are annoying, and there is no way to mark the offending code safe, so I guess we are just going to have to deal with the resulting problems as we come across them. Also, these warnings are present for armv6+armv7, when they moreso effect armv5. --- confi

[systemd-devel] [PATCH] shared: fix build on !x86

2013-07-20 Thread Shawn Landden
--- src/shared/virt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/shared/virt.c b/src/shared/virt.c index 1abd686..4f8134a 100644 --- a/src/shared/virt.c +++ b/src/shared/virt.c @@ -29,6 +29,8 @@ /* Returns a short identifier for the various VM implementations */

[systemd-devel] [PATCH] build: do not link everything with -lrt (and therefore -pthread)

2013-07-21 Thread Shawn Landden
--- Makefile.am | 1 + configure.ac | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 3ece887..f96866c 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1832,6 +1832,7 @@ libsystemd_daemon_internal_la_SOURCES = \ $(libsystemd_daemon_la_SO

[systemd-devel] [PATCH 1/1] nspawn: less cryptic error when clone() fails due to lack of adaquate namespace support in kernel

2012-02-23 Thread Shawn Landden
-by: Shawn Landden --- src/nspawn.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/nspawn.c b/src/nspawn.c index b8b379d..e70b658 100644 --- a/src/nspawn.c +++ b/src/nspawn.c @@ -707,7 +707,7 @@ int main(int argc, char *argv[]) { assert_se(sigprocmask

[systemd-devel] [PATCH] corrected machine-info(5) man page to be in line with source

2012-03-05 Thread Shawn Landden
change conflicting man/machine-info.xml documentation to match functionality in src/hostname/hostnamed.c 114-119 --- man/machine-info.xml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/man/machine-info.xml b/man/machine-info.xml index c6d3e92..240da25 100644 --- a/man/ma

[systemd-devel] [PATCH] nspawn: less cryptic error when clone() fails due to lack of adaquate namespace support in kernel

2012-03-05 Thread Shawn Landden
Running systemd-nspawn on a Linux kernel compiled without CONFIG_NAMESPACES=y CONFIG_UTS_NS=y CONFIG_IPC_NS=y CONFIG_PID_NS=y CONFIG_NET_NS=y fails with the cryptic error message clone() failed: Invalid argument Give user a more helpful error message when clone() fails --- src/nspa

[systemd-devel] [PATCH] login: tag the Mimo 720 ID_AUTOSEAT

2012-03-12 Thread Shawn Landden
This device is a combination USB hub, displaylink graphics, and e2i touchscreen Bus 001 Device 005: ID 058f:6254 Alcor Micro Corp. USB Hub Bus 001 Device 006: ID 17e9:401a Newnham Research Bus 001 Device 007: ID 1ac7:0001 |__ Port 1: Dev 5, If 0, Class=hub, Driver=hub/4p, 480M |__ Port 2: Dev

[systemd-devel] [PATCH] man: clarify _TRANSPORT

2012-05-03 Thread Shawn Landden
"resp." where it was confuses reader that stdout and stderr might go to differn't places Signed-off-by: Shawn Landden --- man/systemd.journal-fields.xml |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/man/systemd.journal-fields.xml b/man/systemd.jou

[systemd-devel] [PATCH] systemd-analyze: switch to python getopt for argument parsing

2012-05-03 Thread Shawn Landden
this uses gnu style getopt, so you can put the opts at the end: (e.g.) systemd-analyze blame --user --- src/analyze/systemd-analyze | 38 -- 1 file changed, 24 insertions(+), 14 deletions(-) diff --git a/src/analyze/systemd-analyze b/src/analyze/systemd-analy

[systemd-devel] [PATCH] systemd-analyze: switch to python getopt for argument parsing

2012-05-03 Thread Shawn Landden
this uses gnu style getopt, so you can put the opts at the end: (e.g.) systemd-analyze blame --user v2 --- src/analyze/systemd-analyze | 56 ++- 1 file changed, 39 insertions(+), 17 deletions(-) diff --git a/src/analyze/systemd-analyze b/src/analyze/syst

[systemd-devel] [PATCH] systemd-analyze: switch to python getopt for argument parsing

2012-05-14 Thread Shawn Landden
this uses gnu style getopt, so you can put the opts at the end: (e.g.) systemd-analyze blame --user v3 --- src/analyze/systemd-analyze | 282 --- 1 file changed, 155 insertions(+), 127 deletions(-) diff --git a/src/analyze/systemd-analyze b/src/analyze/sy

[systemd-devel] [PATCH] journal: fix dereferenced pointer in journal_file_rotate()

2012-05-21 Thread Shawn Landden
If journal_file_open() failed, due to (e.g.) -ENOSPC on open() new_file might still be NULL. On error, leave pointer to the old JournalFile (now closed), and require caller to check for error approiately. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=43020 Reported-by: Sjo

[systemd-devel] [PATCH] cgtop: useful error messages when bootup fails

2012-05-21 Thread Shawn Landden
cgtop quits on startup if all the cgroup mounts it expects are not ready. Provide user with some indication of why cgtop failed. --- src/cgtop/cgtop.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/src/cgtop/cgtop.c b/src/cgtop/cgtop.c index ddb5709..381f399 100644 --- a/src/cgtop/cg

[systemd-devel] [PATCH] cgtop: useful error messages when bootup fails

2012-05-21 Thread Shawn Landden
cgtop quits on startup if all the cgroup mounts it expects are not ready. Provide user with some indication of why cgtop failed. --- src/cgtop/cgtop.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/src/cgtop/cgtop.c b/src/cgtop/cgtop.c index ddb5709..744ddc3 100644 --- a/src/cgtop/cg

[systemd-devel] [PATCH] journalctl: support /usr/bin/nginx, etc

2012-05-30 Thread Shawn Landden
--- TODO |2 +- src/journal/journalctl.c | 26 +- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/TODO b/TODO index 3b3c451..f55a586 100644 --- a/TODO +++ b/TODO @@ -39,7 +39,7 @@ Features: - graphical sessions will show a dialog

[systemd-devel] [PATCH] analyze: Python 3 compatibility

2012-06-14 Thread Shawn Landden
Plot verb doesn't currently work b/c Cairo bug sending to stdout in python 3. --- src/analyze/systemd-analyze | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/analyze/systemd-analyze b/src/analyze/systemd-analyze index 5d451c3..76eceee 100755 --- a/src/ana

[systemd-devel] [PATCH] make mention initramfs-tools in addition to dracut

2012-06-22 Thread Shawn Landden
Should specific distributions be mentioned... aka.. foo (used by X and derivatives). bar (used by X and X and derivatives) --- man/kernel-command-line.xml |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/man/kernel-command-line.xml b/man/kernel-command-line.xml index 10

[systemd-devel] [PATCH] typo

2012-06-22 Thread Shawn Landden
--- man/kernel-command-line.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/kernel-command-line.xml b/man/kernel-command-line.xml index ec5ad3b..1ecc670 100644 --- a/man/kernel-command-line.xml +++ b/man/kernel-command-line.xml @@ -264,7 +264,7 @@

[systemd-devel] [PATCH] man: typo in systemd-analyze.xml

2012-06-26 Thread Shawn Landden
--- man/systemd-analyze.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/systemd-analyze.xml b/man/systemd-analyze.xml index 960ae7d..c2ff9cc 100644 --- a/man/systemd-analyze.xml +++ b/man/systemd-analyze.xml @@ -102,7 +102,7 @@

[systemd-devel] [PATCH] use #pragma once instead of foo*foo #define guards

2012-07-17 Thread Shawn Landden
#pragma once has been "un-deprecated" in gcc since 3.3, and is widely supported in other compilers. I've been using and maintaining (rebasing) this patch for a while now, as it annoyed me to see #ifndef fooblahfoo, etc all over the place, almost arrogant about the annoyance of having to define al

[systemd-devel] [PATCH] use #pragma once instead of foo*foo #define guards

2012-07-18 Thread Shawn Landden
#pragma once has been "un-deprecated" in gcc since 3.3, and is widely supported in other compilers. I've been using and maintaining (rebasing) this patch for a while now, as it annoyed me to see #ifndef fooblahfoo, etc all over the place, almost arrogant about the annoyance of having to define al

[systemd-devel] [PATCH] use #pragma once instead of foo*foo #define guards

2012-07-18 Thread Shawn Landden
#pragma once has been "un-deprecated" in gcc since 3.3, and is widely supported in other compilers. I've been using and maintaining (rebasing) this patch for a while now, as it annoyed me to see #ifndef fooblahfoo, etc all over the place, almost arrogant about the annoyance of having to define al

[systemd-devel] [PATCH] use "Out of memory." consistantly (or with "\n")

2012-07-24 Thread Shawn Landden
glibc/glib both use "out of memory" consistantly so maybe we should consider that instead of this. Eliminates one string out of a number of binaries. Also fixes extra newline in udev/scsi_id --- src/cgtop/cgtop.c |2 +- src/core/cgroup.c

[systemd-devel] [PATCH] man: remove timezone(5) and add localtime(5)

2012-08-09 Thread Shawn Landden
Developer +Lennart +Poettering +lenn...@poettering.net + + +Developer +

[systemd-devel] [PATCH 1/3] util: add symlink_atomic()

2012-08-11 Thread Shawn Landden
From: Shawn Landen unlike symlink_or_copy_atomic(), this function creates a symlink even if the oldname and newname (from and to) are on differn't devices. (stat.st_dev) --- src/shared/util.c | 19 +-- src/shared/util.h |1 + 2 files changed, 18 insertions(+), 2 deletions(-

[systemd-devel] [PATCH 2/3] timedated: gather timezone from /etc/localtime sym target

2012-08-11 Thread Shawn Landden
From: Shawn Landen /etc/localtime -> /usr/share/zoneinfo/... or /etc/localtime -> ../usr/share/zoneinfo/... (note, ../usr is not the same if /etc is a symlink, as this isn't using canonicalize_file_name()) keep other method for now, consider dropping later. Supporting relative links here are

[systemd-devel] [PATCH 3/3] man: remove timezone(5) and add localtime(5)

2012-08-11 Thread Shawn Landden
ystemd. Copyright 2010 Lennart Poettering + Copyright 2012 Shawn Landden systemd is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by @@ -22,9 +23,9 @@ along with systemd; If not, see <http://www.gnu.org

[systemd-devel] whoops, handle readlink_malloc returning -ENOMEM properly

2012-08-11 Thread Shawn Landden
only syscalls set errno ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH 2/3] timedated: gather timezone from /etc/localtime sym target

2012-08-11 Thread Shawn Landden
From: Shawn Landen /etc/localtime -> /usr/share/zoneinfo/... or /etc/localtime -> ../usr/share/zoneinfo/... (note, ../usr is not the same if /etc is a symlink, as this isn't using canonicalize_file_name()) keep other method for now, consider dropping later. Supporting relative links here are

[systemd-devel] [PATCH v9000 1/3] util: add symlink_atomic()

2012-08-12 Thread Shawn Landden
unlike symlink_or_copy_atomic(), this function creates a symlink even if the oldname and newname (from and to) are on differn't devices. (stat.st_dev) --- src/shared/util.c | 19 +-- src/shared/util.h |1 + 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/src/s

[systemd-devel] [PATCH v9000 2/3] timedated: gather timezone from /etc/localtime sym target

2012-08-12 Thread Shawn Landden
/etc/localtime -> /usr/share/zoneinfo/... or /etc/localtime -> ../usr/share/zoneinfo/... (note, ../usr is not the same if /etc is a symlink, as this isn't using canonicalize_file_name()) keep other method for now, consider dropping later. Supporting relative links here are problematic as timez

[systemd-devel] [PATCH v9000 3/3] man: remove timezone(5) and add localtime(5)

2012-08-12 Thread Shawn Landden
ystemd. Copyright 2010 Lennart Poettering + Copyright 2012 Shawn Landden systemd is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by @@ -22,9 +23,9 @@ along with systemd; If not, see <http://www.gnu.org

[systemd-devel] [PATCH v9001 2/3] timedated: gather timezone from /etc/localtime sym target

2012-08-14 Thread Shawn Landden
/etc/localtime -> /usr/share/zoneinfo/... or /etc/localtime -> ../usr/share/zoneinfo/... (note, ../usr is not the same if /etc is a symlink, as this isn't using canonicalize_file_name()) keep other method for now, consider dropping later. Supporting relative links here are problematic as timez

[systemd-devel] [PATCH] core: avoid needless strdup by working with strings directly

2012-08-15 Thread Shawn Landden
--- src/core/main.c | 51 ++- 1 file changed, 22 insertions(+), 29 deletions(-) diff --git a/src/core/main.c b/src/core/main.c index cdd77c1..e9b656b 100644 --- a/src/core/main.c +++ b/src/core/main.c @@ -339,12 +339,11 @@ static int parse_proc_cm

[systemd-devel] [PATCH] core: avoid needless strdup by working with strings directly

2012-08-16 Thread Shawn Landden
--- src/core/main.c | 52 ++-- 1 file changed, 22 insertions(+), 30 deletions(-) diff --git a/src/core/main.c b/src/core/main.c index cdd77c1..4e12793 100644 --- a/src/core/main.c +++ b/src/core/main.c @@ -237,7 +237,7 @@ static int set_default_un

[systemd-devel] [PATCH v2] core: avoid needless strdup by working with strings directly

2012-08-16 Thread Shawn Landden
config_parse_join_controllers() not converted cause that is a const char * --- src/core/main.c | 38 -- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/src/core/main.c b/src/core/main.c index cdd77c1..528cfec 100644 --- a/src/core/main.c +++ b/

[systemd-devel] [PATCH] timedated: support split usr v3

2015-01-18 Thread Shawn Landden
From: Shawn Paul Landden The current Debian solution to this is really ugly, and I would rather have them use the correct patch even if split usr is dumb. Read: http://rusty.ozlabs.org/?p=236 ("Why Everyone Must Oppose The Merging of /usr and /") (I managed to skip the pulseaudio implamentatio

Re: [systemd-devel] [PATCH] timedated: support split usr v3

2015-01-19 Thread Shawn Landden
On Sun, Jan 18, 2015 at 12:52 PM, Kay Sievers wrote: > On Sun, Jan 18, 2015 at 7:53 PM, Shawn Landden > wrote: > > From: Shawn Paul Landden > > > > The current Debian solution to this is really ugly, and I would rather > > have them use the correct patch even if

[systemd-devel] [PATCH] shutdown: avoid calling `kexec` binary unnessecarily

2015-02-13 Thread Shawn Landden
Still use helper when Xen Dom0, to avoid duplicating some hairy code. So we don't have any logic to load kexec kernels? --- TODO| 3 --- src/core/shutdown.c | 33 - 2 files changed, 20 insertions(+), 16 deletions(-) diff --git a/TODO b/TODO index 8

[systemd-devel] [PATCH] timedated: when performing "SetTime" compensate for program lag

2015-02-13 Thread Shawn Landden
--- TODO | 2 -- src/timedate/timedated.c | 14 ++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/TODO b/TODO index 68b0af6..7b93404 100644 --- a/TODO +++ b/TODO @@ -190,8 +190,6 @@ Features: * we should try harder to collapse start jobs for swaps

[systemd-devel] [PATCH] timedated: when performing "SetTime" compensate for program lag

2015-02-16 Thread Shawn Landden
The start time could be moved back a little bit by using kdbus timestamps, but I'm guessing that that amount of time is insignificant. --- TODO | 2 -- src/timedate/timedated.c | 7 +++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/TODO b/TODO index 93dfa60

[systemd-devel] [PATCH] timedated: when performing "SetTime" compensate for program lag

2015-02-16 Thread Shawn Landden
I can't test this as kdbus doesn't build against Linux 3.19 --- TODO | 2 -- src/timedate/timedated.c | 14 ++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/TODO b/TODO index 93dfa60..88055d3 100644 --- a/TODO +++ b/TODO @@ -190,8 +190,6 @@ Featur

[systemd-devel] [PATCH] configure: turn off -Wlogical-not-parentheses

2015-02-16 Thread Shawn Landden
Introduced in gcc-5 These errors are really annoying. I can get behind clarification of nested ifs, but this is overkill. --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index 97a29d6..e646db7 100644 --- a/configure.ac +++ b/configure.ac @@ -187,6

Re: [systemd-devel] [PATCH] configure: turn off -Wlogical-not-parentheses

2015-02-16 Thread Shawn Landden
On Mon, Feb 16, 2015 at 2:03 PM, Zbigniew Jędrzejewski-Szmek < zbys...@in.waw.pl> wrote: > On Mon, Feb 16, 2015 at 02:02:17PM -0800, Shawn Landden wrote: > > Introduced in gcc-5 > > > > These errors are really annoying. I can get behind clarification of > nested

Re: [systemd-devel] [PATCH] shutdown: avoid calling `kexec` binary unnessecarily

2015-02-16 Thread Shawn Landden
On Mon, Feb 16, 2015 at 5:08 AM, Lennart Poettering wrote: > On Fri, 13.02.15 14:18, Shawn Landden (sh...@churchofgit.com) wrote: > > > Still use helper when Xen Dom0, to avoid duplicating some hairy > > code. > > Hmm, what precisely does the helper do on xen? > > &

Re: [systemd-devel] [PATCH] shutdown: avoid calling `kexec` binary unnessecarily

2015-02-17 Thread Shawn Landden
On Tue, Feb 17, 2015 at 7:00 AM, Zbigniew Jędrzejewski-Szmek < zbys...@in.waw.pl> wrote: > On Mon, Feb 16, 2015 at 07:53:47PM -0800, Shawn Landden wrote: > > On Mon, Feb 16, 2015 at 5:08 AM, Lennart Poettering < > lenn...@poettering.net> > > wrote: > > > &g

Re: [systemd-devel] [PATCH] shutdown: avoid calling `kexec` binary unnessecarily

2015-02-17 Thread Shawn Landden
On Tue, Feb 17, 2015 at 4:34 PM, Shawn Landden wrote: > On Tue, Feb 17, 2015 at 7:00 AM, Zbigniew Jędrzejewski-Szmek < > zbys...@in.waw.pl> wrote: > >> On Mon, Feb 16, 2015 at 07:53:47PM -0800, Shawn Landden wrote: >> > On Mon, Feb 16, 2015 at 5:08 AM

Re: [systemd-devel] [PATCH] shutdown: avoid calling `kexec` binary unnessecarily

2015-02-17 Thread Shawn Landden
t; On Mon, Feb 16, 2015 at 07:53:47PM -0800, Shawn Landden wrote: > > On Mon, Feb 16, 2015 at 5:08 AM, Lennart Poettering < > lenn...@poettering.net> > > wrote: > > > > > On Fri, 13.02.15 14:18, Shawn Landden (sh...@churchofgit.com) wrote: > > > > &

[systemd-devel] [PATCH] fix build against v3.20-rc1

2015-02-18 Thread Shawn Landden
--- fs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs.c b/fs.c index 22ca62b..f751392 100644 --- a/fs.c +++ b/fs.c @@ -208,7 +208,6 @@ static struct inode *fs_inode_get(struct super_block *sb, inode->i_private = kdbus_node_ref(node); inode->i_mapping->a_ops = &empty_aops

[systemd-devel] [PATCH 3/8] power: refactor the three power management binaries to src/power

2015-02-20 Thread Shawn Landden
--- Makefile.am | 6 +- src/core/shutdown.c | 420 - src/power/Makefile| 28 +++ src/power/shutdown.c | 420 + src/power/shutdownd.c | 461 +++

[systemd-devel] [PATCH 6/8] add rbtree implamentation

2015-02-20 Thread Shawn Landden
from https://github.com/fbuihuu/libtree (LGPLv2.1+) --- Makefile.am | 2 + src/shared/rbtree.c | 482 src/shared/rbtree.h | 79 + 3 files changed, 563 insertions(+) create mode 100644 src/shared/rbtree.c create mode 100644 s

[systemd-devel] [PATCH 5/8] power: these binaries are internal APIs

2015-02-20 Thread Shawn Landden
They are not executed by a user (they all check how they were executed) so we can use assert() in main() just like we would anywhere else. --- src/power/shutdown.c | 20 ++-- src/power/shutdownd.c | 22 -- src/power/sleep.c | 14 +++--- 3 files chan

[systemd-devel] [PATCH 1/8] man: these binaries are internal APIs

2015-02-20 Thread Shawn Landden
--- man/systemd-halt.service.xml | 1 - man/systemd-shutdownd.service.xml | 1 - man/systemd-suspend.service.xml | 1 - 3 files changed, 3 deletions(-) diff --git a/man/systemd-halt.service.xml b/man/systemd-halt.service.xml index c94e2a1..7e7f8f2 100644 --- a/man/systemd-halt.service.xml

[systemd-devel] [PATCH 2/8] man/systemd.timer.xml: improve documentation of WakeSystem=

2015-02-20 Thread Shawn Landden
--- man/systemd.timer.xml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/man/systemd.timer.xml b/man/systemd.timer.xml index 20890f2..4207be0 100644 --- a/man/systemd.timer.xml +++ b/man/systemd.timer.xml @@ -230,8 +230,9 @@ be suspended and if the system support

[systemd-devel] [PATCH 4/8] update TODO

2015-02-20 Thread Shawn Landden
--- TODO | 2 ++ 1 file changed, 2 insertions(+) diff --git a/TODO b/TODO index 52a32d3..bf66ba1 100644 --- a/TODO +++ b/TODO @@ -32,6 +32,8 @@ External: * When lz4 gets an API for lz4 command output, make use of it to compress coredumps in a way compatible with /usr/bin/lz4. +* Fix emacs f

[systemd-devel] [PATCH 7/8] add rpmvercmp()

2015-02-20 Thread Shawn Landden
--- Makefile.am| 2 + src/shared/rpmvercmp.c | 122 + src/shared/rpmvercmp.h | 14 ++ 3 files changed, 138 insertions(+) create mode 100644 src/shared/rpmvercmp.c create mode 100644 src/shared/rpmvercmp.h diff --git a/Makefile.a

[systemd-devel] [PATCH 8/8] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-02-20 Thread Shawn Landden
c = rbtree_container_of(n, struct BootSpec, node); +} +} else +r = 0; +#endif +return r; +} diff --git a/src/systemctl/bootspec.h b/src/systemctl/bootspec.h new file mode 100644 index 000..19e2901 --- /dev/n

[systemd-devel] [v1] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-02-20 Thread Shawn Landden
if (!l) +return; + +for (k = l; *k; k++) +free(*k); + free(l); } diff --git a/src/systemctl/bootspec.c b/src/systemctl/bootspec.c new file mode 100644 index 000..0a43c7b --- /dev/null +++ b/src/systemctl/bootspec.c @@ -0,0 +1,204 @@ +/*-*- Mode:

Re: [systemd-devel] A use case for staged startup

2015-02-21 Thread Shawn Landden
t need systemctl like the previous post suggests, if you get the dependencies right. You might also look at overlayfs, which got merged in Linux 3.18. I think overlayfs will make this possible, and of course share your results! > Thanks, > Jeff > > [1] > http://lists.freedesktop.org/arch

Re: [systemd-devel] feature request: dlopen

2015-02-22 Thread Shawn Landden
sufficient > that you will give this absolute top priority above everything else > that cannot be immediately put on hold. > > i am subscribed to this list on "nomail", and will follow it on gmane. > as you are experienced software developers i would not presume to > interfere with how to go about dynamically-loading of libsystemd0, > however if you would appreciate the benefit of my experience (which > comes in part from one of the software libre world's more experienced > unix portability experts, andrew tridgell), i will be more than happy > to help as i can. > > l. > ___ > systemd-devel mailing list > systemd-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/systemd-devel > -- --- Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] configure: turn off -Wlogical-not-parentheses

2015-02-24 Thread Shawn Landden
On Tue, Feb 24, 2015 at 9:33 AM, David Herrmann wrote: > Hi > > On Mon, Feb 16, 2015 at 11:02 PM, Shawn Landden > wrote: > > Introduced in gcc-5 > > > > These errors are really annoying. I can get behind clarification of > nested ifs, > > but this is

Re: [systemd-devel] [PATCH 3/8] power: refactor the three power management binaries to src/power

2015-02-27 Thread Shawn Landden
is shared currently. This also eliminates one directory. All of these are handled by units: sleep.target shutdown.target etc... > > On Fri, Feb 20, 2015 at 02:31:00PM -0800, Shawn Landden wrote: > > --- > > Makefile.am | 6 +

<    1   2   3   >