[Tails-dev] Please test and review feature/sdio

2013-09-29 Thread intrigeri
Hi, feature/sdio adds support for SD cards plugged into a reader that's wired as SDIO. Please test and review. Tickets: - parent: #6324 - liveusb-creator: #5744 - persistence setup: #6325 The branch is called feature/sdio in the main Tails repo. Same in our liveusb-creator and tails-persis

Re: [Tails-dev] Please review and merge feature/keepassx_launcher

2013-09-29 Thread sajolida
On 29/09/13 14:42, intrigeri wrote: > Alan wrote (25 Sep 2013 13:47:33 GMT) : >> I believe the feature/keepassx_launcher is now ready. >> ticket: https://labs.riseup.net/code/issues/5686 I built the branch and it works fine. > Looks good, but the documentation needs to be updated accordingly: > d

Re: [Tails-dev] Please review and merge feature/liveusb_ui_improvement

2013-09-29 Thread intrigeri
intrigeri wrote (29 Sep 2013 12:16:47 GMT) : > Perhaps we shouldn't only display the brand and model, but also > reintroduce the device name (such as /dev/sdb1)? > Same in the confirmation dialog, that actually now has less relevant > information than it used to. Implementing this. I'll have it r

Re: [Tails-dev] Please review'n'merge feature/Sign_jenkins_builds_artifacts

2013-09-29 Thread intrigeri
berta...@ptitcanardnoir.org wrote (29 Sep 2013 13:13:31 GMT) : > I've reverted both commits as you asked, and run the puppetd --test > command on the builder VM. Great. > I'm not sure anymore what I was trying to fix > for real in the end, as it seems to work as it is right now. It may very well

Re: [Tails-dev] Please review'n'merge feature/Sign_jenkins_builds_artifacts

2013-09-29 Thread bertagaz
On Sun, Sep 29, 2013 at 01:55:18PM +0200, intrigeri wrote: > berta...@ptitcanardnoir.org wrote (28 Sep 2013 09:22:16 GMT) : > > This change goes together with two changes in our puppet modules: > > > A new one has been created to deploy the gnupg keyring in our autobuilder > > VM on lizard, and ha

Re: [Tails-dev] Please review'n'merge feature/Sign_jenkins_builds_artifacts

2013-09-29 Thread intrigeri
berta...@ptitcanardnoir.org wrote (29 Sep 2013 12:13:24 GMT) : > Oooch, you're right. I've just force updated the branch for it to be > based on the stable one. Thanks for the reminder. merged, pushed to origin + lizard, thanks. ___ tails-dev mailing lis

Re: [Tails-dev] Please review and merge feature/keepassx_launcher

2013-09-29 Thread intrigeri
Alan wrote (25 Sep 2013 13:47:33 GMT) : > I believe the feature/keepassx_launcher is now ready. > ticket: https://labs.riseup.net/code/issues/5686 Looks good, but the documentation needs to be updated accordingly: doc/first_steps/introduction_to_gnome_and_the_tails_desktop Cheers, -- intrigeri

Re: [Tails-dev] Please review'n'merge feature/Sign_jenkins_builds_artifacts

2013-09-29 Thread bertagaz
On Sun, Sep 29, 2013 at 01:36:28PM +0200, intrigeri wrote: > berta...@ptitcanardnoir.org wrote (28 Sep 2013 09:22:16 GMT) : > > Please merge this branch in experimental, devel, stable, testing and > > feature/wheezy if happy with it. > > I'd be happy too, but the branch is based on devel, so I can

Re: [Tails-dev] Please review and merge feature/liveusb_ui_improvement

2013-09-29 Thread intrigeri
Hi, another test pass: when running the installer on a ThinkPad X60s, and plugging a SD card into the (SDIO-wired) reader, the target device appears this way in the list: 0 (Tails) Perhaps we shouldn't only display the brand and model, but also reintroduce the device name (such as /dev/sd

Re: [Tails-dev] Please review'n'merge feature/Sign_jenkins_builds_artifacts

2013-09-29 Thread intrigeri
berta...@ptitcanardnoir.org wrote (28 Sep 2013 09:22:16 GMT) : > This change goes together with two changes in our puppet modules: > A new one has been created to deploy the gnupg keyring in our autobuilder > VM on lizard, and has been reviewed already by intrigeri. I've had a look to the newest

Re: [Tails-dev] Please review'n'merge feature/Sign_jenkins_builds_artifacts

2013-09-29 Thread intrigeri
berta...@ptitcanardnoir.org wrote (28 Sep 2013 09:22:16 GMT) : > Please merge this branch in experimental, devel, stable, testing and > feature/wheezy if happy with it. I'd be happy too, but the branch is based on devel, so I can't merge it into stable. Please rebase on stable, and reassign the ti

Re: [Tails-dev] Please review and merge feature/liveusb_ui_improvement

2013-09-29 Thread intrigeri
Hi, merged into devel, *but* not 100% done yet: > - https://labs.riseup.net/code/issues/6292 -> marked as needs more dev (I'm thinking of the devices menu UI bug; I don't remember if my review exposed other blockers) > - https://labs.riseup.net/code/issues/6293 -> Alright, marked as Fix com