Re: [Tails-dev] AdBlock Plus in Tails' Tor Browser

2014-10-31 Thread intrigeri
Hi, [Dropping tbb-dev from the Cc list. Let's get our stuff clearer, and then come back to them if needed.] anonym wrote (23 Oct 2014 12:42:02 GMT) : > 23/10/14 11:08, Georg Koppen wrote: >>> [1] https://tails.boum.org/contribute/design/#index40h3 >> >> what does adding Adblock plus have for a be

[Tails-dev] [review'n'merge:1.2.1] test/8140-more-robust-apps-menu

2014-10-31 Thread intrigeri
Hi, this branch makes our test suite more robust. Please review'n'merge into stable and devel. Kill Your TV: you might want to take this one too. Cheers, -- intrigeri ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tail

Re: [Tails-dev] [review'n'merge: 1.3] bugfix/7951-refactor-chroot-browsers

2014-10-31 Thread intrigeri
Hi, intrigeri wrote (31 Oct 2014 12:55:44 GMT) : >> + when "the I2P Browser" >> +user = "i2pbrowesr" > XXX Ooops, I forgot this one. Obviously the test fails, so I think I've fixed it in e44f97c. No big deal, but it makes me question how much trust I can put, as a reviewer, into "I've test

[Tails-dev] [review'n'merge:1.2.1] test/8059-more-robust-windows-systray

2014-10-31 Thread intrigeri
Hi, this branch makes our Windows camouflage automated tests more robust. Please review'n'merge into stable and devel. Kill Your TV, want to take it? anonym: unless Kill Your TV takes it promptly, please review'n'merge it soon, as these false positives are getting me mad. Cheers, -- intrigeri

Re: [Tails-dev] [review'n'merge:1.3] #8091 -- Support automated testing of old ISO images with different set of persistence presets

2014-10-31 Thread intrigeri
Also note that I've just merged this branch into experimental, and resolved conflicts with the changes in the same area brought by feature/6739-install-electrum. Not tested yet. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listi

[Tails-dev] [review'n'merge:1.2.1] bugfix/8189-intel-microcode-v3

2014-10-31 Thread intrigeri
Hi, all Tails ISO builds are currently broken, this branch fixes it (and should improve behavior in some cases, incidentally). Please review'n'merge ASAP into stable and devel. Thanks! Cheers, -- intrigeri ___ Tails-dev mailing list Tails-dev@boum.org

Re: [Tails-dev] [review'n'merge:1.3] #8091 -- Support automated testing of old ISO images with different set of persistence presets

2014-10-31 Thread intrigeri
Hi, I could not find this pull request in the list's archives, so let's emulate it. [Off-topic: note that we still have *not* made it so we can reasonably skip sending pull requests here (namely: providing, documenting and advertising a way to follow pull requests and merges via Redmine -- that i

Re: [Tails-dev] [review'n'merge: 1.3] bugfix/7951-refactor-chroot-browsers

2014-10-31 Thread intrigeri
Hi, I've looked at the code -- it took me a few hours, wow -- so here are a few initial comments. First of all, great work! I'm glad most functions now take arguments, instead of relying on a bunch of global variables. I'm also glad you took this opportunity to refactor and fix $LANG handling, i2