Re: [Tails-dev] Proposal: use the "Reviewer" field in GitLab MRs

2021-04-08 Thread intrigeri
Hi, Sandro Knauß (2021-04-07): > I like the request. Thanks for your feedback. > But there is issue - users need more privileges to set the > reviewer field. You're saying "more privileges" so I'd like to understand if it's "more than the current status" or "more than ideal". According to http

Re: [Tails-dev] Proposal: use the "Reviewer" field in GitLab MRs

2021-04-08 Thread Sandro Knauß
Hi, I like the request. But there is issue - users need more privileges to set the reviewer field. That happens for me, that I cannot set the reviewer for MR at the puppet-tails repo. So I need to ping a sysadmin to set themselves as reviewer (as part of the translation plattfom work is done i

Re: [Tails-dev] Proposal: use the "Reviewer" field in GitLab MRs

2021-04-08 Thread intrigeri
Hi, Zen Fu (2021-04-07): > Another thing that could be explicitely documented is whether a reviewer > should/could merge code after a review or not. This may differ from team > to team because not always the assignee has privileges to merge. Maybe > we could explicitely say when we expect the revi