Re: [Tails-dev] Review of verification-extension

2017-11-28 Thread Uzair Farooq
ul if you add some comments to the file in future. On Fri, Nov 24, 2017 at 1:49 PM, u wrote: > Hi, > > Uzair Farooq: > > >> - What kind of comments does this remove: > >>44 data = data.replace(/^[^'"]*#.*/gm, ''); // remove most comments > >

Re: [Tails-dev] Security of postMessage between Tails Verification and the download page

2017-11-28 Thread Uzair Farooq
t must be licensed under a GPLv3-compatible license, and the corresponding copyright info must be kept. There's a small part of code that was copied from old extension but I don't see any licensing or copyright notice in the original repo. On Sat, Nov 25, 2017 at 6:44 PM, intrigeri

Re: [Tails-dev] Security of postMessage between Tails Verification and the download page

2017-11-21 Thread Uzair Farooq
Here are my findings: 1. Our extension script is only injected in https://tails.boum.org, so unless there's an iframe on the download page there's no way for any other hosts to receive message from our extension. Nevertheless, I've changed the target from'*' to 'https://tails.boum.org' to be more

Re: [Tails-dev] Review of verification-extension

2017-11-17 Thread Uzair Farooq
>- contentscript/verify.js: > - fetchConf(): please wrap regexps. Done. >- contentscript/conf.js: > - change the descriptor file to >https://tails.boum.org/install/v1/Tails/amd64/stable/latest.yml Done > - are we sure that no other URL could be injected here: ajaxData.url= > this.conf.descri

Re: [Tails-dev] Verification extension [was: HTML prototype for new download page]

2017-11-16 Thread Uzair Farooq
e you tried to do originally in 412cb50? I've moved the logic to website. The extension now sends message and website then shows 'Verification' view. On Thu, Nov 16, 2017 at 5:46 PM, sajolida wrote: > Uzair Farooq: > > The repo url you mentioned says 'No repo foun

Re: [Tails-dev] Verification extension [was: HTML prototype for new download page]

2017-11-15 Thread Uzair Farooq
0773cb? Yeah, I originally planned to do it in web app but then noticed this comment in web app 'This should be done by the extension instead' and thought you want this in the extension. On Tue, Nov 14, 2017 at 9:21 PM, sajolida wrote: > sajolida: > > Uzair Farooq: > >>&

Re: [Tails-dev] Verification extension [was: HTML prototype for new download page]

2017-11-13 Thread Uzair Farooq
>When the extension gets installed, the page is not updated to show "Verify download...". See this screencast: > https://dl.poivron.org/maad2a3jiuqdu3k3wjbf-dirqyvooctlkem57 > Uzair: Could you help me fix that? Is it something that should be fixed in the extension or on the page? Fixed, extensio

Re: [Tails-dev] Verification extension [was: HTML prototype for new download page]

2017-11-13 Thread Uzair Farooq
ut can't seem to pass 'Install Verification Extension' button. Even though the extension is installed, it still says to install extension. On Sat, Nov 11, 2017 at 9:06 PM, Uzair Farooq wrote: > > But I don't see any new commit on your repo so maybe you forgot to > push

Re: [Tails-dev] Verification extension [was: HTML prototype for new download page]

2017-11-11 Thread Uzair Farooq
> But I don't see any new commit on your repo so maybe you forgot to push: Yeah seems like that. We'll push the changes. > I tried that both in Tor Browser and Chromium and could make it work. Here is the background.js script that I'm using: Instead of whole path can you just try 'download_2.htm

Re: [Tails-dev] Verification extension [was: HTML prototype for new download page]

2017-11-08 Thread Uzair Farooq
v 8, 2017 at 12:11 AM, sajolida wrote: > Uzair Farooq: > >> * Test that it works for you on https://tails.boum.org/ > install/download_2/ > > . > > > > This does not work for us either. Reason because no element with id > > 'download-and-verify' is pre

Re: [Tails-dev] Verification extension [was: HTML prototype for new download page]

2017-11-04 Thread Uzair Farooq
The repositories urls: - https://github.com/usman-subhani/Tails-repos - https://github.com/usman-subhani/verification-extension/ On Sat, Nov 4, 2017 at 4:30 PM, Uzair Farooq wrote: > Hey. > > 1. We are now logging percentage to console, you can replace it with a > progress bar. P

Re: [Tails-dev] Verification extension [was: HTML prototype for new download page]

2017-11-04 Thread Uzair Farooq
ething. Cheers! On Fri, Nov 3, 2017 at 5:53 PM, sajolida wrote: > sajolida: > > Uzair Farooq: > >> Uzair Farooq: > >>> Hey, we checked the forge library (the one they listed as the fastest > in > >>> their benchmark). To my surprise it improved t

Re: [Tails-dev] HTML prototype for new download page

2017-10-29 Thread Uzair Farooq
3:15 AM, anonym wrote: > Uzair Farooq: > > Hey, we checked the forge library (the one they listed as the fastest in > > their benchmark). To my surprise it improved the time darastically. It > took > > a little more than 1 minute on a core i3 machine with 4GB RAM. We have

Re: [Tails-dev] HTML prototype for new download page

2017-10-26 Thread Uzair Farooq
/verification-extension Regards, Uzair On Thu, 26 Oct 2017 at 6:36 PM, sajolida wrote: > sajolida: > > anonym: > >> Uzair Farooq: > >>> Hey, > >>> > >>>> How long does it take to get a successful result of the verification > >>>> extens

Re: [Tails-dev] HTML prototype for new download page

2017-10-21 Thread Uzair Farooq
sion icon). >- User will select the downloaded file and extension will let user know if the image is valid or not. > So do you confirm that we won't be able to do certificate pining in the new extension? Yeah, unfortunately not possible with webextensions. On Thu, Oct 19, 2017 at 3:59

Re: [Tails-dev] HTML prototype for new download page

2017-10-17 Thread Uzair Farooq
de are add-on SDK specific and aren't supported in WebExtensions, it was better to rewrite. On Sun, Oct 15, 2017 at 10:07 PM, sajolida wrote: > Uzair Farooq: > > We made the commit on top of existing repo, here > > https://github.com/usman-subhani/Tails-repos > > Yeah

Re: [Tails-dev] HTML prototype for new download page

2017-10-14 Thread Uzair Farooq
2017 at 5:11 PM, anonym wrote: > sajolida: > > Uzair Farooq: > >> I've pushed two repositories: > >> > >> Extension: https://github.com/usman-subhani/verification-extension > > > > anonym: Can you check this one? > > Sure! > > Th

Re: [Tails-dev] HTML prototype for new download page

2017-10-04 Thread Uzair Farooq
I've pushed two repositories: Extension: https://github.com/usman-subhani/verification-extension Web: https://github.com/usman-subhani/Tails-Web-App Please have a look and let me know if there are any issues. On Wed, Oct 4, 2017 at 9:11 PM, sajolida wrote: > intrigeri: > >

Re: [Tails-dev] HTML prototype for new download page

2017-09-30 Thread Uzair Farooq
I've made changes to the site, do I push directly to the repository? I don't seem to have access to push to the repo. On Thu, Sep 28, 2017 at 8:55 PM, sajolida wrote: > Uzair Farooq: > > Hey sajolida, > > > > Can you let me know how to run the DAVE site locall

Re: [Tails-dev] HTML prototype for new download page

2017-09-27 Thread Uzair Farooq
Hey sajolida, Can you let me know how to run the DAVE site locally? I'm implementing message passing in site and need to test it. On Wed, Sep 27, 2017 at 3:21 PM, Uzair Farooq wrote: > Yeah, will name it TAILS_VERIFICATION_EXTENSION_VERSION > > On Wed, Sep 27, 2017 at 2:46 PM, s

Re: [Tails-dev] HTML prototype for new download page

2017-09-27 Thread Uzair Farooq
Yeah, will name it TAILS_VERIFICATION_EXTENSION_VERSION On Wed, Sep 27, 2017 at 2:46 PM, sajolida wrote: > Uzair Farooq: > >> I have a function called showVerifyingDownload to toggle from the click > on > >> the "Verify..." button to the display of &

Re: [Tails-dev] HTML prototype for new download page

2017-09-26 Thread Uzair Farooq
te. I will let you know if anything is needed from your end. On Tue, Sep 26, 2017 at 10:41 PM, sajolida wrote: > Uzair Farooq: > >> For example, I supposed that it will be possible for your extension > >> to rely on some calls to some functions in the s

Re: [Tails-dev] HTML prototype for new download page

2017-09-25 Thread Uzair Farooq
> For example, I supposed that it will be possible for your extension to rely on some calls to some functions in the script dealing with the logic between the moving parts (for example 'showVerificationResult'). I thought that this would help us decouple what's shipped in the extension from the con