[Tails-dev] Please review feature/use_ferm

2012-09-23 Thread Ague Mill
Hi! The branch feature/use_ferm turns our DIY iptables-restore script into a ferm configuration file. See for details. Comparing the output of `iptables-save` with the one of 0.13, I have only this minor difference: --A OUTPUT -d 127.0.0.1/32 -o lo -p tcp -m o

Re: [Tails-dev] Please review feature/use_ferm

2012-09-24 Thread intrigeri
Hi, > Reviews welcome, candidate for the next major release. I'm not too happy with the initial commit (f00effb), because it removes the check for the needed tool existence and leaves the exit code checking to the implicit. I suggest: * re-adding something like: [ -x /usr/sbin/ferm ] ||

Re: [Tails-dev] Please review feature/use_ferm

2012-09-24 Thread bertagaz
Hi, On Mon, Sep 24, 2012 at 12:27:59PM +0200, intrigeri wrote: > Hi, > > > Reviews welcome, candidate for the next major release. > > I'm not too happy with the initial commit (f00effb), because it > removes the check for the needed tool existence and leaves the exit > code checking to the impli

Re: [Tails-dev] Please review feature/use_ferm

2012-09-24 Thread Ague Mill
On Mon, Sep 24, 2012 at 03:56:05PM +0200, berta...@ptitcanardnoir.org wrote: > > I'm not too happy with the initial commit (f00effb), because it > > removes the check for the needed tool existence and leaves the exit > > code checking to the implicit. Fixed in devel. > > I suggest: > > > > * r