Re: [Tails-dev] Please test pre-commit hook for po files

Hi! intrigeri: > intrigeri: >> Now, this hook runs wiki/src/contribute/l10n_tricks/check_po.sh so the >> problem I'm describing above is still there. This could not fixed in >> pre-commit hook by calling submodules/jenkins-tools/slaves/check_po >> directly instead of going through the symlink. >

Re: [Tails-dev] Please test pre-commit hook for po files

intrigeri: > Now, this hook runs wiki/src/contribute/l10n_tricks/check_po.sh so the > problem I'm describing above is still there. This could not fixed in > pre-commit hook by calling submodules/jenkins-tools/slaves/check_po > directly instead of going through the symlink. Was this fixed? Also, I

Re: [Tails-dev] Please test pre-commit hook for po files

u: > sajolida: >> u: >> Then I did a dummy change to index.es.po and tried to commit it. >> >> I got the following: >> >> Project-Id-Version header is not empty for following files: >> wiki/src/index.es.po >> >> The po files you're trying to commit contain errors. Please fix them >>

Re: [Tails-dev] Please test pre-commit hook for po files

Hi! sajolida: > u: >> Upon a technical remark, I moved the pre-commit file to >> bin/pre-commit-translation instead. See updated instructions below. >> >> git fetch tails translation_platform_hooks >> git submodule update --init >> cd .git/hooks >> ln -s ../../bin/pre-commit-transl

Re: [Tails-dev] Please test pre-commit hook for po files

u: > Upon a technical remark, I moved the pre-commit file to > bin/pre-commit-translation instead. See updated instructions below. > > git fetch tails translation_platform_hooks > git submodule update --init > cd .git/hooks > ln -s ../../bin/pre-commit-translation pre-commit Doing

Re: [Tails-dev] Please test pre-commit hook for po files

Hi! intrigeri: > u: >> intrigeri: >>> u: ln -s ../../wiki/src/contribute/l10n_tricks/pre-commit . >>> >>> This caught my eye before I could test this. >>> >>> I'd rather not ask all Tails contributors to run code, on every >>> commit, that lives in a section of our website that's publicly >

Re: [Tails-dev] Please test pre-commit hook for po files

u: > intrigeri: >> u: >>> ln -s ../../wiki/src/contribute/l10n_tricks/pre-commit . >> >> This caught my eye before I could test this. >> >> I'd rather not ask all Tails contributors to run code, on every >> commit, that lives in a section of our website that's publicly >> writable. Please consi

Re: [Tails-dev] Please test pre-commit hook for po files

Hi! Upon a technical remark, I moved the pre-commit file to bin/pre-commit-translation instead. See updated instructions below. git fetch tails translation_platform_hooks git submodule update --init cd .git/hooks ln -s ../../bin/pre-commit-translation pre-commit Cheers! u. __

Re: [Tails-dev] Please test pre-commit hook for po files

Hi! intrigeri: > u: >> ln -s ../../wiki/src/contribute/l10n_tricks/pre-commit . > > This caught my eye before I could test this. > > I'd rather not ask all Tails contributors to run code, on every > commit, that lives in a section of our website that's publicly > writable. Please consider movi

Re: [Tails-dev] Please test pre-commit hook for po files

u: > ln -s ../../wiki/src/contribute/l10n_tricks/pre-commit . This caught my eye before I could test this. I'd rather not ask all Tails contributors to run code, on every commit, that lives in a section of our website that's publicly writable. Please consider moving this script to bin/ :) _