Re: [Tails-dev] Scripts for importing Transifex translations, take two, please review

2013-12-09 Thread intrigeri
winterfa...@riseup.net wrote (09 Dec 2013 12:56:29 GMT) : > I have created them. Great. > Apparently I didn't have permissions yet to set proper "blocked by", > so I just left that as comments for now. You might be affected by a bug on this Redmine instance: if you've been asked an API key, try

Re: [Tails-dev] Scripts for importing Transifex translations, take two, please review

2013-12-09 Thread winterfairy
intrigeri wrote: > winterfairy at riseup.net wrote (07 Dec 2013 17:02:43 GMT) : >> Done in the same branch :) > > Tested on a few repos, works fine for me. Congrats! > > Merged into devel. I would have merged into testing too, if the branch > wasn't branched off devel. Will be in 0.23 instead of 0.

Re: [Tails-dev] Scripts for importing Transifex translations, take two, please review

2013-12-08 Thread intrigeri
Hi, winterfa...@riseup.net wrote (07 Dec 2013 17:02:43 GMT) : > Done in the same branch :) Tested on a few repos, works fine for me. Congrats! Merged into devel. I would have merged into testing too, if the branch wasn't branched off devel. Will be in 0.23 instead of 0.22.1, no big deal. Will y

Re: [Tails-dev] Scripts for importing Transifex translations, take two, please review

2013-12-07 Thread winterfairy
intrigeri wrote: > winterfairy wrote: >> See my tails repository, branch "import-translations-extern". >> [...] > > Here's an initial code review. > > Instead of: > > SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)" > > .. I would write the slightly nicer (to my eye): > > SCRIPT_DIR=$(readlink -f $(

Re: [Tails-dev] Scripts for importing Transifex translations, take two, please review

2013-12-07 Thread intrigeri
Hi, winterfa...@riseup.net wrote (06 Dec 2013 21:11:53 GMT) : > See my tails repository, branch "import-translations-extern". > It includes the required updates to the release process documentation too. > This works good too, and is without the code duplication. > So merge this one if you like th

Re: [Tails-dev] Scripts for importing Transifex translations, take two, please review

2013-12-06 Thread winterfairy
winterfairy wrote: > intrigeri wrote: >> It does look good, but I must say the intense code duplication makes >> me wonder if we shouldn't instead add one single script to the Tails >> main repository, make it take the relevant parameters [...] >> >> What do you think? > Maybe. I cannot see whethe

Re: [Tails-dev] Scripts for importing Transifex translations, take two, please review

2013-12-06 Thread intrigeri
winterfa...@riseup.net wrote (06 Dec 2013 11:10:35 GMT) : > intrigeri wrote: >> It does look good, but I must say the intense code duplication makes >> me wonder if we shouldn't instead add one single script to the Tails >> main repository, make it take the relevant parameters [...] >> >> What do y

Re: [Tails-dev] Scripts for importing Transifex translations, take two, please review

2013-12-06 Thread winterfairy
intrigeri wrote: > I had a quick look at two of those. > > It does look good, but I must say the intense code duplication makes > me wonder if we shouldn't instead add one single script to the Tails > main repository, make it take the relevant parameters [...] > > What do you think? Maybe. I canno

Re: [Tails-dev] Scripts for importing Transifex translations, take two, please review

2013-12-06 Thread intrigeri
winterfa...@riseup.net wrote (04 Dec 2013 13:07:41 GMT) : > Besides IUK and perl5lib for which Transifex resources still does not > exist, I believe I have resolved ticket #6207: > See branch "import-translations" in the following repositories (all based > on respective "master" branch): > - wint

[Tails-dev] Scripts for importing Transifex translations, take two, please review

2013-12-04 Thread winterfairy
Besides IUK and perl5lib for which Transifex resources still does not exist, I believe I have resolved ticket #6207: See branch "import-translations" in the following repositories (all based on respective "master" branch): - winterfairy/greeter - winterfairy/persistence-setup - winterfairy/live