Tom - Thanks for the clarification and not seen as argumentative (at
least by me).
Tom Melendez wrote:
Hi Folks,
We do have a style guide, defined and documented directory structure and
naming convention. My objective(s) in the review is to ensure that
conventions are being maintained (ea
Hi Folks,
> We do have a style guide, defined and documented directory structure and
> naming convention. My objective(s) in the review is to ensure that
> conventions are being maintained (easy to get lax in and nothing that would
> ever show up in testing), and that coders (and testers) stay at
Yeah, that's how I was looking at it and since I'm the only one other
than QA and coders that will be there, I'm not concerned or interested
in having anyone look bad. Nothing more frustrating than getting into
a religious argument when there's essentially nothing wrong. Just a
different way
On Wed, Dec 30, 2009 at 11:18 AM, Tom Melendez wrote:
>
> 2. You find something wrong, then what? And what if it is not
> "really" wrong (Jones uses a selection sort but sould have used an
> insertion sort, and no one told him beforehand). Do we hold up the
> project until the engs figure out w
Ben, David, Tom,
Thanks for the insightful input.. Sorry for the delay in responding,
but was gone over the holidays.
My take away is that they can be useful if applied in a manner that
avoids "pissing contests" between specific approaches, driven from above
with specific objective(
Hi Peter,
On Tue, Dec 29, 2009 at 2:30 PM, Peter Becker wrote:
> Looking to get some views (and best practices) on code reviews. I used to
> work at IBM on their early version of Websphere (as UI designer, not coder)
> where our group had code reviews on a regular basis. I'm now managing a
> sm
On 12/29/2009 5:30 PM, Peter Becker wrote:
Looking to get some views (and best practices) on code reviews.
At my current work the devs do code reviews once a mod, project, or milestone
is completed. The code review takes place before the peer review (show and
tell to QA and TW) and other devs
Hello Peter,
At my current company we do both peer reviews and group code reviews.
The group code reviews seem to have the best impact, as the peer reviews
have naturally ceased to happen.
Our group code reviews happen bi-monthly and during the time (usually an
hour) developers working on dif
Looking to get some views (and best practices) on code reviews. I used to
work at IBM on their early version of Websphere (as UI designer, not coder)
where our group had code reviews on a regular basis. I'm now managing a
small dev team working on a new web site using Zend PHP/MySql and am curiou
