Re: [OSM-talk] landuse=reservoir vs water=reservoir

2019-06-29 Thread Andy Townsend
Usually I'm the one wringing my hands and plaintively saying "won't someone 
think of the data consumers?".  In this case though anyone who's not looking 
for "natural=water; water=blah" (as well as any other options) really is doing 
it wrong - people have been using that scheme for years.

Best Regards,

Andy

___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] landuse=reservoir vs water=reservoir

2019-06-29 Thread Tomas Straupis
2019-06-29, št, 18:30 Mateusz Konieczny rašė:
>> How many maps, analysis, QA routines, presentations, documentations
>> have you created to come up with such a claim?
>
> To make such claim it is enough to look at tag statistics, history of usage
> and note that water=reservoir is generally not tagged with landuse=reservoir

  If you would have created the things I've listed above (which
consume OSM data), you would understand why I'm so opposed to random
shuffling of tags without a good reason.

  Tagging in OSM is something like an "API" to data and usually
serious organisations/companies are very strict about changes in API,
and breaking changes are only done if really really really necessary.

-- 
Tomas

___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] landuse=reservoir vs water=reservoir

2019-06-29 Thread Mateusz Konieczny
29 Jun 2019, 15:42 by tomasstrau...@gmail.com:

> 2019-06-29, št, 15:53 Mateusz Konieczny rašė:
>
>>> Don't change/brake stuff that works.
>>>
>> Software supporting only landuse=reservoir or only water=reservoir for
>> detecting reservoirs is already broken and was broken for a long time.
>>
>
> How many maps, analysis, QA routines, presentations, documentations
> have you created to come up with such a claim?
>
To make such claim it is enough to look at tag statistics, history of usage 
and note that water=reservoir is generally not tagged with landuse=reservoir

I am not sure why you are even asking, you are aware about this:

>  This discussion should have been done looong time ago when new water
> scheme was introduced, then damage was not this large
>
(though I would not describe it as damage)

29 Jun 2019, 15:42 by tomasstrau...@gmail.com:

> How many maps, analysis, QA routines, presentations, documentations
> have you created to come up with such a claim?
>
Feel free to check JOSM bugtracker, Github and OSM Wiki to see sample of
public contributions. I use usernames "matkoniecz" and "Mateusz Konieczny".
___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] landuse=reservoir vs water=reservoir

2019-06-29 Thread Yves
Don't worry about data consumers, they have a long habit of using concurrent 
tagging schemes and make extensive use of 'OR'.
Yves 
___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] landuse=reservoir vs water=reservoir

2019-06-29 Thread Tomas Straupis
2019-06-29, št, 15:53 Mateusz Konieczny rašė:
>> Don't change/brake stuff that works.
> Software supporting only landuse=reservoir or only water=reservoir for
> detecting reservoirs is already broken and was broken for a long time.

  How many maps, analysis, QA routines, presentations, documentations
have you created to come up with such a claim?

  This discussion should have been done looong time ago when new water
scheme was introduced, then damage was not this large :-( We're
pointlessly arguing about names of tags when other GIS use simple
codes like gk11 gk12 gk13 for classification with an explanatory table
attached and have no problem with that, because values are more
STABLE.

-- 
Tomas

___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] landuse=reservoir vs water=reservoir

2019-06-29 Thread Mateusz Konieczny
29 Jun 2019, 14:08 by tomasstrau...@gmail.com:

>> (1) most of lead of landuse=reservoir for areas is a result of a bot edit, 
>> maybe an import
>>
>
> How do you know that?
>
See spike in the orange line on the left.

>> (2) since 2016 water=reservoir is growing much faster than landuse=reservoir
>>
>
> Remove "iD effect" and what will we get?
>
Not sure, I mentioned that proper analysis would be valuable.

>> Are you manually checking every single part of such edits? Otherwise you
>>
>> are making automated edits in violation of automatic edits code of conduct.
>>
>
> I'm doing QA in Lithuania for more than ten years and then doing
> appropriate action: fixing, informing, educating, updating.
>
I am not sure what is your method used for mass reverts that you mentioned but 
automatic edits code of conduct still applies to you.

See https://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct 


>  Don't change/brake stuff that works.
>
Software supporting only landuse=reservoir or only water=reservoir for
detecting reservoirs is already broken and was broken for a long time.
___
talk mailing list
talk@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk