Re: [tboot-devel] [PATCH] Check for VMX support before reading feature control MSR

2016-05-10 Thread Sun, Ning
> Is this the only supported hardware to run tboot ? I thought it's expected to > just run like a regular bootloader if it was not able to use txt. Yes, tboot is for Intel TXT platform. > I believe the impact is low for real hardware. The way this would happen on > real hardware would be to run

Re: [tboot-devel] [PATCH] Check for VMX support before reading feature control MSR

2016-05-10 Thread Sun, Ning
Was there any failure caused by reading this MSR when you run current tboot on a bare-metal machine TXT enabled machine? Or you just found this issue when running tboot in KVM guest? This is very helpful for us to identify the impact of this issue. -Original Message- From: Bandan Das [

Re: [tboot-devel] [PATCH] Check for VMX support before reading feature control MSR

2016-05-10 Thread Sun, Ning
Tboot should run on bare-metal TXT enabled platform, it is not supposed to run in a virtual machine environment. -ning -Original Message- From: Bandan Das [mailto:b...@redhat.com] Sent: Tuesday, May 10, 2016 12:24 PM To: Sun, Ning Cc: Tony Camuso ; tboot-devel@lists.sourceforge.net Sub

Re: [tboot-devel] [PATCH] Check for VMX support before reading feature control MSR

2016-05-10 Thread Sun, Ning
> BTW, table 35-2 in the spec says the msr is present if cpuid.01h.ecx(bit 5 or > 6) is 1. I think we should check for both vmx and smx before trying the read ? "msr is present if cpuid.01h.ecx(bit 5 or 6) is 1" , that means you can check one of those bits to determine presence of the MSR. As yo

Re: [tboot-devel] [PATCH] Check for VMX support before reading feature control MSR

2016-05-10 Thread Tony Camuso
On 05/10/2016 09:58 AM, Sun, Ning wrote: > > > We got similar tboot log as yours, this was a failure in creating a trusted > environment. > Please try my patch for your reported issue, which was tested pass on our > machines. Thanks, Ning. You are correct. I was unable to set a successful polic

Re: [tboot-devel] [PATCH] Check for VMX support before reading feature control MSR

2016-05-10 Thread Sun, Ning
We got similar tboot log as yours, this was a failure in creating a trusted environment. Please try my patch for your reported issue, which was tested pass on our machines. > On May 10, 2016, at 6:14 AM, Tony Camuso wrote: > >> On 05/09/2016 07:51 PM, Sun, Ning wrote: >> BanDan, Tony, >> >>

Re: [tboot-devel] [PATCH] Check for VMX support before reading feature control MSR

2016-05-10 Thread Tony Camuso
On 05/09/2016 07:51 PM, Sun, Ning wrote: > BanDan, Tony, > > We tried out your patch, unfortunately it did not work on our > machines, did you test your patch before submitting it?> > -ning Yes, I did test it, and I just tested it again, on bare metal and on the virtual guest. Below is what I g