Re: [tcpdump-workers] print-bootp.c: better client fqdn option printing

2007-01-29 Thread Guy Harris
Kevin Steves wrote: I started looking at this because the minimum length check was off by one. 0) fix off by one (4 vs. 3) 1) print flag bits 2) print rcode fields if either is non-zero Checked into the main and x.9 branches. - This is the tcpdump-workers list. Visit https://cod.sandelman.ca/

Re: [tcpdump-workers] [PATCH] [REPOST] enforce host byte order on

2007-01-29 Thread Guy Harris
Abeni Paolo wrote: The patch contained in the previous post does conatain an offset error while accessing the linux usb header struct. The one attached here should fix the issue. Please give it a review, since this sort of thing is a bit tricky. Checked in. I was tempted by implementing and

Re: [tcpdump-workers] print-tcp.c: remove commas from output, to be consistent

2007-01-29 Thread Hannes Gredler
On Sun, Jan 28, 2007 at 10:54:44AM -0800, Kevin Steves wrote: | On Thu, Jan 18, 2007 at 08:36:34AM +0100, Hannes Gredler wrote: | : well the correct thing would then be: | : | : 1. embrace .SFP into Flags [.SPF], | : 2. add commas to sep. the rest of the field | | I don't see commas (in general)