Re: [tcpdump-workers] [Patch] fad-win32.c

2013-04-04 Thread Gisle Vanem
"Guy Harris" wrote: 'NameLength = 0' is just in case 'PacketGetAdapterNames()' fails w/o setting '*NameLength == 0'. It really could do that; ref. Packet32.c in WinPcap. Really? I don't see that. (The first call should *always* "fail", in the sense of returning FALSE; if the cause of the

Re: [tcpdump-workers] [Patch] fad-win32.c

2013-04-04 Thread Guy Harris
On Apr 4, 2013, at 1:20 AM, Gisle Vanem wrote: > This is a similar patch to the change of pcap-dos.c: > https://github.com/mcr/libpcap/commit/73b5f0387199fbaa75130837b931faf770471640 > > I.e. the '_interfaces' suffix got lost in some other change to the puplic API. > (I don't know when). Since

[tcpdump-workers] [Patch] fad-win32.c

2013-04-04 Thread Gisle Vanem
This is a similar patch to the change of pcap-dos.c: https://github.com/mcr/libpcap/commit/73b5f0387199fbaa75130837b931faf770471640 I.e. the '_interfaces' suffix got lost in some other change to the puplic API. (I don't know when). Since 'pcap_findalldevs()' is now a more generic version in pca