Re: [tcpdump-workers] Linktype allocation for ATSC link layer protocol

2020-03-20 Thread Guy Harris via tcpdump-workers
--- Begin Message --- On Mar 20, 2020, at 2:39 PM, Nick Kelsey via tcpdump-workers wrote: > Pull request created (#919): > > https://github.com/the-tcpdump-group/libpcap/pull/919 I've added a proposed description as a comment to the pull request; please check whether my assumptions are

Re: [tcpdump-workers] [the-tcpdump-group/libpcap] Use tab instead of space in formatting pcap-int.h (#918)

2020-03-20 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 19/03/2020 22:11, Michael Richardson via tcpdump-workers wrote: > I will submit a whitespace change to master next week, and then a modeline > fix. > Are there any integrations to github that will warn people to fix their > whitespace settings? Could you explain the

Re: [tcpdump-workers] Linktype allocation for ATSC link layer protocol

2020-03-20 Thread Nick Kelsey via tcpdump-workers
--- Begin Message --- On 3/20/2020 11:17 AM, Michael Richardson wrote: > > Nick Kelsey via tcpdump-workers wrote: > > After going to interop/test events and discussions with other engineers in > > the field it looks like a lot of the junk in the ATSC ALP protocol will never > >

Re: [tcpdump-workers] Linktype allocation for ATSC link layer protocol

2020-03-20 Thread Nick Kelsey via tcpdump-workers
--- Begin Message --- After going to interop/test events and discussions with other engineers in the field it looks like a lot of the junk in the ATSC ALP protocol will never be used and can be ignored. The protocol is defined in the ATSC A/330 standard. Proposed implementation: 1) Check the

Re: [tcpdump-workers] [the-tcpdump-group/libpcap] Use tab instead of space in formatting pcap-int.h (#918)

2020-03-20 Thread Michael Richardson via tcpdump-workers
--- Begin Message --- Francois-Xavier Le Bail via tcpdump-workers wrote: >> In a github ticket, #918. > I don't see the message starting this conversation in #918, nor the > following ones. Could you push > them in the list? #918 fixes a space->tab, I think. I took it directly to

Re: [tcpdump-workers] [the-tcpdump-group/libpcap] Use tab instead of space in formatting pcap-int.h (#918)

2020-03-20 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 20/03/2020 16:16, Michael Richardson wrote: > Francois-Xavier Le Bail wrote: > >> > If we do, we should replace all the tabs in pcap-int.h with spaces; > we > >> > should at least be consistent, and change #918 fixed one inconsistent > >> > case. > >> >

Re: [tcpdump-workers] [the-tcpdump-group/libpcap] Use tab instead of space in formatting pcap-int.h (#918)

2020-03-20 Thread Michael Richardson via tcpdump-workers
--- Begin Message --- Francois-Xavier Le Bail wrote: >> > If we do, we should replace all the tabs in pcap-int.h with spaces; we >> > should at least be consistent, and change #918 fixed one inconsistent >> > case. >> >> Let's agree that we are going towards spaces. >> I

Re: [tcpdump-workers] [the-tcpdump-group/libpcap] Use tab instead of space in formatting pcap-int.h (#918)

2020-03-20 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 19/03/2020 22:11, Michael Richardson via tcpdump-workers wrote: > >> I thought we wanted all spaces? > > > If we do, we should replace all the tabs in pcap-int.h with spaces; we > > should at least be consistent, and change #918 fixed one inconsistent > >