Re: [tcpdump-workers] [Patch] pcap-dos.c

2013-03-28 Thread Guy Harris
On Mar 28, 2013, at 5:53 AM, Gisle Vanem wrote: > This file has fallen behind since pcap_create() was put in > pcap.c long time ago (a more generic create-function). Hence: Checked into the trunk and the 1.4 branch. ___ tcpdump-workers mailing list t

[tcpdump-workers] [Patch] pcap-dos.c

2013-03-28 Thread Gisle Vanem
This file has fallen behind since pcap_create() was put in pcap.c long time ago (a more generic create-function). Hence: --- Git-Latest\pcap-dos.c Wed Nov 28 23:41:44 2012 +++ pcap-dos.c Thu Nov 29 00:00:12 2012 @@ -143,7 +143,7 @@ return handle_to_device [fd-1]; } -pcap_t *pcap_create

Re: [tcpdump-workers] [Patch] pcap-dos.c

2008-04-25 Thread Gisle Vanem
"Guy Harris" <[EMAIL PROTECTED]> wrote: So what *is* this case? The error message is "Cannot use different devices simultaneously"; does that mean that you can have multiple instances of the same device open at the same time, but you can't have instances of more than one device open at the sa

Re: [tcpdump-workers] [Patch] pcap-dos.c

2008-04-25 Thread Guy Harris
Guy Harris wrote: Gisle Vanem wrote: Ok, but I reckoned PCAP_ERROR was too vague. I'm not sure what errorcode would cover this case. Perhaps we should add a new error code. So what *is* this case? The error message is "Cannot use different devices simultaneously"; does that mean that you

Re: [tcpdump-workers] [Patch] pcap-dos.c

2008-04-22 Thread Guy Harris
Gisle Vanem wrote: Two more details: Checked in. - This is the tcpdump-workers list. Visit https://cod.sandelman.ca/ to unsubscribe.

Re: [tcpdump-workers] [Patch] pcap-dos.c

2008-04-22 Thread Gisle Vanem
Two more details: --- pcap-dos.c.orig Sat Apr 19 16:49:21 2008 +++ pcap-dos.cTue Apr 22 17:50:52 2008 @@ -1,6 +1,6 @@ /* * This file is part of DOS-libpcap - * Ported to DOS/DOSX by G. Vanem <[EMAIL PROTECTED]> + * Ported to DOS/DOSX by G. Vanem <[EMAIL PROTECTED]> * * pcap-dos.c:

Re: [tcpdump-workers] [Patch] pcap-dos.c

2008-04-19 Thread Guy Harris
Gisle Vanem wrote: Ok, but I reckoned PCAP_ERROR was too vague. I'm not sure what errorcode would cover this case. Perhaps we should add a new error code. - This is the tcpdump-workers list. Visit https://cod.sandelman.ca/ to unsubscribe.

Re: [tcpdump-workers] [Patch] pcap-dos.c

2008-04-19 Thread Gisle Vanem
"Guy Harris" <[EMAIL PROTECTED]> wrote: @@ -201,7 +202,7 @@ "Cannot use different devices simultaneously " "(`%s' vs. `%s')", active_dev->name, pcap->md.device); free (pcap); -err = PCAP_ERROR; +err = PCAP_ERROR_ACTIVATED; PCAP_ERROR_ACTIVATED means you'

Re: [tcpdump-workers] [Patch] pcap-dos.c

2008-04-19 Thread Guy Harris
Gisle Vanem wrote: The recent change for pcap_activate() broke the DOS-port. Here's a small fix: Checked into the main and 1.0 branches, along with some changes and other fixes. p->activate_op = pcap_activate_dos; + p->md.device = device; I just changed it to use opt.device r

[tcpdump-workers] [Patch] pcap-dos.c

2008-04-19 Thread Gisle Vanem
The recent change for pcap_activate() broke the DOS-port. Here's a small fix: --- pcap-dos.c.orig Mon Apr 14 19:40:58 2008 +++ pcap-doc.cThu Apr 17 15:33:00 2008 @@ -97,10 +97,10 @@ static struct device *handle_to_device [20]; -static void pcap_activate_dos (pcap_t *p); +static int pc