Re: [clearview-discuss] [tcpdump-workers] libdlpi with libpcap

2008-02-01 Thread Sebastien Roy
sagun shakya wrote: I've addressed all the comments from below and updated the webrev. http://cr.opensolaris.org/~sagun/libpcap/ While testing the changes I found out that my changes didn't work on a Solaris system that had libdlpi.h version that existed before the public libdlpi.h was integra

Re: [clearview-discuss] [tcpdump-workers] libdlpi with libpcap

2008-02-11 Thread Sebastien Roy
sagun shakya wrote: Sebastien Roy wrote: Thanks Sagun; do you have a webrev that diffs against your previous updates? Sorry, I hadn't generated the webrev. Here are the diffs against my previous updates. http://cr.opensolaris.org/~sagun/webrev-seb-comments/ The webrev against the li

Re: [clearview-discuss] [tcpdump-workers] libdlpi with libpcap

2008-02-11 Thread Sebastien Roy
sagun shakya wrote: Hi Seb and Guy, I've generated a new webrev that incorporates your comments. The webrev can be found at: http://cr.opensolaris.org/~sagun/libpcap-review2/ Thanks Sagun; do you have a webrev that diffs against your previous updates? -Seb - This is the tcpdump-workers lis

Re: [clearview-discuss] [tcpdump-workers] libdlpi with libpcap

2008-02-14 Thread Sebastien Roy
sagun shakya wrote: sagun shakya wrote: Sebastien Roy wrote: pcap-int.h: * 71-98: These only apply when compiling with DLPI support. Perhaps Guy can answer this: Should there be some sort of #ifdef to make sure that these symbols don't pollute the namespace when compiled on

Re: [clearview-discuss] [tcpdump-workers] libdlpi with libpcap

2008-02-14 Thread Sebastien Roy
sagun shakya wrote: Sebastien Roy wrote: sagun shakya wrote: pcap-int.h: * 71-98: These only apply when compiling with DLPI support. Perhaps Guy can answer this: Should there be some sort of #ifdef to make sure that these symbols don't pollute the namespace when compiled on

[tcpdump-workers] pcap-libdlpi.c doesn't compile in version 1.0.0

2009-01-23 Thread Sebastien Roy
Hi Folks, I've downloaded libpcap 1.0.0 and am attempting to compile it on OpenSolaris build 105. There are a number of problems in the pcap-libdlpi.c file: gcc -O2 -I. -DHAVE_CONFIG_H -D_U_="__attribute__((unused))" -c ./pcap-libdlpi.c ./pcap-libdlpi.c: In function `pcap_activate_libdlpi': .

Re: [tcpdump-workers] pcap-libdlpi.c doesn't compile in version 1.0.0

2009-02-06 Thread Sebastien Roy
Any input on the OpenSolaris issues I pointed out a few weeks back? Again, I have a fix that i can provide, but as I haven't contributed code to libpcap before, a quick primmer on what your process is would help me out. Thanks, -Seb On Fri, 2009-01-23 at 13:47 -0500, Sebastien Roy wrote:

Re: [tcpdump-workers] pcap-libdlpi.c doesn't compile in version 1.0.0

2009-02-17 Thread Sebastien Roy
On Sat, 2009-02-14 at 14:44 -0800, Guy Harris wrote: > On Feb 6, 2009, at 7:32 AM, Sebastien Roy wrote: > > > Any input on the OpenSolaris issues I pointed out a few weeks back? > > Again, I have a fix that i can provide, but as I haven't contributed > > code to li

Re: [tcpdump-workers] Extra DLT types required for opensolaris DLPI DL

2009-03-27 Thread Sebastien Roy
Hi Darren, On Fri, 2009-03-27 at 10:58 -0700, Darren Reed wrote: > Additionally, I'm considering creating a new datalink type for loopback > packets on OpenSolaris. The contents would be something like: > version (16 bits: 1) > protocol family (16 bits: AF_INET, AF_INET6) > capture point (32bits

Re: [tcpdump-workers] Extra DLT types required for opensolaris DLPI DL

2009-03-27 Thread Sebastien Roy
On Fri, 2009-03-27 at 19:42 -0700, Guy Harris wrote: > On Mar 27, 2009, at 7:01 PM, Sebastien Roy wrote: > > > The only hitch is that DL_IPNET devices behave like DLT_RAW by > > default. > > The DL_IOC_IPNET_INFO ioctl enables the inclusion of the "ipnet" >

Re: [tcpdump-workers] Extra DLT types required for opensolaris DLPI DL

2009-03-30 Thread Sebastien Roy
On Sun, 2009-03-29 at 22:59 -0700, Darren Reed wrote: > On 27/03/09 07:01 PM, Sebastien Roy wrote: > > There is already a datalink type associated with loopback (/dev/lo0), > > DL_IPNET, and the header is described in the lo0(7D) man page. It's > > versioned, so it wou

Re: [tcpdump-workers] Extra DLT types required for opensolaris DLPI DL

2009-03-30 Thread Sebastien Roy
On Sun, 2009-03-29 at 23:11 -0700, Guy Harris wrote: > On Mar 29, 2009, at 10:59 PM, Darren Reed wrote: > > > What I am considering is: > > And what Sebastien is suggesting is, I think: > > using the DL_IPNET link-layer header for loopback devices, as > documented in the loopback device

Re: [tcpdump-workers] IP Header Size is always 5

2009-04-01 Thread Sebastien Roy
On Wed, 2009-04-01 at 20:42 +0530, Shameem Ahamed wrote: > I was trying to create a function (for testing purpose) which displays > the header information for Ethernet, IP and TCP using a Linux machine. > The problem i am having is, whenever i read any packet from the saved > pcap file, it displays

Re: [tcpdump-workers] libpcap: patches required for OpenSolaris/SXCE

2009-12-01 Thread Sebastien Roy
On Tue, 2009-12-01 at 00:47 -0800, Guy Harris wrote: > On Nov 30, 2009, at 5:30 AM, Darren Reed wrote: > > # dladm show-link > > LINKCLASS MTUSTATEBRIDGE OVER > > igb0phys 1500 up -- -- > > e1000g0 phys 1500 up -- -- > >

Re: [tcpdump-workers] libpcap: patches required for OpenSolaris/SXCE

2009-12-01 Thread Sebastien Roy
On Wed, 2009-12-02 at 13:18 +1100, Darren Reed wrote: > Guy Harris wrote: > > > > On Dec 1, 2009, at 4:10 PM, Darren Reed wrote: > > > >> Use of libdladm is going to be required. > > > > Required for what? Enumerating capture interfaces? > > On Solaris, yes. This is a [Open]Solaris problem becaus

Re: [tcpdump-workers] libpcap: patches required for OpenSolaris/SXCE

2009-12-01 Thread Sebastien Roy
On Tue, 2009-12-01 at 18:48 -0800, Guy Harris wrote: > On Dec 1, 2009, at 6:37 AM, Sebastien Roy wrote: > > > I would argue that it's a bug on Solaris that libpcap depends on > > IP-layer information to choose a capture interface (if that is in fact > > what it does)

Re: [tcpdump-workers] Inefficiency in BPF code for DLT_RAW

2010-01-04 Thread Sebastien Roy
On Wed, 2009-12-23 at 18:09 -0800, Guy Harris wrote: > On Dec 23, 2009, at 2:01 AM, Darren Reed wrote: > > > The links that support the IP tunnels are a fixed type, be > > it IPv4 or IPv6, and are reported as being DLT_RAW because > > there is no real layer 2 header present. > > ... > > >