Re: [teampractices] Code review social norms

(quick response) Given this is going to impact our use of Phabricator (if we maintain a local fork of arcanist or not), could reasoned replies be shared with upstream/Evan? Thanks :) Greg > On 03/14/2016 03:40 PM, James Forrester wrote: > >On 14 March 2016 at 19:15, Greg Grossmeier

Re: [teampractices] Code review social norms

On 03/14/2016 03:40 PM, James Forrester wrote: On 14 March 2016 at 19:15, Greg Grossmeier >wrote: (CC'ing Matt F who lead the "Make code review not suck" session at WikiDev16, not sure if his on the list or not.) Related to the other

Re: [teampractices] Code review social norms

> (CC'ing Matt F who lead the "Make code review not suck" session at > WikiDev16, not sure if his on the list or not.) Gah, it was Brian not Matt. Apologies. Correcting CC. Brian, see below: > Related to the other code-review for WMF teams discussion I'd like to > pass along some feedback from

[teampractices] Code review social norms

(CC'ing Matt F who lead the "Make code review not suck" session at WikiDev16, not sure if his on the list or not.) Related to the other code-review for WMF teams discussion I'd like to pass along some feedback from Evan Priestley (the Phabricator lead dev) on how we currently do code-review in