Re: [teampractices] Code review social norms

2016-03-14 Thread Greg Grossmeier
(quick response) Given this is going to impact our use of Phabricator (if we maintain a local fork of arcanist or not), could reasoned replies be shared with upstream/Evan? Thanks :) Greg > On 03/14/2016 03:40 PM, James Forrester wrote: > >On 14 March 2016 at 19:15, Greg Grossmeier >

Re: [teampractices] Code review social norms

2016-03-14 Thread Subramanya Sastry
On 03/14/2016 03:40 PM, James Forrester wrote: On 14 March 2016 at 19:15, Greg Grossmeier >wrote: (CC'ing Matt F who lead the "Make code review not suck" session at WikiDev16, not sure if his on the list or not.) Related to the other code-review for WMF te

Re: [teampractices] Code review social norms

2016-03-14 Thread Alex Monk
It's interesting, but I'm struggling to figure out how Wikimedia fits in here. He does quite a bit of talking about 'New hires' etc., and 'I am concerned about building features that make the "Open Source Contributor / Intern" case a little better but gut the principles of equality, ownership and a

Re: [teampractices] Code review social norms

2016-03-14 Thread James Forrester
On 14 March 2016 at 19:15, Greg Grossmeier wrote: > (CC'ing Matt F who lead the "Make code review not suck" session at > WikiDev16, not sure if his on the list or not.) > > Related to the other code-review for WMF teams discussion I'd like to > pass along some feedback from Evan Priestley (the Ph

Re: [teampractices] Code review social norms

2016-03-14 Thread Greg Grossmeier
> (CC'ing Matt F who lead the "Make code review not suck" session at > WikiDev16, not sure if his on the list or not.) Gah, it was Brian not Matt. Apologies. Correcting CC. Brian, see below: > Related to the other code-review for WMF teams discussion I'd like to > pass along some feedback from

[teampractices] Code review social norms

2016-03-14 Thread Greg Grossmeier
(CC'ing Matt F who lead the "Make code review not suck" session at WikiDev16, not sure if his on the list or not.) Related to the other code-review for WMF teams discussion I'd like to pass along some feedback from Evan Priestley (the Phabricator lead dev) on how we currently do code-review in Ger

Re: [teampractices] Patch review culture of Wikimedia teams

2016-03-14 Thread Andre Klapper
Thanks everybody for the comments! However I'm still curious if this is part of the TPG scope, hence I'd welcome a reply from TPG members. Thanks, andre On Mon, 2016-03-07 at 14:16 +0100, Andre Klapper wrote: > https://phabricator.wikimedia.org/T101686 lists "Prioritization / weak > open source c