Re: [patch] ssh: null pointer dereference

2010-04-10 Thread Damien Miller
On Sat, 27 Mar 2010, Matthew Haub wrote: Hello, If channel_by_id() in mux_master_control_cleanup_cb() fails to find the session channel then pointer sc will be NULL when dereferenced. Applied - thanks. This case shouldn't happen, if you are able to hit this code then please tell me how you

Re: disklabel - 'P' option

2010-04-10 Thread Mark Lumsden
This diff includes the 'P' option in the manpage and interactive helptext. The install floppys are here: http://www.cyodesigns.com/diffs/floppy47.fs http://www.cyodesigns.com/diffs/floppyB47.fs http://www.cyodesigns.com/diffs/floppyC47.fs If you take one for a spin, could you let me know pls.

Re: [patch] ssh: null pointer dereference

2010-04-10 Thread Matthew Haub
Hello, On Sat, Apr 10, 2010 at 03:49:07PM +1000, Damien Miller wrote: Applied - thanks. This case shouldn't happen, if you are able to hit this code then please tell me how you do it :| I haven't hit this code, it was just something suspicious that I found. I've been looking for bugs to fix

bge(4) diff needs testing.

2010-04-10 Thread Brad
Please test the following diff with any bge(4) adapters. Just checking to ensure no regressions with known working adapters. Just check that things are working as usual. Just bringing in some fixes for some of the newer chipsets soon to appear. Nothing changed with existing chipsets though.

ifconfig.8 trunk section

2010-04-10 Thread Ted Unangst
Quite a bit of redundant text here, this makes it cleaner I think. Index: ifconfig.8 === RCS file: /home/tedu/cvs/src/sbin/ifconfig/ifconfig.8,v retrieving revision 1.192 diff -u -r1.192 ifconfig.8 --- ifconfig.8 23 Nov 2009

[patch] ldp ldpctl implicit null

2010-04-10 Thread Thomas Habets
Hi. I played around a bit with ospfd and ldpd against real cisco routers, and noticed some strange things. ldpctl -- First of all I saw that the output from ldpctl show lib and lfib showed label 3 instead of the well-known implicit null. I've patched ldpctl to show what I think is more

systrace vs realapth

2010-04-10 Thread Ted Unangst
systrace uses realpath to find the files it wants to allow/deny. But in doing so, it changes the filenames, sometimes creating valid names out of invalid names. In particular, realpath strips trailing slashes, and some syscalls aren't supposed to work on such filenames. When using systrace,

re(4) diff needs testing.

2010-04-10 Thread Brad
Please test the following diff with any re(4) adapters. This is an adaption of some code from FreeBSD to help with identification of certain chipsets. Just make sure the driver still attaches Ok. There should be no change with the dmesg info printed. Let me know if there is. Please provide me

Re: ifconfig.8 trunk section

2010-04-10 Thread Jason McIntyre
On Sat, Apr 10, 2010 at 02:54:22PM -0400, Ted Unangst wrote: Quite a bit of redundant text here, this makes it cleaner I think. this looks like a good improvement to me. unfortunately a huge number of subsections in this page use that exact syntax, so any diff should address this for the