Re: IP Routing Fix

2012-06-25 Thread Claudio Jeker
On Fri, Jun 22, 2012 at 12:03:41PM +0200, Gerhard Roth wrote: > Hi everybody, > > there is code in ether_output() that handles the case that we have to > use a gateway to send the packet. This code does a lookup for the route > required to reach the gateway. > > In case there is a gateway for whi

Re: setsockopt SO_SNDBUF and limit (No buffer space available)

2012-06-25 Thread Claudio Jeker
looking at sbcheckreserve and sbchecklowmem in > src/sys/kern/uipc_socket2.c. > > What does sbchecklowmem() return if between the two limits? (Can that > condition occur?) > > My vmstat -m output is at > http://git.bind10.isc.org/~jreed/vmstat.out.20120625.txt > >

setsockopt SO_SNDBUF and limit (No buffer space available)

2012-06-25 Thread Jeremy C. Reed
uipc_socket2.c. What does sbchecklowmem() return if between the two limits? (Can that condition occur?) My vmstat -m output is at http://git.bind10.isc.org/~jreed/vmstat.out.20120625.txt Do you have any suggestions on how to troubleshoot this further? The system as of now has not been rebooted,

Re: unsigned >= 0 comparisons

2012-06-25 Thread Arto Jonsson
On Mon, Jun 25, 2012 at 01:47:18PM -0600, Theo de Raadt wrote: > Like, who cares about about commit id's. > > Projects are just people working together. A project didn't come up > with that diff. A person did. > > When we say where something came from, we do it by giving credit, not > by refere

Re: unsigned >= 0 comparisons

2012-06-25 Thread Theo de Raadt
> On Mon, Jun 25, 2012 at 03:12:52PM -0400, Ted Unangst wrote: > > This is a little meta, but if we're going to start pulling changes from > > bitrig, I don't think "commit 171e1f9d" is the attribution style we > > should use. > > It seems that that the branch I took these from is rebased and thus

Re: unsigned >= 0 comparisons

2012-06-25 Thread Arto Jonsson
On Mon, Jun 25, 2012 at 03:12:52PM -0400, Ted Unangst wrote: > This is a little meta, but if we're going to start pulling changes from > bitrig, I don't think "commit 171e1f9d" is the attribution style we > should use. It seems that that the branch I took these from is rebased and thus the commit

Re: unsigned >= 0 comparisons

2012-06-25 Thread Ted Unangst
On Mon, Jun 25, 2012 at 20:54, Arto Jonsson wrote: > Hi, > > a couple of >= 0 comparisons on unsigned integers. These refer to Bitrig > commits 171e1f9d and 72337965 respectively. This is a little meta, but if we're going to start pulling changes from bitrig, I don't think "commit 171e1f9d" is th

Re: unsigned >= 0 comparisons

2012-06-25 Thread Arto Jonsson
On Mon, Jun 25, 2012 at 07:23:44PM +0100, Nigel Taylor wrote: > In place of > else if (powerlevel >= 30 && powerlevel < 60) > could use > else if (powerlevel < 60) > Thanks. Updated patch below. Index: sys/arch/amd64/amd64/machdep.c ===

Re: unsigned >= 0 comparisons

2012-06-25 Thread Nigel Taylor
On 06/25/12 18:54, Arto Jonsson wrote: > Hi, > > a couple of >= 0 comparisons on unsigned integers. These refer to Bitrig > commits 171e1f9d and 72337965 respectively. > > Index: sys/arch/amd64/amd64/machdep.c > === > RCS file: /cvs/

unsigned >= 0 comparisons

2012-06-25 Thread Arto Jonsson
Hi, a couple of >= 0 comparisons on unsigned integers. These refer to Bitrig commits 171e1f9d and 72337965 respectively. Index: sys/arch/amd64/amd64/machdep.c === RCS file: /cvs/src/sys/arch/amd64/amd64/machdep.c,v retrieving revisio

mkdep(1) misses compilation errors

2012-06-25 Thread Gerhard Roth
Hi, the exit status of a shell pipeline is the exit status of the last command in the pipeline. Since mkdep(1) pipes the output of ${CC} into sed(1), the following check of '$?' checks the exit status of sed(1) and not the of of cc(1). This is nasty if some modification broke the compilation of

Re: nc -ul semantics

2012-06-25 Thread Lazaros Koromilas
On Sun, Jun 24, 2012 at 11:23:05PM +0200, Ariane van der Steldt wrote: > On Mon, Jun 25, 2012 at 12:09:33AM +0300, dsp wrote: > > We observe the following behaviour when running nc -ul. > > The server begins on a recvfrom() and when data arrives it > > connects() the socket. > > When the client die