Re: Miscellaneous LibreSSL portability fixes

2014-07-17 Thread Jan Engelhardt
On Thursday 2014-07-17 00:02, Jonas 'Sortie' Termansen wrote: I ported libressl to my custom hobby OS and it has been a pleasant experience. Nonetheless, I did run into some minor portability problems that I wish to share: * apps/Makefile.am.tpl links libcrypto and libssl in the wrong order.

Re: usr.bin/man: use getlist(char *) instead of hand-rolled equivalent in config(char *)

2014-07-17 Thread Ingo Schwarze
Hi, Kent R. Spillner wrote on Wed, Jun 04, 2014 at 10:01:12AM -0500: config(char *) contains a hand-rolled version of getlist(char *). Indeed. The only difference is that the hand-rolled version includes a NULL check before the strcmp. You misread the code. There is no NULL check for the

don't include CFLAGS in CXXFLAGS

2014-07-17 Thread Jonathan Gray
sys.mk automatically gets included by make(1) and sets CXXFLAGS to CFLAGS. If a Makefile defines additional CFLAGS they will then be passed to the C++ compiler. Which creates problems with flags that should only be used by the C compiler in Makefiles that deal with both C and C++ (like Mesa).

Re: don't include CFLAGS in CXXFLAGS

2014-07-17 Thread Stuart Henderson
On 2014/07/18 00:10, Jonathan Gray wrote: sys.mk automatically gets included by make(1) and sets CXXFLAGS to CFLAGS. If a Makefile defines additional CFLAGS they will then be passed to the C++ compiler. Which creates problems with flags that should only be used by the C compiler in Makefiles

Re: Miscellaneous LibreSSL portability fixes

2014-07-17 Thread Steven Chamberlain
On 17/07/14 04:26, Bob Beck wrote: Steve, sorry, but GNU/kFreeBSD is not going to happen right now. We are too busy with other things. I understand, actually I wasn't asking for that. I think having lots of platform-specific implementations would be unclean, I was only hoping the existing

Re: usr.bin/man: use getlist(char *) instead of hand-rolled equivalent in config(char *)

2014-07-17 Thread Kent R. Spillner
Thanks for the feedback, Ingo! Sorry for the confusion. I'll spend some more time with queue(3). :) On Jul 17, 2014, at 1:21, Ingo Schwarze schwa...@usta.de wrote: Hi, Kent R. Spillner wrote on Wed, Jun 04, 2014 at 10:01:12AM -0500: config(char *) contains a hand-rolled version of

Re: Miscellaneous LibreSSL portability fixes

2014-07-17 Thread Theo de Raadt
On 17/07/14 04:26, Bob Beck wrote: Steve, sorry, but GNU/kFreeBSD is not going to happen right now. We are too busy with other things. I understand, actually I wasn't asking for that. I think having lots of platform-specific implementations would be unclean, I was only hoping the existing

Re: Miscellaneous LibreSSL portability fixes

2014-07-17 Thread Jonas 'Sortie' Termansen
Thanks for the quick responses and convincing feedback. Mind my goal is not to become a supported platform - at all - but rather to lower the portability barrier where reasonable. I can easily patch around any other concerns locally. Brent: I'll email you the changes that there's agreement on so

Re: Miscellaneous LibreSSL portability fixes

2014-07-17 Thread Jan Engelhardt
On Thursday 2014-07-17 00:02, Jonas 'Sortie' Termansen wrote: * ioctl(FIONBIO) is used in a few files to make sockets non-blocking rather than using fcntl to set the the standard O_NONBLOCK bit. The files apps/s_client.c and apps/s_server.c should use BIO_socket_nbio() instead of directly

Re: Miscellaneous LibreSSL portability fixes

2014-07-17 Thread Jan Engelhardt
On Thursday 2014-07-17 00:02, Jonas 'Sortie' Termansen wrote: * The build system defaults --program-transform-name to the host triplet when cross-compiling. It shouldn't do that as the library doesn't have a target and is not a cross-compiler (as far as I know). It certainly doesn't make

Re: Miscellaneous LibreSSL portability fixes

2014-07-17 Thread Brent Cook
On Jul 17, 2014, at 1:39 PM, Jan Engelhardt jeng...@inai.de wrote: On Thursday 2014-07-17 00:02, Jonas 'Sortie' Termansen wrote: * The build system defaults --program-transform-name to the host triplet when cross-compiling. It shouldn't do that as the library doesn't have a target and is

Re: dump(8) manpage: files-to-dump can be duid

2014-07-17 Thread Jason McIntyre
On Tue, Jul 15, 2014 at 12:13:58AM +0200, Maximilian Fillinger wrote: Something I forgot about during the discussion about the diff for dump: The manpage doesn't mention yet that we can specify the duid on the command line now. fixed, thanks. jmc --- sbin/dump/dump.8.orig Mon Jul 14

Re: don't include CFLAGS in CXXFLAGS

2014-07-17 Thread Vadim Zhukov
2014-07-17 16:13 GMT+02:00 Stuart Henderson st...@openbsd.org: On 2014/07/18 00:10, Jonathan Gray wrote: sys.mk automatically gets included by make(1) and sets CXXFLAGS to CFLAGS. If a Makefile defines additional CFLAGS they will then be passed to the C++ compiler. Which creates problems

Drop accept_rtadv from installer

2014-07-17 Thread Christian Weisgerber
Since net.inet6.ip6.accept_rtadv is gone, the installer shouldn't set it. It is not obvious to me that enabling rediraccept is more important for IPv6 than for IPv4, where we keep is disabled by default. Do we want to kill that whole block? Index: install.sh

Re: lsearch.c

2014-07-17 Thread Matthew Dempsky
Hm, is there a practical consequence of this? Seems like it would only affect applications trying to store a reference to lsearch in a function pointer of type void (*)(const void *, void *, size_t *, size_t, int (*)(const void *, const void *)); do those exist? On Thu, Jul 17, 2014 at 5:38 PM,

Re: lsearch.c

2014-07-17 Thread Matthew Dempsky
Hrm. It seems silly to me to change it to require a non-const pointer argument, but POSIX, Linux, Solaris, FreeBSD, and NetBSD all use void *base so it doesn't seem like we should have any ports tree issues from changing it to be compatible either. On Thu, Jul 17, 2014 at 6:04 PM, enh

PATCH: fix open_memstream's regression test

2014-07-17 Thread Doug Hogan
Ran into this while running the regression suite for another patch. The regression test for open_memstream causes a SIGBUS because it closes the stream too early. Replaced fclose with fflush since they both update pbuf and psize. Added a similar check for fclose at the end. Index:

Re: lsearch.c

2014-07-17 Thread patrick keshishian
On 7/17/14, Matthew Dempsky matt...@dempsky.org wrote: Hrm. It seems silly to me to change it to require a non-const pointer argument, Silly even though, the description of lsearch says it will modify (it shall be added at the end of) the table, for which base argument points to the first

Re: lsearch.c

2014-07-17 Thread Matthew Dempsky
On Thu, Jul 17, 2014 at 8:05 PM, patrick keshishian pkesh...@gmail.com wrote: Silly even though, the description of lsearch says it will modify (it shall be added at the end of) the table, for which base argument points to the first element? Ah, I didn't pay close attention to the definition