Re: syslogd libevent handler

2014-09-03 Thread Doug Hogan
On Sun, Aug 31, 2014 at 10:46:50PM +0200, Alexander Bluhm wrote: > Move the handlers for the poll events into separate functions. They > will become the libevent callbacks later. ... > @@ -631,23 +606,65 @@ main(int argc, char *argv[]) > > for (i = 0; i < nfunix; i++) { >

Re: Refactoring process-local file descriptor data

2014-09-03 Thread Kent R. Spillner
Need to re-roll for -current? /usr/src/sys/kern/kern_descrip.c: In function 'dodup3': /usr/src/sys/kern/kern_descrip.c:312: error: 'struct filedesc' has no member named 'fd_ofileflags' cc -Werror -Wall -Wstrict-prototypes -Wmissing-prototypes -Wno-main -Wno-uninitialized -Wstack-larger-than-2

Re: minphys woes

2014-09-03 Thread Philip Guenther
On Wed, Sep 3, 2014 at 10:51 AM, Stefan Fritsch wrote: > On Tuesday 02 September 2014 15:22:16, Philip Guenther wrote: >> > From physio(9): >> > minphys >> > A device specific routine called to determine the >> >maximum transfer size that the device's strategy routine can >> >han

Re: splnet() and SIOCSIFADDR

2014-09-03 Thread Claudio Jeker
On Wed, Sep 03, 2014 at 03:25:34PM +0200, Martin Pieuchot wrote: > Drivers that need a splnet() protection inside their SIOCSIFADDR > generally raise the spl level themselves, so we should not need > to do that in in{6,}_ifinit(). One exception to this rule is, > as always, carp(4)... > > So the

Re: minphys woes

2014-09-03 Thread Claudio Jeker
On Wed, Sep 03, 2014 at 07:51:25PM +0200, Stefan Fritsch wrote: > On Tuesday 02 September 2014 15:22:16, Philip Guenther wrote: > > > From physio(9): > > > minphys > > > A device specific routine called to determine the > > >maximum transfer size that the device's strategy routine

Re: syslogd libevent handler

2014-09-03 Thread Alexander Bluhm
On Sun, Aug 31, 2014 at 10:46:50PM +0200, Alexander Bluhm wrote: > On Fri, Aug 29, 2014 at 11:25:52PM +0200, Alexander Bluhm wrote: > > I will try to pull parts of the diff into separate changes to > > make review easier. > > Move the handlers for the poll events into separate functions. They > w

Re: splnet() and SIOCSIFADDR

2014-09-03 Thread Alexander Bluhm
On Wed, Sep 03, 2014 at 03:53:34PM +0200, Martin Pieuchot wrote: > @@ -1078,7 +1079,7 @@ in6_purgeaddr(struct ifaddr *ifa) > void > in6_unlink_ifa(struct in6_ifaddr *ia6, struct ifnet *ifp) > { > - int s = splnet(); > + splsoftassert(IPL_SOFTNET); > > ifa_del(ifp, &ia6->ia_if

Re: minphys woes

2014-09-03 Thread Stefan Fritsch
On Tuesday 02 September 2014 15:22:16, Philip Guenther wrote: > > From physio(9): > > minphys > > A device specific routine called to determine the > >maximum transfer size that the device's strategy routine can > >handle. > > > > Since we have seen that the driver must be able to

Re: syslogd libevent

2014-09-03 Thread Alexander Bluhm
On Fri, Aug 29, 2014 at 11:25:52PM +0200, Alexander Bluhm wrote: > So I will write more tests before committing this. My regression tests found a bug in syslogd. When adding the maximum number of paths with the -a option, the arrays for unix domain socket paths and the poll file descriptors overf

Re: splnet() and SIOCSIFADDR

2014-09-03 Thread Mike Belopuhov
On 3 September 2014 15:53, Martin Pieuchot wrote: > On 03/09/14(Wed) 15:25, Martin Pieuchot wrote: >> Drivers that need a splnet() protection inside their SIOCSIFADDR >> generally raise the spl level themselves, so we should not need >> to do that in in{6,}_ifinit(). One exception to this rule is

Re: splnet() and SIOCSIFADDR

2014-09-03 Thread Martin Pieuchot
On 03/09/14(Wed) 15:25, Martin Pieuchot wrote: > Drivers that need a splnet() protection inside their SIOCSIFADDR > generally raise the spl level themselves, so we should not need > to do that in in{6,}_ifinit(). One exception to this rule is, > as always, carp(4)... > > So the diff below moves t

splnet() and SIOCSIFADDR

2014-09-03 Thread Martin Pieuchot
Drivers that need a splnet() protection inside their SIOCSIFADDR generally raise the spl level themselves, so we should not need to do that in in{6,}_ifinit(). One exception to this rule is, as always, carp(4)... So the diff below moves the spl dance inside carp's SIOCSIFADDR handler, it's a baby