ksh garbage printing

2014-10-04 Thread Martin Natano
The following patch fixes a bug in ksh I reported some time ago (http://marc.info/?l=openbsd-bugsm=137292039914229w=2). I committed this patch to Bitrig in December 2013; it seems to work fine so far. Here the bug report inline for reference. Description: When using a keybinding that

ksh emacs mode cleanup

2014-10-04 Thread Martin Natano
Below some code cleanup for ksh's emacs mode. cheers, natano --- Get rid of left over null elements in x_ftab as NELEM() is used instead. Index: emacs.c === RCS file: /cvs/src/bin/ksh/emacs.c,v retrieving revision 1.48 diff -u

Re: syslogd libevent

2014-10-04 Thread Nicholas Marriott
On Sat, Oct 04, 2014 at 01:29:21AM +0200, Alexander Bluhm wrote: Hi, After some preparation, I can convert syslogd to use libevent now. ok? bluhm Index: usr.sbin/syslogd/Makefile === RCS file:

Re: syslogd libevent

2014-10-04 Thread Alexander Bluhm
On Sat, Oct 04, 2014 at 09:03:58AM +0100, Nicholas Marriott wrote: This should be: LDADD= -levent DPADD= ${LIBEVENT} Rather than LDFLAGS. Here is the updated diff. Index: usr.sbin/syslogd/Makefile === RCS file:

groupdel(8): preserve `+' line

2014-10-04 Thread Miod Vallat
groupdel(8) will complain (and delete) lines which do not have exactly three colon characters in them. This is annoying in yp environments where the last line of /etc/group is usually a single `+' character, which is equivalent to `+:*::' Invoking groupdel when /etc/group contains a final `+'

Re: groupdel(8): preserve `+' line

2014-10-04 Thread Ingo Schwarze
Hi Miod, Miod Vallat wrote on Sat, Oct 04, 2014 at 12:05:48PM +: groupdel(8) That utility is grossly disgusting. It's a pity we can't delete it completely - we have no useable replacement for groupinfo(8). All the other group(8) commands could, imho, be tedu'ed... With respect to

Re: groupdel(8): preserve `+' line

2014-10-04 Thread Theo de Raadt
That utility is grossly disgusting. It's a pity we can't delete it completely [...] Why not? :-)

Re: groupdel(8): preserve `+' line

2014-10-04 Thread Antoine Jacoutot
Do people run this crap as root? I wonder. I certainly don't. Yes. Just like useradd and such. These historical tools are harcoded in so many places and are expected to be present. That said, having someone rewrites them in a sane way would be awesome. -- Antoine

Re: groupdel(8): preserve `+' line

2014-10-04 Thread Miod Vallat
[snip rant] Do people run this crap as root? I wonder. I certainly don't. Then you might want to suggest an alternative to pkg_delete's ``You should also run /usr/sbin/groupdel _foo'' messages.

Re: groupdel(8): preserve `+' line

2014-10-04 Thread Theo de Raadt
[snip rant] Do people run this crap as root? I wonder. I certainly don't. Then you might want to suggest an alternative to pkg_delete's ``You should also run /usr/sbin/groupdel _foo'' messages. Well, the rant is true. Both sets of user/group tools are written to an abominably low

Re: groupdel(8): preserve `+' line

2014-10-04 Thread Ingo Schwarze
Hi Theo, Theo de Raadt wrote on Sat, Oct 04, 2014 at 11:37:21AM -0600: Ingo Schwarze wrote: That utility is grossly disgusting. It's a pity we can't delete it completely [...] Why not? Well, in a non-YP environment, grep ^foobar /etc/group is just fine, but in a YP environment, i'm

Re: mpe patch: use rt_ifa_{add,del}

2014-10-04 Thread Rafael Zalamena
On Thu, Oct 02, 2014 at 02:36:12PM +0200, Martin Pieuchot wrote: On 01/10/14(Wed) 21:54, Rafael Zalamena wrote: --- old chat snip --- Code change: * Moved label address from softc to lladdr ifa I'm afraid this is not what we want. The rest of your diff looks fine but moving the