FIFO fd not marked readable after EOF

2014-10-06 Thread Dimitris Papastamos
Hi everyone, I am using select(2) on a FIFO fd and monitoring for readability. select(2) doesn't return after the writer exits. The same piece of code marks the fd as readable on Linux. Not sure which behaviour is correct though. Doing a very similar test with stdin and closing it before the ca

Re: FIFO fd not marked readable after EOF

2014-10-06 Thread Dimitris Papastamos
On Mon, Oct 06, 2014 at 01:08:57PM +0100, Dimitris Papastamos wrote: > The same piece of code marks the fd as readable on Linux. I tested on NetBSD and it also seems to mark the fd readable. > Doing a very similar test with stdin and closing it before > the call to select(2) behaves as expected a

Re: [patch]lock and unlock like GnuRCS

2014-10-06 Thread Nicholas Marriott
I think that GNU RCS segfaulting for -u -l is enough justification to do what we like, so a message (and last flag wins) like -L/-U would be fine with me. But if we want to do what they probably "meant" to happen then better to match -l -u like Fritjof's diff. On Fri, Oct 03, 2014 at 12:55:35PM

re(4) mtu >1500

2014-10-06 Thread Stuart Henderson
Does anyone have an idea of what's needed for working jumbos on the RL_FLAG_JUMBOV2 variants of re(4) where they're currently disabled? These seem to account for most of the chips seen in hardware designs from the last couple of years (including APU and some others). if ((sc->rl_flags & RL

Re: re(4) mtu >1500

2014-10-06 Thread Chris Cappuccio
Stuart Henderson [s...@spacehopper.org] wrote: > Does anyone have an idea of what's needed for working jumbos on the > RL_FLAG_JUMBOV2 variants of re(4) where they're currently disabled? > These seem to account for most of the chips seen in hardware > designs from the last couple of years (includin

[patch] rcs: stored values never read

2014-10-06 Thread Fritjof Bornebusch
Hi tech, according to scan-build(1) there are a few "never read" values. fritjof Index: co.c === RCS file: /cvs/src/usr.bin/rcs/co.c,v retrieving revision 1.118 diff -u -p -r1.118 co.c --- co.c2 Oct 2014 06:23:15 -

Re: FIFO fd not marked readable after EOF

2014-10-06 Thread Matthew Dempsky
On Mon, Oct 6, 2014 at 5:08 AM, Dimitris Papastamos wrote: > I am using select(2) on a FIFO fd and monitoring > for readability. select(2) doesn't return after the writer > exits. > > The same piece of code marks the fd as readable on Linux. > Not sure which behaviour is correct though. The Linu

Re: Speeding up openbsd on amd64 MP - patch 2/2

2014-10-06 Thread Stefan Fritsch
This is now in -current. If anyone notices problems, give noise. Cheers, Stefan

Re: FIFO fd not marked readable after EOF

2014-10-06 Thread Todd C. Miller
The following diff should fix it. - todd Index: sys/miscfs/fifofs/fifo_vnops.c === RCS file: /home/cvs/openbsd/src/sys/miscfs/fifofs/fifo_vnops.c,v retrieving revision 1.41 diff -u -r1.41 fifo_vnops.c --- sys/miscfs/fifofs/fifo_vnop